From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 07/10] drm/i915: Remove crtc->config dereferences in intel_modeset_setup_hw_state Date: Thu, 11 Oct 2018 14:59:11 +0300 Message-ID: <20181011115911.GD9144@intel.com> References: <20181011100457.8776-1-maarten.lankhorst@linux.intel.com> <20181011100457.8776-8-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ED5C6E3CE for ; Thu, 11 Oct 2018 12:06:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181011100457.8776-8-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMTI6MDQ6NTRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlIENSVEMgaXMgaWRsZSBhdCB0aGlzIHBvaW50LCBzbyB3ZSBjYW4gZGVy ZWZlcmVuY2UgY3J0Yy0+c3RhdGUgc2FmZWx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDExICsrKysrKystLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDE5ZDc3MTRkZjAyMS4uY2JlNzBiYzRk MDJkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNTkzNCw2 ICsxNTkzNCw3IEBAIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOwo+ICAJc3RydWN0IGludGVsX2NydGMgKmNydGM7Cj4gKwlzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKCkNhbiBiZSBtb3ZlZCBpbnRvIG5hcnJvd2VyIHNjb3Bl LgoKPiAgCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyOwo+ICAJaW50IGk7Cj4gIAo+IEBA IC0xNTk1Miw3ICsxNTk1Myw3IEBAIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgCWZvcl9lYWNoX2ludGVsX2NydGMoJmRldl9wcml2LT5kcm0s IGNydGMpIHsKPiAgCQlkcm1fY3J0Y192YmxhbmtfcmVzZXQoJmNydGMtPmJhc2UpOwo+ICAKPiAt CQlpZiAoY3J0Yy0+YWN0aXZlKQo+ICsJCWlmIChjcnRjLT5iYXNlLnN0YXRlLT5hY3RpdmUpCj4g IAkJCWRybV9jcnRjX3ZibGFua19vbigmY3J0Yy0+YmFzZSk7Cj4gIAl9Cj4gIAo+IEBAIC0xNTk2 MSw5ICsxNTk2MiwxMCBAQCBpbnRlbF9tb2Rlc2V0X3NldHVwX2h3X3N0YXRlKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gIAlmb3JfZWFjaF9pbnRlbF9lbmNvZGVyKGRldiwgZW5jb2RlcikKPiAg CQlpbnRlbF9zYW5pdGl6ZV9lbmNvZGVyKGVuY29kZXIpOwo+ICAKPiAtCWZvcl9lYWNoX2ludGVs X2NydGMoJmRldl9wcml2LT5kcm0sIGNydGMpIHsKPiArCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2 LCBjcnRjKSB7CgpJJ2Qga2VlcCB0aGUgZGV2X3ByaXYtPmRybSwgYmVjYXVzZSB3ZSBzaG91bGQg anVzdCBjaGFuZ2UgdGhlIGZ1bmN0aW9uCnRvIHRha2UgdGhlIGRldl9wcml2IGRpcmVjdGx5LgoK QXBhcnQgZnJvbSB0aG9zZQpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwkJY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNfc3Rh dGUoY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gIAkJaW50ZWxfc2FuaXRpemVfY3J0YyhjcnRjLCBjdHgp Owo+IC0JCWludGVsX2R1bXBfcGlwZV9jb25maWcoY3J0YywgY3J0Yy0+Y29uZmlnLAo+ICsJCWlu dGVsX2R1bXBfcGlwZV9jb25maWcoY3J0YywgY3J0Y19zdGF0ZSwKPiAgCQkJCSAgICAgICAiW3Nl dHVwX2h3X3N0YXRlXSIpOwo+ICAJfQo+ICAKPiBAQCAtMTU5OTcsNyArMTU5OTksOCBAQCBpbnRl bF9tb2Rlc2V0X3NldHVwX2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlmb3Jf ZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+ICAJCXU2NCBwdXRfZG9tYWluczsKPiAgCj4g LQkJcHV0X2RvbWFpbnMgPSBtb2Rlc2V0X2dldF9jcnRjX3Bvd2VyX2RvbWFpbnMoJmNydGMtPmJh c2UsIGNydGMtPmNvbmZpZyk7Cj4gKwkJY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNfc3RhdGUo Y3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gKwkJcHV0X2RvbWFpbnMgPSBtb2Rlc2V0X2dldF9jcnRjX3Bv d2VyX2RvbWFpbnMoJmNydGMtPmJhc2UsIGNydGNfc3RhdGUpOwo+ICAJCWlmIChXQVJOX09OKHB1 dF9kb21haW5zKSkKPiAgCQkJbW9kZXNldF9wdXRfcG93ZXJfZG9tYWlucyhkZXZfcHJpdiwgcHV0 X2RvbWFpbnMpOwo+ICAJfQo+IC0tIAo+IDIuMTkuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK