From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 10/10] drm/i915: Remove crtc->active from
 crtc_enable callbacks
Date: Thu, 11 Oct 2018 15:06:22 +0300
Message-ID: <20181011120622.GG9144@intel.com>
References: <20181011100457.8776-1-maarten.lankhorst@linux.intel.com>
 <20181011100457.8776-11-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 91EBA6E05F
 for <intel-gfx@lists.freedesktop.org>; Thu, 11 Oct 2018 12:06:25 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181011100457.8776-11-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMTI6MDQ6NTdQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gTm93IHRoYXQgbW9zdCBvZiB0aGUgZHJpdmVyIGlzIGF0b21pYywgd2Ugbm8g
bG9uZ2VyIG5lZWQgdG8gd29ycnkKPiBhYm91dCBzZXR0aW5nIGNydGMtPmFjdGl2ZSByaWdodCBi
ZWZvcmUgYWN0dWFsbHkgZW5hYmxpbmcgdGhlIHBpcGUuCgpIbW0uIEkgdGhpbmsgd2UgbmVlZCBh
dCBsZWFzdCB0aGF0IHdhaXRfZm9yX3ZibGFua19pZl9hY3RpdmUoKSBjaGFuZ2UKd2UgZGlzY3Vz
c2VkLiBBbmQgbWF5YmUgdGhlcmUncyBzb21ldGhpbmcgaW4gdGhlIHdhdGVybWFyayBjb2RlIHRo
YXQKZGVwZW5kcyBvbiB0aGlzIGJlaW5nIG1vcmUgb3IgbGVzcyBhY2N1cmF0ZSBpbmRpY2F0aW9u
IG9mIHRodyBodyBzdGF0ZS4KVGhhdCBwcm9iYWJseSBuZWVkcyBzb21lIGFjdHVhbCB0aG91Z2h0
LgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9y
c3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmMgfCAyMSArLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEg
aW5zZXJ0aW9uKCspLCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jCj4gaW5kZXggYWQyYzIwN2QxOGJiLi4wZTRiZGQ1YzMzN2UgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTU1ODUsOSArNTU4NSw2IEBAIHN0YXRp
YyB2b2lkIGlyb25sYWtlX2NydGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBl
X2NvbmZpZywKPiAgCXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKm9sZF9pbnRlbF9zdGF0ZSA9
Cj4gIAkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9zdGF0ZSk7Cj4gIAo+IC0JaWYgKFdBUk5f
T04oaW50ZWxfY3J0Yy0+YWN0aXZlKSkKPiAtCQlyZXR1cm47Cj4gLQo+ICAJLyoKPiAgCSAqIFNv
bWV0aW1lcyBzcHVyaW91cyBDUFUgcGlwZSB1bmRlcnJ1bnMgaGFwcGVuIGR1cmluZyBGREkKPiAg
CSAqIHRyYWluaW5nLCBhdCBsZWFzdCB3aXRoIFZHQStIRE1JIGNsb25pbmcuIFN1cHByZXNzIHRo
ZW0uCj4gQEAgLTU2MTcsOCArNTYxNCw2IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX2NydGNfZW5h
YmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCj4gIAlpcm9ubGFr
ZV9zZXRfcGlwZWNvbmYocGlwZV9jb25maWcpOwo+ICAKPiAtCWludGVsX2NydGMtPmFjdGl2ZSA9
IHRydWU7Cj4gLQo+ICAJaW50ZWxfZW5jb2RlcnNfcHJlX2VuYWJsZShjcnRjLCBwaXBlX2NvbmZp
Zywgb2xkX3N0YXRlKTsKPiAgCj4gIAlpZiAocGlwZV9jb25maWctPmhhc19wY2hfZW5jb2Rlcikg
ewo+IEBAIC01NzE1LDkgKzU3MTAsNiBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2NydGNfZW5hYmxl
KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCWJvb2wgcHNsX2Nsa2dh
dGVfd2E7Cj4gIAl1MzIgcGlwZV9jaGlja2VuOwo+ICAKPiAtCWlmIChXQVJOX09OKGludGVsX2Ny
dGMtPmFjdGl2ZSkpCj4gLQkJcmV0dXJuOwo+IC0KPiAgCWludGVsX2VuY29kZXJzX3ByZV9wbGxf
ZW5hYmxlKGNydGMsIHBpcGVfY29uZmlnLCBvbGRfc3RhdGUpOwo+ICAKPiAgCWlmIChwaXBlX2Nv
bmZpZy0+c2hhcmVkX2RwbGwpCj4gQEAgLTU3NTQsOCArNTc0Niw2IEBAIHN0YXRpYyB2b2lkIGhh
c3dlbGxfY3J0Y19lbmFibGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+
ICAKPiAgCWludGVsX2NvbG9yX3NldF9jc2MoJnBpcGVfY29uZmlnLT5iYXNlKTsKPiAgCj4gLQlp
bnRlbF9jcnRjLT5hY3RpdmUgPSB0cnVlOwo+IC0KPiAgCS8qIERpc3BsYXkgV0EgIzExODA6IFdh
RGlzYWJsZVNjYWxhckNsb2NrR2F0aW5nOiBnbGssIGNubCAqLwo+ICAJcHNsX2Nsa2dhdGVfd2Eg
PSAoSVNfR0VNSU5JTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpICYm
Cj4gIAkJCSBwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZDsKPiBAQCAtNjA2Nyw5ICs2MDU3
LDYgQEAgc3RhdGljIHZvaWQgdmFsbGV5dmlld19jcnRjX2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0
Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9
IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gIAlpbnQgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4g
IAo+IC0JaWYgKFdBUk5fT04oaW50ZWxfY3J0Yy0+YWN0aXZlKSkKPiAtCQlyZXR1cm47Cj4gLQo+
ICAJaWYgKGludGVsX2NydGNfaGFzX2RwX2VuY29kZXIocGlwZV9jb25maWcpKQo+ICAJCWludGVs
X2RwX3NldF9tX24ocGlwZV9jb25maWcsIE0xX04xKTsKPiAgCj4gQEAgLTYwODUsOCArNjA3Miw2
IEBAIHN0YXRpYyB2b2lkIHZhbGxleXZpZXdfY3J0Y19lbmFibGUoc3RydWN0IGludGVsX2NydGNf
c3RhdGUgKnBpcGVfY29uZmlnLAo+ICAKPiAgCWludGVsX2NvbG9yX3NldF9jc2MoJnBpcGVfY29u
ZmlnLT5iYXNlKTsKPiAgCj4gLQlpbnRlbF9jcnRjLT5hY3RpdmUgPSB0cnVlOwo+IC0KPiAgCWlu
dGVsX3NldF9jcHVfZmlmb191bmRlcnJ1bl9yZXBvcnRpbmcoZGV2X3ByaXYsIHBpcGUsIHRydWUp
Owo+ICAKPiAgCWludGVsX2VuY29kZXJzX3ByZV9wbGxfZW5hYmxlKGNydGMsIHBpcGVfY29uZmln
LCBvbGRfc3RhdGUpOwo+IEBAIC02MTM1LDkgKzYxMjAsNiBAQCBzdGF0aWMgdm9pZCBpOXh4X2Ny
dGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCXN0cnVj
dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiAgCWVudW0g
cGlwZSBwaXBlID0gaW50ZWxfY3J0Yy0+cGlwZTsKPiAgCj4gLQlpZiAoV0FSTl9PTihpbnRlbF9j
cnRjLT5hY3RpdmUpKQo+IC0JCXJldHVybjsKPiAtCj4gIAlpOXh4X3NldF9wbGxfZGl2aWRlcnMo
cGlwZV9jb25maWcpOwo+ICAKPiAgCWlmIChpbnRlbF9jcnRjX2hhc19kcF9lbmNvZGVyKHBpcGVf
Y29uZmlnKSkKPiBAQCAtNjE0OCw4ICs2MTMwLDYgQEAgc3RhdGljIHZvaWQgaTl4eF9jcnRjX2Vu
YWJsZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gIAo+ICAJaTl4eF9z
ZXRfcGlwZWNvbmYocGlwZV9jb25maWcpOwo+ICAKPiAtCWludGVsX2NydGMtPmFjdGl2ZSA9IHRy
dWU7Cj4gLQo+ICAJaWYgKCFJU19HRU4yKGRldl9wcml2KSkKPiAgCQlpbnRlbF9zZXRfY3B1X2Zp
Zm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBwaXBlLCB0cnVlKTsKPiAgCj4gQEAgLTEy
NTI1LDYgKzEyNTA1LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX2NydGMoc3RydWN0IGRy
bV9jcnRjICpjcnRjLAo+ICAKPiAgCWlmIChtb2Rlc2V0KSB7Cj4gIAkJdXBkYXRlX3NjYW5saW5l
X29mZnNldChwaXBlX2NvbmZpZyk7Cj4gKwkJaW50ZWxfY3J0Yy0+YWN0aXZlID0gdHJ1ZTsKPiAg
CQlkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2VuYWJsZShwaXBlX2NvbmZpZywgc3RhdGUpOwo+ICAK
PiAgCQkvKiB2YmxhbmtzIHdvcmsgYWdhaW4sIHJlLWVuYWJsZSBwaXBlIENSQy4gKi8KPiAtLSAK
PiAyLjE5LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
bnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h
aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==