From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 04/10] drm/i915: Always read out M2_N2 in intel_cpu_transcoder_get_m_n Date: Thu, 11 Oct 2018 22:09:38 +0300 Message-ID: <20181011190938.GM9144@intel.com> References: <20181011100457.8776-1-maarten.lankhorst@linux.intel.com> <20181011100457.8776-5-maarten.lankhorst@linux.intel.com> <20181011115601.GA9144@intel.com> <3b6ede95-7ba3-2ba0-76e8-08cc040d129f@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 081AA6E0C2 for ; Thu, 11 Oct 2018 19:09:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <3b6ede95-7ba3-2ba0-76e8-08cc040d129f@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMDg6MTc6NDlQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTEtMTAtMTggb20gMTM6NTYgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUaHUsIE9jdCAxMSwgMjAxOCBhdCAxMjowNDo1MVBNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBoYXNfZHJycyBpcyBhIGZsYWcgd2UgY2FuJ3QgcmVhZCBvdXQu IFdlIHNldCBpdCB3aGVuIHNlYW1sZXNzIERSUlMgaXMKPiA+PiBlbmFibGVkIGluIHBpcGVfY29u ZmlnLCBzbyBpbnRlbF9kdW1wX3BpcGVfY29uZmlnKCkgYW5kCj4gPj4gaW50ZWxfcGlwZV9jb25m aWdfY29tcGFyZSgpIHdpbGwgY29udGludWUgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nIHdoZW4KPiA+ PiBoYXNfZHJycyBpcyBzZXQgb24gdGhlIHJlYWwgc3RhdGUuCj4gPj4KPiA+PiBUaGlzIHJlbW92 ZXMgb25lIG1vcmUgZGVyZWZlcmVuY2Ugb2YgY3J0Yy0+Y29uZmlnLgo+ID4+IFdoaWxlIGF0IGl0 LCBmaXh1cCB0aGUgY29tbWVudCBhbmQgYWxzbyByZWFkIG91dCBNMl9OMiBmb3IgQ0hWLCBzaW5j ZQo+ID4+IHdlIHByb2dyYW0gaXQgaW4gdGhlIHNldF9tX24gZnVuY3Rpb24uCj4gPj4KPiA+PiBT aWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgfCAxMSArKysrKy0tLS0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+ID4+IGluZGV4IGJiMTZhOWFjZjExNy4uNzgxMmZhYjMxNjQ2IDEwMDY0NAo+ID4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+IEBAIC02ODkzLDggKzY4OTMsOCBA QCBzdGF0aWMgdm9pZCBpbnRlbF9jcHVfdHJhbnNjb2Rlcl9zZXRfbV9uKGNvbnN0IHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YQo+ID4+ICAJCUk5MTVfV1JJVEUoUElQRV9MSU5LX00x KHRyYW5zY29kZXIpLCBtX24tPmxpbmtfbSk7Cj4gPj4gIAkJSTkxNV9XUklURShQSVBFX0xJTktf TjEodHJhbnNjb2RlciksIG1fbi0+bGlua19uKTsKPiA+PiAgCQkvKiBNMl9OMiByZWdpc3RlcnMg dG8gYmUgc2V0IG9ubHkgZm9yIGdlbiA8IDggKE0yX04yIGF2YWlsYWJsZQo+ID4+IC0JCSAqIGZv ciBnZW4gPCA4KSBhbmQgaWYgRFJSUyBpcyBzdXBwb3J0ZWQgKHRvIG1ha2Ugc3VyZSB0aGUKPiA+ PiAtCQkgKiByZWdpc3RlcnMgYXJlIG5vdCB1bm5lY2Vzc2FyaWx5IGFjY2Vzc2VkKS4KPiA+PiAr CQkgKiBmb3IgZ2VuIDwgOCBhbmQgQ0hWKSBhbmQgaWYgRFJSUyBpcyBzdXBwb3J0ZWQgKHRvIG1h a2Ugc3VyZQo+ID4+ICsJCSAqIHRoZSByZWdpc3RlcnMgYXJlIG5vdCB1bm5lY2Vzc2FyaWx5IGFj Y2Vzc2VkKS4KPiA+PiAgCQkgKi8KPiA+PiAgCQlpZiAobTJfbjIgJiYgKElTX0NIRVJSWVZJRVco ZGV2X3ByaXYpIHx8Cj4gPj4gIAkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPCA4KSAmJiBjcnRj X3N0YXRlLT5oYXNfZHJycykgewo+ID4gSSB0aGluayB3aGF0IEknZCByZWFsbHkgbGlrZSB0byBz ZWUgaXMgc3BsaXR0aW5nIHRoZSBtL24gYW5kIG0yL24yIHN0dWZmCj4gPiBpbnRvIHR3byBkaXN0 aW5jdCBwaWVjZXMsIGFuZCB3aGVuIHdlIGRvbid0IHVzZSBkcnJzIHdlIGNvdWxkIGp1c3QKPiA+ IHNldCBtMl9uMiA9IG1fbiwgYW5kIHByb2dyYW0gdGhlIGV2ZXJ5dGhpbmcgZXhhY3RseSB0aGUg c2FtZSB3YXkgYXMKPiA+IHdoZW4gZHJycyBpcyBlbmFibGVkLgo+ID4KPiA+IEFsc28gd2UgY291 bGQgbnVrZSB0aGF0ICJtL24gdnMuIG0yL24yIiBlbnVtIGFuZCBqdXN0IHBhc3MgdGhlIGNvcnJl Y3QKPiA+IHN0cnVjdCB0byBmb29fc2V0X21fbigpIGRpcmVjdGx5Lgo+ID4KPiA+PiBAQCAtODc0 NywxMSArODc0NywxMCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9jcHVfdHJhbnNjb2Rlcl9nZXRfbV9u KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4+ICAJCW1fbi0+dHUgPSAoKEk5MTVfUkVBRChQ SVBFX0RBVEFfTTEodHJhbnNjb2RlcikpCj4gPj4gIAkJCSAgICAmIFRVX1NJWkVfTUFTSykgPj4g VFVfU0laRV9TSElGVCkgKyAxOwo+ID4+ICAJCS8qIFJlYWQgTTJfTjIgcmVnaXN0ZXJzIG9ubHkg Zm9yIGdlbiA8IDggKE0yX04yIGF2YWlsYWJsZSBmb3IKPiA+PiAtCQkgKiBnZW4gPCA4KSBhbmQg aWYgRFJSUyBpcyBzdXBwb3J0ZWQgKHRvIG1ha2Ugc3VyZSB0aGUKPiA+PiAtCQkgKiByZWdpc3Rl cnMgYXJlIG5vdCB1bm5lY2Vzc2FyaWx5IHJlYWQpLgo+ID4+ICsJCSAqIGdlbiA8IDggYW5kIENI VikuCj4gPj4gIAkJICovCj4gPj4gLQkJaWYgKG0yX24yICYmIElOVEVMX0dFTihkZXZfcHJpdikg PCA4ICYmCj4gPj4gLQkJCWNydGMtPmNvbmZpZy0+aGFzX2RycnMpIHsKPiA+PiArCQlpZiAobTJf bjIgJiYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA4IHx8Cj4gPj4gKwkJCSAgICAgIElTX0NIRVJS WVZJRVcoZGV2X3ByaXYpKSkgewo+ID4gSSB0aGluayB0aGlzIGlzIG1heWJlIHRoZSB0aGlyZCBp bnN0YWxsbWVudCBvZiB0aGlzIGNoZWNrLiBDb3VsZAo+ID4gcGVyaGFwcyB1c2UgYSBzbWFsbCBo YXNfbTJfbjIoKSBoZWxwZXIgdG8gYXZvaWQgdGhlIHJlcGV0aXRpb24/Cj4gPgo+ID4gRWl0aGVy IHdheQo+ID4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gSG0gbG9va3MgbGlrZSB0aGlzIGlzIGNhdXNpbmcgYSB1bmNsYWltZWQg cmVnaXN0ZXIgcmVhZCBpbiBkZWJ1Z2ZzLiBDb3VsZCB3ZSBsaW1pdCByZWFkcy93cml0ZXMgdG8g ZURQIHRyYXNuY29kZXI/CgpUaGF0J3Mgbm90IGEgdGhpbmcgb24gbW9zdCBwbGF0Zm9ybXMuCgp0 cmFuc2NvZGVyX2hhc19tMl9uMigpCnsKCWlmIChJU19IQVNXRUxMKQoJCXJldHVybiB0cmFucyA9 PSBFRFA7CglyZXR1cm4gSVNfSUxLIHx8IElTX1NOQiB8fCBJU19JVkIgfHwgSVNfVkxWIHx8IElT X0NIVjsKfQoKPwoKVGhvdWdoIGludGVsX2RwX3NldF9kcnJzX3N0YXRlKCkgb25seSBjbGFpbXMg dG8gc3VwcG9ydCBpdmIrLCBldmVuCnRob3VnaCBpbGsvc25iIHNob3VsZCB3b3JrIHdpdGggdGhl IHNhbWUgY29kZSBhcyBpdmIuIEhtbSwgb2ggcmlnaHQKdGhlIGZkaSBiaXRzIGFyZSBhIGJpdCBi dXN0ZWQgb24gdGhvc2UgcGxhdGZvcm1zLiBTbyBkcnJzIHdvbid0IHdvcmsKYXQgbGVhc3Qgb24g dGhlIHBjaCBwb3J0cyB3aXRoIHRoZSBjdXJyZW50IGNvZGUuIEkgZ3Vlc3MgaXQgbWlnaHQKd29y ayBvbiBwb3J0IEEgZURQLgoKPiA+PiAgCQkJbTJfbjItPmxpbmtfbSA9IEk5MTVfUkVBRChQSVBF X0xJTktfTTIodHJhbnNjb2RlcikpOwo+ID4+ICAJCQltMl9uMi0+bGlua19uID0JSTkxNV9SRUFE KFBJUEVfTElOS19OMih0cmFuc2NvZGVyKSk7Cj4gPj4gIAkJCW0yX24yLT5nbWNoX20gPQlJOTE1 X1JFQUQoUElQRV9EQVRBX00yKHRyYW5zY29kZXIpKQo+ID4+IC0tIAo+ID4+IDIuMTkuMAo+ID4+ Cj4gPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cj4gCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=