All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] open-plc-utils: fix build with static musl
Date: Thu, 11 Oct 2018 20:57:58 +0200	[thread overview]
Message-ID: <20181011205758.72baa707@windsurf> (raw)
In-Reply-To: <20181011182013.16467-1-fontaine.fabrice@gmail.com>

Hello,

On Thu, 11 Oct 2018 20:20:13 +0200, Fabrice Fontaine wrote:
> Pass TARGET_LDFLAGS to EXTRA_LDFLAGS to fix following issue:
> /home/buildroot/autobuild/run/instance-3/output/build/host-gcc-final-7.3.0/build/arm-buildroot-linux-musleabihf/libgcc/../../../libgcc/config/arm/lib1funcs.S:1545: undefined reference to `raise'
> 
> Also pass TARGET_CFLAGS to EXTRA_CFLAGS and TARGET_CXXFLAGS to
> EXTRA_CXXFLAGS and move all these variables to
> OPEN_PLC_UTILS_MAKE_OPTS for readability
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/67bc5e7ac8ae1c49c035b022a394d2f746705cf2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
>  - Instead of passing -static to EXTRA_LDFLAGS, use TARGET_LDFLAGS
>  - pass TARGET_CFLAGS to EXTRA_CFLAGS
>  - pass TARGET_CXXFLAGS to EXTRA_CXXFLAGS

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-10-11 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 18:20 [Buildroot] [PATCH v2, 1/1] open-plc-utils: fix build with static musl Fabrice Fontaine
2018-10-11 18:57 ` Thomas Petazzoni [this message]
2018-10-24 11:10 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011205758.72baa707@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.