From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v6 09/18] ACPI / APEI: Let the notification helper specify the fixmap slot Date: Fri, 12 Oct 2018 13:14:08 +0200 Message-ID: <20181012111408.GC580@zn.tnic> References: <20180921221705.6478-1-james.morse@arm.com> <20180921221705.6478-10-james.morse@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5E8D74A1DC for ; Fri, 12 Oct 2018 07:14:11 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TUBMGT0nlVDq for ; Fri, 12 Oct 2018 07:14:10 -0400 (EDT) Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 990C549F93 for ; Fri, 12 Oct 2018 07:14:10 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20180921221705.6478-10-james.morse@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: James Morse Cc: jonathan.zhang@cavium.com, Rafael Wysocki , Tony Luck , linux-mm@kvack.org, Marc Zyngier , Catalin Marinas , Tyler Baicar , Will Deacon , Dongjiu Geng , linux-acpi@vger.kernel.org, Punit Agrawal , Naoya Horiguchi , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Len Brown List-Id: kvmarm@lists.cs.columbia.edu On Fri, Sep 21, 2018 at 11:16:56PM +0100, James Morse wrote: > ghes_copy_tofrom_phys() uses a different fixmap slot depending on in_nmi(). > This doesn't work when we have multiple NMI-like notifications, that > can interrupt each other. > > As with the locking, move the chosen fixmap_idx to the notification helper. > This only matters for NMI-like notifications, anything calling > ghes_proc() can use the IRQ fixmap slot as its already holding an irqsave > spinlock. > > This lets us collapse the ghes_ioremap_pfn_*() helpers. > > Signed-off-by: James Morse > --- > > The fixmap-idx and vaddr are passed back to ghes_unmap() > to allow ioremap() to be used in process context in the > future. > --- > drivers/acpi/apei/ghes.c | 76 ++++++++++++++-------------------------- > 1 file changed, 27 insertions(+), 49 deletions(-) Nice. Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Fri, 12 Oct 2018 13:14:08 +0200 Subject: [PATCH v6 09/18] ACPI / APEI: Let the notification helper specify the fixmap slot In-Reply-To: <20180921221705.6478-10-james.morse@arm.com> References: <20180921221705.6478-1-james.morse@arm.com> <20180921221705.6478-10-james.morse@arm.com> Message-ID: <20181012111408.GC580@zn.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 21, 2018 at 11:16:56PM +0100, James Morse wrote: > ghes_copy_tofrom_phys() uses a different fixmap slot depending on in_nmi(). > This doesn't work when we have multiple NMI-like notifications, that > can interrupt each other. > > As with the locking, move the chosen fixmap_idx to the notification helper. > This only matters for NMI-like notifications, anything calling > ghes_proc() can use the IRQ fixmap slot as its already holding an irqsave > spinlock. > > This lets us collapse the ghes_ioremap_pfn_*() helpers. > > Signed-off-by: James Morse > --- > > The fixmap-idx and vaddr are passed back to ghes_unmap() > to allow ioremap() to be used in process context in the > future. > --- > drivers/acpi/apei/ghes.c | 76 ++++++++++++++-------------------------- > 1 file changed, 27 insertions(+), 49 deletions(-) Nice. Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by kanga.kvack.org (Postfix) with ESMTP id E7A406B000E for ; Fri, 12 Oct 2018 07:14:10 -0400 (EDT) Received: by mail-wm1-f72.google.com with SMTP id j124-v6so6738113wmd.4 for ; Fri, 12 Oct 2018 04:14:10 -0700 (PDT) Received: from mail.skyhub.de (mail.skyhub.de. [5.9.137.197]) by mx.google.com with ESMTPS id p184-v6si944826wmp.160.2018.10.12.04.14.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 04:14:09 -0700 (PDT) Date: Fri, 12 Oct 2018 13:14:08 +0200 From: Borislav Petkov Subject: Re: [PATCH v6 09/18] ACPI / APEI: Let the notification helper specify the fixmap slot Message-ID: <20181012111408.GC580@zn.tnic> References: <20180921221705.6478-1-james.morse@arm.com> <20180921221705.6478-10-james.morse@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180921221705.6478-10-james.morse@arm.com> Sender: owner-linux-mm@kvack.org List-ID: To: James Morse Cc: linux-acpi@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Marc Zyngier , Christoffer Dall , Will Deacon , Catalin Marinas , Naoya Horiguchi , Rafael Wysocki , Len Brown , Tony Luck , Tyler Baicar , Dongjiu Geng , Xie XiuQi , Punit Agrawal , jonathan.zhang@cavium.com On Fri, Sep 21, 2018 at 11:16:56PM +0100, James Morse wrote: > ghes_copy_tofrom_phys() uses a different fixmap slot depending on in_nmi(). > This doesn't work when we have multiple NMI-like notifications, that > can interrupt each other. > > As with the locking, move the chosen fixmap_idx to the notification helper. > This only matters for NMI-like notifications, anything calling > ghes_proc() can use the IRQ fixmap slot as its already holding an irqsave > spinlock. > > This lets us collapse the ghes_ioremap_pfn_*() helpers. > > Signed-off-by: James Morse > --- > > The fixmap-idx and vaddr are passed back to ghes_unmap() > to allow ioremap() to be used in process context in the > future. > --- > drivers/acpi/apei/ghes.c | 76 ++++++++++++++-------------------------- > 1 file changed, 27 insertions(+), 49 deletions(-) Nice. Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.