From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 04/13] mt76x0: pci: introduce mt76x0_phy_calirate routine
Date: Fri, 12 Oct 2018 14:32:59 +0200 [thread overview]
Message-ID: <20181012123259.GC2668@redhat.com> (raw)
In-Reply-To: <326458a15d0c242e7419e3bfc0033ccdc9083676.1539338611.git.lorenzo.bianconi@redhat.com>
On Fri, Oct 12, 2018 at 12:16:20PM +0200, Lorenzo Bianconi wrote:
> Add mt76x0_phy_calirate routine in order to perform
> phy calibration for mt76x0e devices.
<snip>
> @@ -671,9 +713,14 @@ int mt76x0_phy_set_channel(struct mt76x02_dev *dev,
> /* Vendor driver don't do it */
> /* mt76x0_phy_set_tx_power(dev, channel, rf_bw_band); */
>
> - mt76x0_vco_cal(dev, channel);
> - if (scan)
> - mt76x02_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1, false);
> + if (mt76_is_usb(dev)) {
> + mt76x0_vco_cal(dev, channel);
> + if (scan)
> + mt76x02_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1,
> + false);
> + } else {
> + mt76x0_phy_calibrate(dev, false);
> + }
Why this should be diffrent for USB and PCI ? RF calibration seems
not to be realted to bus type, so perhaps this should be based on
mt76xx_rev() check?
Thanks
Stanislaw
next prev parent reply other threads:[~2018-10-12 12:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 10:16 [PATCH 00/13] add calibration logics for mt76x0e driver Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 01/13] mt76: move mt76x02_phy_set_bw in mt76x02-lib module Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 02/13] mt76: move mt76x02_phy_set_band " Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 03/13] mt76x0: pci: rename mt76x0_phy_calibrate Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 04/13] mt76x0: pci: introduce mt76x0_phy_calirate routine Lorenzo Bianconi
2018-10-12 12:32 ` Stanislaw Gruszka [this message]
2018-10-12 12:51 ` Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 05/13] mt76x0: phy: update set_channel for mt76x0e devices Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 06/13] mt76x0: eeprom: introduce mt76x0_tssi_enabled routine Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 07/13] mt76x0: phy: add phy/vco temperature compensation Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 08/13] mt76: move rssi_gain_thresh routines in mt76x02-lib module Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 09/13] mt76: move mt76x02_phy_adjust_vga_gain in mt76/mt76x02_phy.c Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 10/13] mt76: introduce mt76x02_init_agc_gain routine Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 11/13] mt76x0: phy: align channel gain logic to mt76x2 one Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 12/13] mt76x0: phy: do not run calibration during channel switch Lorenzo Bianconi
2018-10-12 10:16 ` [PATCH 13/13] mt76x0: phy: use proper name convention Lorenzo Bianconi
2018-10-12 20:32 ` [PATCH 00/13] add calibration logics for mt76x0e driver Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012123259.GC2668@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.