From: "Woods, Brian" <Brian.Woods@amd.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Woods, Brian" <Brian.Woods@amd.com>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
Subject: Re: [PATCH v2] amd-iommu: use correct constants in amd_iommu_get_next_table_from_pte()...
Date: Fri, 12 Oct 2018 16:59:18 +0000 [thread overview]
Message-ID: <20181012165914.GA22686@amd.com> (raw)
In-Reply-To: <20180926134407.29963-1-paul.durrant@citrix.com>
On Wed, Sep 26, 2018 at 02:44:07PM +0100, Paul Durrant wrote:
> ...and change the name to amd_iommu_get_address_from_pte() since the
> address read is not necessarily the address of a next level page table.
> (If the 'next level' field is not 1 - 6 then the address is a page
> address).
>
> The constants in use prior to this patch relate to device table entries
> rather than page table entries. Although they do have the same value, it
> makes the code confusing to read.
>
> This patch also changes the PDE/PTE pointer argument to void *, and
> removes any u32/uint32_t casts in the call sites. Unnecessary casts
> surrounding call sites are also removed.
>
> No functional change.
>
> NOTE: The patch also adds emacs boilerplate to iommu_map.c
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Not thrilled about adding the emacs part but it's allowed in the coding
style guide so.
Reviewd-by: Brian Woods <brian.woods@amd.com>
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-10-12 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 13:44 [PATCH v2] amd-iommu: use correct constants in amd_iommu_get_next_table_from_pte() Paul Durrant
2018-10-02 12:32 ` Paul Durrant
2018-10-11 8:25 ` Paul Durrant
2018-10-12 16:59 ` Woods, Brian [this message]
2018-10-12 17:01 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012165914.GA22686@amd.com \
--to=brian.woods@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.