diff for duplicates of <20181013134429.1f450ba7@archlinux> diff --git a/a/1.txt b/N1/1.txt index 2fda6d0..54ab0dc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ On Wed, 10 Oct 2018 12:42:39 +0200 -Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: +Stefan Br=C3=BCns <stefan.bruens@rwth-aachen.de> wrote: > On Montag, 8. Oktober 2018 23:09:04 CEST Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> -> > +> >=20 > > The IIO_CHAN_INFO_SCALE case is missing a break statement and in > > the unlikely event that chan->address is not matched in the nested > > switch statement then the code falls through to the following @@ -11,50 +11,53 @@ Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: > > break. While we are fixing this, it's probably a good idea to > > add in a break statement to the IIO_CHAN_INFO_HARDWAREGAIN case > > too (this is a moot point). -> > -> > Detected by CoverityScan, CID#1462408 ("Missing break in switch") -> -> Although it is good for code clarity to add a break statement, the code can -> never return anything but -EINVAL in case chan->address is not handled in +> >=20 +> > Detected by CoverityScan, CID#1462408 ("Missing break in switch") =20 +>=20 +> Although it is good for code clarity to add a break statement, the code c= +an=20 +> never return anything but -EINVAL in case chan->address is not handled in= +=20 > IIO_CHAN_INFO_SCALE: -> +>=20 > ----- > switch (mask) { > case IIO_CHAN_INFO_SCALE: > switch (chan->address) { > case INA2XX_SHUNT_VOLTAGE: > ... return IIO_VAL_FRACTIONAL; -> +> =20 > case INA2XX_BUS_VOLTAGE: > ... return IIO_VAL_FRACTIONAL; -> +>=20 > case INA2XX_CURRENT: > ... return IIO_VAL_FRACTIONAL; -> +>=20 > case INA2XX_POWER: > ... return IIO_VAL_FRACTIONAL; > } -> +>=20 > case IIO_CHAN_INFO_HARDWAREGAIN: > switch (chan->address) { > case INA2XX_SHUNT_VOLTAGE: > ... return IIO_VAL_FRACTIONAL; -> +> =20 > case INA2XX_BUS_VOLTAGE: > ... return IIO_VAL_INT; > } > } > return -EINVAL; > ----- -> -> The addresses handled in INFO_HARDWAREGAIN is a subset of the ones in +>=20 +> The addresses handled in INFO_HARDWAREGAIN is a subset of the ones in=20 > INFO_SCALE. -> -> I would prefer an early "return -EINVAL" here, as it matches better with the +>=20 +> I would prefer an early "return -EINVAL" here, as it matches better with = +the=20 > other "switch (mask)" cases above. -> +>=20 > Kind regards, -> +>=20 > Stefan I agree with Stefan on this. It is more in keeping with the local @@ -73,4 +76,4 @@ as in that circumstance it's really just noise. Jonathan -> +>=20 diff --git a/a/content_digest b/N1/content_digest index 79b9b06..2edf737 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,23 +2,23 @@ "ref\01884341.stJYpOWv9L@pebbles\0" "From\0Jonathan Cameron <jic23@kernel.org>\0" "Subject\0Re: [PATCH] iio: adc: ina2xx: fix missing break statement\0" - "Date\0Sat, 13 Oct 2018 12:44:29 +0000\0" + "Date\0Sat, 13 Oct 2018 13:44:29 +0100\0" "To\0Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de>\0" "Cc\0Colin King <colin.king@canonical.com>" Hartmut Knaack <knaack.h@gmx.de> Lars-Peter Clausen <lars@metafoo.de> Peter Meerwald-Stadler <pmeerw@pmeerw.net> - linux-iio@vger.kernel.org - kernel-janitors@vger.kernel.org - " linux-kernel@vger.kernel.org\0" + <linux-iio@vger.kernel.org> + <kernel-janitors@vger.kernel.org> + " <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "On Wed, 10 Oct 2018 12:42:39 +0200\n" - "Stefan Br\303\203\302\274ns <stefan.bruens@rwth-aachen.de> wrote:\n" + "Stefan Br=C3=BCns <stefan.bruens@rwth-aachen.de> wrote:\n" "\n" "> On Montag, 8. Oktober 2018 23:09:04 CEST Colin King wrote:\n" "> > From: Colin Ian King <colin.king@canonical.com>\n" - "> > \n" + "> >=20\n" "> > The IIO_CHAN_INFO_SCALE case is missing a break statement and in\n" "> > the unlikely event that chan->address is not matched in the nested\n" "> > switch statement then the code falls through to the following\n" @@ -26,50 +26,53 @@ "> > break. While we are fixing this, it's probably a good idea to\n" "> > add in a break statement to the IIO_CHAN_INFO_HARDWAREGAIN case\n" "> > too (this is a moot point).\n" - "> > \n" - "> > Detected by CoverityScan, CID#1462408 (\"Missing break in switch\") \n" - "> \n" - "> Although it is good for code clarity to add a break statement, the code can \n" - "> never return anything but -EINVAL in case chan->address is not handled in \n" + "> >=20\n" + "> > Detected by CoverityScan, CID#1462408 (\"Missing break in switch\") =20\n" + ">=20\n" + "> Although it is good for code clarity to add a break statement, the code c=\n" + "an=20\n" + "> never return anything but -EINVAL in case chan->address is not handled in=\n" + "=20\n" "> IIO_CHAN_INFO_SCALE:\n" - "> \n" + ">=20\n" "> -----\n" "> switch (mask) {\n" "> case IIO_CHAN_INFO_SCALE:\n" "> switch (chan->address) {\n" "> case INA2XX_SHUNT_VOLTAGE:\n" "> ... return IIO_VAL_FRACTIONAL;\n" - "> \n" + "> =20\n" "> case INA2XX_BUS_VOLTAGE:\n" "> ... return IIO_VAL_FRACTIONAL;\n" - "> \n" + ">=20\n" "> case INA2XX_CURRENT:\n" "> ... return IIO_VAL_FRACTIONAL;\n" - "> \n" + ">=20\n" "> case INA2XX_POWER:\n" "> ... return IIO_VAL_FRACTIONAL;\n" "> }\n" - "> \n" + ">=20\n" "> case IIO_CHAN_INFO_HARDWAREGAIN:\n" "> switch (chan->address) {\n" "> case INA2XX_SHUNT_VOLTAGE:\n" "> ... return IIO_VAL_FRACTIONAL;\n" - "> \n" + "> =20\n" "> case INA2XX_BUS_VOLTAGE:\n" "> ... return IIO_VAL_INT;\n" "> }\n" "> }\n" "> return -EINVAL;\n" "> -----\n" - "> \n" - "> The addresses handled in INFO_HARDWAREGAIN is a subset of the ones in \n" + ">=20\n" + "> The addresses handled in INFO_HARDWAREGAIN is a subset of the ones in=20\n" "> INFO_SCALE.\n" - "> \n" - "> I would prefer an early \"return -EINVAL\" here, as it matches better with the \n" + ">=20\n" + "> I would prefer an early \"return -EINVAL\" here, as it matches better with =\n" + "the=20\n" "> other \"switch (mask)\" cases above.\n" - "> \n" + ">=20\n" "> Kind regards,\n" - "> \n" + ">=20\n" "> Stefan\n" "\n" "I agree with Stefan on this. It is more in keeping with the local\n" @@ -88,6 +91,6 @@ "\n" "Jonathan\n" "\n" - > + >=20 -e1f459ac4b2d10fecd666f417fae0ff3f702c0b3ef0cf93d5e82ec56f2ab5939 +8a0892756dd8c38932485ad0471409c4ed878b35f3ce5261c7e50f2e263cf4cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.