From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF75BC71122 for ; Sat, 13 Oct 2018 17:24:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AECF92077C for ; Sat, 13 Oct 2018 17:24:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EaTl0H4/"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="pIvOawIR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AECF92077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbeJNBCV (ORCPT ); Sat, 13 Oct 2018 21:02:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46608 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbeJNBCV (ORCPT ); Sat, 13 Oct 2018 21:02:21 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 98A3C60A98; Sat, 13 Oct 2018 17:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539451461; bh=szWw1bccvSG2NDJ5kspsHe/wSgo9l3A/OkH5tyWKWvU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=EaTl0H4/YVnflbzqbIKsSsGhenq701nc9VKuwE2stsUmqiH353duJRJ/HApmh0sSR IVdpQKOqfcut5zOJjZNwYhHRvI6+JDYjpGDTRvst/bCvcTyZEnObmSI3xnCRpqxLH6 /GP30oQkcii+NCZhq+Z0KMN6GDpvS7xUyMVFaeHE= Received: from potku.adurom.net (88-114-240-228.elisa-laajakaista.fi [88.114.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B8F1560116; Sat, 13 Oct 2018 17:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539451461; bh=szWw1bccvSG2NDJ5kspsHe/wSgo9l3A/OkH5tyWKWvU=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=pIvOawIRSTmHQxaS2dsAbcsM+Zqvs1jc8dpkJDje9LN+WQp9GVFFQNAwRQi1w2aKK kTGREcmq9ZaDNSBFtPu/PHKsios/nEFYKKc3K5RkJHOIL3cfnok+Y5JKz9ey9vth9j KWbjgcE2IBc5ipt4losqJ2OLLHNqxieK+seCBo48= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B8F1560116 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: remove unnecessary comparison of unsigned integer with < 0 From: Kalle Valo In-Reply-To: <20181005185623.GA14405@embeddedor.com> References: <20181005185623.GA14405@embeddedor.com> To: "Gustavo A. R. Silva" Cc: "David S. Miller" , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20181013172421.98A3C60A98@smtp.codeaurora.org> Date: Sat, 13 Oct 2018 17:24:21 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Gustavo A. R. Silva" wrote: > There is no need to compare *ps_state_enable* with < 0 because > such variable is of type u8 (8 bits, unsigned), making it > impossible to hold a negative value. > > Fix this by removing such comparison. > > Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0") > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7bfd82bff60e ath10k: remove unnecessary comparison of unsigned integer with < 0 -- https://patchwork.kernel.org/patch/10628679/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches