From: Eduardo Habkost <ehabkost@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
qemu-block@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [RFC] Require Python 3 for building QEMU
Date: Sat, 13 Oct 2018 17:36:07 -0300 [thread overview]
Message-ID: <20181013203607.GL31060@habkost.net> (raw)
In-Reply-To: <219bba9b-4102-f838-a46f-11b9704ca78f@redhat.com>
On Sat, Oct 13, 2018 at 08:20:25PM +0200, Max Reitz wrote:
> On 13.10.18 07:02, Eduardo Habkost wrote:
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > I'd like to do this in QEMU 3.1. I think it's time to drop
> > support for old systems that have only Python 2.
> >
> > We still have a few scripts that are not required for building
> > QEMU that still work only with Python 2 (iotests being the most
> > relevant set). Requiring Python 3 for building QEMU won't
> > prevent people from using those scripts with Python 2 until they
> > are finally ported.
>
> It very much does because the iotests specifically use the python path
> qemu was configured with.
>
> To fix this, configure would need to write something else for into
> tests/qemu-iotests/common.env for $PYTHON. But what? I don't really
> want to introduce a new configure option for this.
What's wrong with '/usr/bin/env python2' and just using the
python2 binary from $PATH? Why do we need to make the Python
interpreter path for iotests configurable?
>
> So the real fix is indeed to make the iotests work with Python 3, and I
> think that needs to be done before we can require Python 3. Maybe it
> even needs to be done at the same time.
I agree that this would be even better. I just don't think the
pending iotest porting should force all the rest of the build
scripts to be compatible with Python 2.
--
Eduardo
next prev parent reply other threads:[~2018-10-13 20:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 5:02 [Qemu-devel] [RFC] Require Python 3 for building QEMU Eduardo Habkost
2018-10-13 14:28 ` Eric Blake
2018-10-13 18:20 ` Max Reitz
2018-10-13 20:36 ` Eduardo Habkost [this message]
2018-10-14 11:39 ` Max Reitz
2018-10-15 5:55 ` Markus Armbruster
2018-10-15 11:01 ` Max Reitz
2018-10-15 11:03 ` Max Reitz
2018-10-15 9:32 ` Daniel P. Berrangé
2018-10-15 10:02 ` Peter Maydell
2018-10-15 10:08 ` Daniel P. Berrangé
2018-10-15 10:13 ` Kevin Wolf
2018-10-15 16:33 ` Markus Armbruster
2018-10-15 16:55 ` Peter Maydell
2018-10-15 18:01 ` Eduardo Habkost
2018-10-16 3:59 ` Markus Armbruster
2018-10-16 8:14 ` Peter Maydell
2018-10-15 18:19 ` Christian Borntraeger
2018-10-15 18:33 ` Eduardo Habkost
2018-10-15 18:49 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013203607.GL31060@habkost.net \
--to=ehabkost@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.