All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] efi_loader: support USB boot in distro boot script
Date: Sun, 14 Oct 2018 02:21:11 +0300	[thread overview]
Message-ID: <20181014022111.02f1df62@thinkpad> (raw)
In-Reply-To: <20181012050909.7009-2-takahiro.akashi@linaro.org>

Hi Takahiro,

On Fri, 12 Oct 2018 14:09:07 +0900
AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:

> With this patch, a removable USB mass storage device attached to the
> system will also be scanned to find and boot an EFI binary (that is
> BOOTEFI_NAME, see config_distro_bootcmd.h).
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  include/config_distro_bootcmd.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/config_distro_bootcmd.h
> b/include/config_distro_bootcmd.h index 76e12b7bf4ee..dd47e27d6835
> 100644 --- a/include/config_distro_bootcmd.h
> +++ b/include/config_distro_bootcmd.h
> @@ -26,7 +26,12 @@
>   */
>  
>  #define BOOTENV_SHARED_BLKDEV_BODY(devtypel) \
> -		"if " #devtypel " dev ${devnum}; then " \
> +		"if test " #devtypel " = usb ; then " \
> +			"if " #devtypel " info ${devnum}; then " \
> +				"setenv devtype " #devtypel "; " \
> +				"run scan_dev_for_boot_part; " \
> +			"fi;" \
> +		"elif " #devtypel " dev ${devnum}; then " \
>  			"setenv devtype " #devtypel "; " \
>  			"run scan_dev_for_boot_part; " \
>  		"fi\0"

I can't see how this patch is needed - "usb dev" is a valid command
(via do_usb() -> blk_common_cmd()) as long as CONFIG_USB_STORAGE is set.

  reply	other threads:[~2018-10-13 23:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  5:09 [U-Boot] [PATCH 0/3] uefi: support USB boot in distro boot AKASHI Takahiro
2018-10-12  5:09 ` [U-Boot] [PATCH 1/3] efi_loader: support USB boot in distro boot script AKASHI Takahiro
2018-10-13 23:21   ` Tuomas Tynkkynen [this message]
2018-10-15  4:53     ` AKASHI Takahiro
2018-10-16 13:18       ` Alexander Graf
2018-10-12  5:09 ` [U-Boot] [PATCH 2/3] ARM: qemu-arm: enable usb mass storage in default configuration AKASHI Takahiro
2018-10-16 13:21   ` Alexander Graf
2018-10-18  2:44     ` AKASHI Takahiro
2018-10-12  5:09 ` [U-Boot] [PATCH 3/3] ARM: qemu-arm: enable USB boot in distro boot with UEFI AKASHI Takahiro
2018-10-16 13:22   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181014022111.02f1df62@thinkpad \
    --to=tuomas.tynkkynen@iki.fi \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.