[PATCHv2] nvme/pci: Fix hot removal during error handling

[hch@lst.de (Christoph Hellwig)]

On Fri, Oct 05, 2018@01:24:24PM -0700, Sagi Grimberg wrote:
>
>>>> -	flush_work(&dev->ctrl.reset_work);
>>>> +	cancel_work_sync(&dev->ctrl.reset_work);
>>>
>>> Does reset_work requeue itself? if not I don't fully understand
>>> this change.
>>
>> You'd have to abuse the state machine if reset_work wanted to requeue
>> itself, so that shouldn't happen.
>>
>> We could just leave it as a flush work, and that should be okay too. The
>> cancel_work_sync should accomplish the same, but also prevent the work
>> from even starting if it just so happens to have been pending in a
>> work queue, but that seems very unlikely.
>
> I don't mind, but was looking to understand what it is trying to
> achieve. If you do change that, would be a good idea to include it in
> the change log

Keith, any plans to resend?  Or should I take this one after all?