From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Glauber Date: Mon, 15 Oct 2018 12:47:24 +0000 Subject: Re: [PATCH] EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr() Message-Id: <20181015124713.GA8017@hc> List-Id: References: <20181013102843.GG16086@mwanda> In-Reply-To: <20181013102843.GG16086@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Borislav Petkov Cc: Dan Carpenter , Sergey Temerkhanov , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "kernel-janitors@vger.kernel.org" On Sat, Oct 13, 2018 at 02:28:04PM +0200, Borislav Petkov wrote: > On Sat, Oct 13, 2018 at 01:28:43PM +0300, Dan Carpenter wrote: > > I found this memory leak with static analysis, but it looks like it > > might be pretty bad because it affects the success path. > > > > Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver") > > Signed-off-by: Dan Carpenter > > --- > > It's also possible that I have misread the code. It seems like an > > obvious fix but I haven't tested it. > > > > drivers/edac/thunderx_edac.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Applied, thanks. > > Jan, David, as a further cleanup, you could consider moving that > allocation out of the ISR... [-David who left Cavium] Hi Boris, the allocations happen only in the threaded function handlers, not in hard IRQ context, is that still an issue? thanks, Jan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr() From: Jan Glauber Message-Id: <20181015124713.GA8017@hc> Date: Mon, 15 Oct 2018 12:47:24 +0000 To: Borislav Petkov Cc: Dan Carpenter , Sergey Temerkhanov , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "kernel-janitors@vger.kernel.org" List-ID: T24gU2F0LCBPY3QgMTMsIDIwMTggYXQgMDI6Mjg6MDRQTSArMDIwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IE9uIFNhdCwgT2N0IDEzLCAyMDE4IGF0IDAxOjI4OjQzUE0gKzAzMDAsIERhbiBD YXJwZW50ZXIgd3JvdGU6Cj4gPiBJIGZvdW5kIHRoaXMgbWVtb3J5IGxlYWsgd2l0aCBzdGF0aWMg YW5hbHlzaXMsIGJ1dCBpdCBsb29rcyBsaWtlIGl0Cj4gPiBtaWdodCBiZSBwcmV0dHkgYmFkIGJl Y2F1c2UgaXQgYWZmZWN0cyB0aGUgc3VjY2VzcyBwYXRoLgo+ID4KPiA+IEZpeGVzOiA0MTAwMzM5 NmY5MzIgKCJFREFDLCB0aHVuZGVyeDogQWRkIENhdml1bSBUaHVuZGVyWCBFREFDIGRyaXZlciIp Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5j b20+Cj4gPiAtLS0KPiA+IEl0J3MgYWxzbyBwb3NzaWJsZSB0aGF0IEkgaGF2ZSBtaXNyZWFkIHRo ZSBjb2RlLiAgSXQgc2VlbXMgbGlrZSBhbgo+ID4gb2J2aW91cyBmaXggYnV0IEkgaGF2ZW4ndCB0 ZXN0ZWQgaXQuCj4gPgo+ID4gIGRyaXZlcnMvZWRhYy90aHVuZGVyeF9lZGFjLmMgfCA0ICsrLS0K PiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+ IEFwcGxpZWQsIHRoYW5rcy4KPiAKPiBKYW4sIERhdmlkLCBhcyBhIGZ1cnRoZXIgY2xlYW51cCwg eW91IGNvdWxkIGNvbnNpZGVyIG1vdmluZyB0aGF0Cj4gYWxsb2NhdGlvbiBvdXQgb2YgdGhlIElT Ui4uLgoKWy1EYXZpZCB3aG8gbGVmdCBDYXZpdW1dCgpIaSBCb3JpcywKCnRoZSBhbGxvY2F0aW9u cyBoYXBwZW4gb25seSBpbiB0aGUgdGhyZWFkZWQgZnVuY3Rpb24gaGFuZGxlcnMsIG5vdCBpbgpo YXJkIElSUSBjb250ZXh0LCBpcyB0aGF0IHN0aWxsIGFuIGlzc3VlPwoKdGhhbmtzLApKYW4K