From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id D0A2F60402 for ; Mon, 15 Oct 2018 18:14:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id A30C920CEB; Mon, 15 Oct 2018 18:14:14 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PS5zSSWj_66D; Mon, 15 Oct 2018 18:14:14 +0000 (UTC) Received: from mail.denix.org (pool-100-15-91-218.washdc.fios.verizon.net [100.15.91.218]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 4622220CE1; Mon, 15 Oct 2018 18:14:11 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 7780C1647F7; Mon, 15 Oct 2018 14:14:10 -0400 (EDT) Date: Mon, 15 Oct 2018 14:14:10 -0400 From: Denys Dmytriyenko To: Ankit Navik Message-ID: <20181015181410.GF7186@denix.org> References: <1538581223-13647-1-git-send-email-ankit.tarot@gmail.com> <20181015031245.GB7186@denix.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: openembedded-devel@lists.openembedded.org Subject: Re: [PATCH] opencl-headers: Initial recipe for OpenCL headers X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 18:14:14 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 15, 2018 at 04:13:03PM +0530, Ankit Navik wrote: > Hi Denis, > On Mon, Oct 15, 2018 at 8:42 AM Denys Dmytriyenko wrote: > > > > On Sun, Oct 14, 2018 at 11:29:26AM -0700, Khem Raj wrote: > > > On Sat, Oct 6, 2018 at 1:49 AM Ankit Navik wrote: > > > > > > > > Hi Armin, > > > > > > > > On Thu, Oct 4, 2018 at 4:40 AM akuster808 wrote: > > > > > > > > > > > > > > > > > > > > On 10/03/2018 08:40 AM, Ankit Navik wrote: > > > > > > Add generic recipe for OpenCL API headers. > > > > > > > > > > > > Signed-off-by: Ankit Navik > > > > > > --- > > > > > > .../recipes-core/opencl-headers/opencl-headers_git.bb | 19 +++++++++++++++++++ > > > > > > 1 file changed, 19 insertions(+) > > > > > > create mode 100644 meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > > > > > > > diff --git a/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > new file mode 100644 > > > > > > index 0000000..16bc247 > > > > > > --- /dev/null > > > > > > +++ b/meta-oe/recipes-core/opencl-headers/opencl-headers_git.bb > > > > > > @@ -0,0 +1,19 @@ > > > > > > +SUMMARY = "OpenCL API Headers" > > > > > > +DESCRIPTION = "OpenCL compute API headers from Khronos Group" > > > > > > +LICENSE = "CLOSED" > > > > > There is a license file at the repo. Would adding a "Khronos" license be > > > > > more appropriate? > > > > > > > > > > https://github.com/KhronosGroup/OpenCL-Headers/blob/master/LICENSE > > > > > > > > > > - armin > > > > > > > > I have tried adding "Khronos", but it was throwing QA error for > > > > license. Hence kept it as closed. > > > > Any other suggestion for license ? > > > > > > > > > > Please add a template for this license into meta-oe/licenses and then > > > reference it in relevant recipes. > > > > > > > Regards, Ankit > > > > > > > > > > > +LIC_FILES_CHKSUM = "file://CL/opencl.h;beginline=1;endline=27;md5=687394644e8c4ec4fd3d77f2f86bc042" > > > > > > +SECTION = "base" > > > > > > + > > > > > > +S = "${WORKDIR}/git" > > > > > > +SRCREV = "40c5d226c7c0706f0176884e9b94b3886679c983" > > > > > > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-Headers.git" > > > > > > + > > > > > > +do_configure[noexec] = "1" > > > > > > +do_compile[noexec] = "1" > > > > > > + > > > > > > +do_install () { > > > > > > + install -d ${D}${includedir}/CL/ > > > > > > + for f in ${S}/CL/*.h; do > > > > > > + install -m 0644 $f ${D}${includedir}/CL/ > > > > Single file install? Not very optimized... > Its not a single file, Installing all the header files. It's a single file install in a for loop, hence my comment about being unoptimal. Why not use "cp *.h"? > > > > > > + done > > > > > > +} > > > > > > > > > -- > > > > _______________________________________________ > > > > Openembedded-devel mailing list > > > > Openembedded-devel@lists.openembedded.org > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > -- > > > _______________________________________________ > > > Openembedded-devel mailing list > > > Openembedded-devel@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel >