From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Always read out M2_N2 in intel_cpu_transcoder_get_m_n, v2. Date: Mon, 15 Oct 2018 22:12:00 +0300 Message-ID: <20181015191200.GD9144@intel.com> References: <20181011190938.GM9144@intel.com> <20181015094023.6211-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD08989FAC for ; Mon, 15 Oct 2018 19:12:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181015094023.6211-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTUsIDIwMTggYXQgMTE6NDA6MjNBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gaGFzX2RycnMgaXMgYSBmbGFnIHdlIGNhbid0IHJlYWQgb3V0LiBXZSBzZXQg aXQgd2hlbiBzZWFtbGVzcyBEUlJTIGlzCj4gZW5hYmxlZCBpbiBwaXBlX2NvbmZpZywgc28gaW50 ZWxfZHVtcF9waXBlX2NvbmZpZygpIGFuZAo+IGludGVsX3BpcGVfY29uZmlnX2NvbXBhcmUoKSB3 aWxsIGNvbnRpbnVlIHRvIGRvIHRoZSByaWdodCB0aGluZyB3aGVuCj4gaGFzX2RycnMgaXMgc2V0 IG9uIHRoZSByZWFsIHN0YXRlLgo+IAo+IFRoaXMgcmVtb3ZlcyBvbmUgbW9yZSBkZXJlZmVyZW5j ZSBvZiBjcnRjLT5jb25maWcuCj4gV2hpbGUgYXQgaXQsIGZpeHVwIHRoZSBjb21tZW50IGFuZCBh bHNvIHJlYWQgb3V0IE0yX04yIGZvciBDSFYsIHNpbmNlCj4gd2UgcHJvZ3JhbSBpdCBpbiB0aGUg c2V0X21fbiBmdW5jdGlvbi4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gT25seSByZWFkIG91 dCBNMi9OMiBvbiBwbGF0Zm9ybXMgdGhhdCBzdXBwb3J0IERSUlMuCj4gCj4gU2lnbmVkLW9mZi1i eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K ClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzEg KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0 aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+IGluZGV4IDY0YzFjNmY4ZTBmNC4uMWNhOTNjYjg5ODQyIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC02NzY5LDYgKzY3NjksMTkgQEAgc3RhdGljIHZv aWQgaW50ZWxfcGNoX3RyYW5zY29kZXJfc2V0X21fbihjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGEKPiAgCUk5MTVfV1JJVEUoUENIX1RSQU5TX0xJTktfTjEocGlwZSksIG1f bi0+bGlua19uKTsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wgdHJhbnNjb2Rlcl9oYXNfbTJfbjIo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJIGVudW0gdHJhbnNjb2Rl ciB0cmFuc2NvZGVyKQo+ICt7Cj4gKwlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpCj4gKwkJcmV0 dXJuIHRyYW5zY29kZXIgPT0gVFJBTlNDT0RFUl9FRFA7Cj4gKwo+ICsJLyoKPiArCSAqIFN0cmlj dGx5IHNwZWFraW5nIHNvbWUgcmVnaXN0ZXJzIGFyZSBhdmFpbGFibGUgYmVmb3JlCj4gKwkgKiBn ZW43LCBidXQgd2Ugb25seSBzdXBwb3J0IERSUlMgb24gZ2VuNysKPiArCSAqLwo+ICsJcmV0dXJu IElTX0dFTjcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpOwo+ICt9Cj4gKwo+ ICBzdGF0aWMgdm9pZCBpbnRlbF9jcHVfdHJhbnNjb2Rlcl9zZXRfbV9uKGNvbnN0IHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkJCSBjb25zdCBzdHJ1Y3QgaW50ZWxf bGlua19tX24gKm1fbiwKPiAgCQkJCQkgY29uc3Qgc3RydWN0IGludGVsX2xpbmtfbV9uICptMl9u MikKPiBAQCAtNjc4MywxMiArNjc5NiwxMiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9jcHVfdHJhbnNj b2Rlcl9zZXRfbV9uKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YQo+ICAJ CUk5MTVfV1JJVEUoUElQRV9EQVRBX04xKHRyYW5zY29kZXIpLCBtX24tPmdtY2hfbik7Cj4gIAkJ STkxNV9XUklURShQSVBFX0xJTktfTTEodHJhbnNjb2RlciksIG1fbi0+bGlua19tKTsKPiAgCQlJ OTE1X1dSSVRFKFBJUEVfTElOS19OMSh0cmFuc2NvZGVyKSwgbV9uLT5saW5rX24pOwo+IC0JCS8q IE0yX04yIHJlZ2lzdGVycyB0byBiZSBzZXQgb25seSBmb3IgZ2VuIDwgOCAoTTJfTjIgYXZhaWxh YmxlCj4gLQkJICogZm9yIGdlbiA8IDgpIGFuZCBpZiBEUlJTIGlzIHN1cHBvcnRlZCAodG8gbWFr ZSBzdXJlIHRoZQo+IC0JCSAqIHJlZ2lzdGVycyBhcmUgbm90IHVubmVjZXNzYXJpbHkgYWNjZXNz ZWQpLgo+ICsJCS8qCj4gKwkJICogIE0yX04yIHJlZ2lzdGVycyBhcmUgc2V0IG9ubHkgaWYgRFJS UyBpcyBzdXBwb3J0ZWQKPiArCQkgKiAodG8gbWFrZSBzdXJlIHRoZSByZWdpc3RlcnMgYXJlIG5v dCB1bm5lY2Vzc2FyaWx5IGFjY2Vzc2VkKS4KPiAgCQkgKi8KPiAtCQlpZiAobTJfbjIgJiYgKElT X0NIRVJSWVZJRVcoZGV2X3ByaXYpIHx8Cj4gLQkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPCA4 KSAmJiBjcnRjX3N0YXRlLT5oYXNfZHJycykgewo+ICsJCWlmIChtMl9uMiAmJiBjcnRjX3N0YXRl LT5oYXNfZHJycyAmJgo+ICsJCSAgICB0cmFuc2NvZGVyX2hhc19tMl9uMihkZXZfcHJpdiwgdHJh bnNjb2RlcikpIHsKPiAgCQkJSTkxNV9XUklURShQSVBFX0RBVEFfTTIodHJhbnNjb2RlciksCj4g IAkJCQkJVFVfU0laRShtMl9uMi0+dHUpIHwgbTJfbjItPmdtY2hfbSk7Cj4gIAkJCUk5MTVfV1JJ VEUoUElQRV9EQVRBX04yKHRyYW5zY29kZXIpLCBtMl9uMi0+Z21jaF9uKTsKPiBAQCAtODYzNywx MiArODY1MCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX2NwdV90cmFuc2NvZGVyX2dldF9tX24oc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJbV9uLT5nbWNoX24gPSBJOTE1X1JFQUQoUElQRV9E QVRBX04xKHRyYW5zY29kZXIpKTsKPiAgCQltX24tPnR1ID0gKChJOTE1X1JFQUQoUElQRV9EQVRB X00xKHRyYW5zY29kZXIpKQo+ICAJCQkgICAgJiBUVV9TSVpFX01BU0spID4+IFRVX1NJWkVfU0hJ RlQpICsgMTsKPiAtCQkvKiBSZWFkIE0yX04yIHJlZ2lzdGVycyBvbmx5IGZvciBnZW4gPCA4IChN Ml9OMiBhdmFpbGFibGUgZm9yCj4gLQkJICogZ2VuIDwgOCkgYW5kIGlmIERSUlMgaXMgc3VwcG9y dGVkICh0byBtYWtlIHN1cmUgdGhlCj4gLQkJICogcmVnaXN0ZXJzIGFyZSBub3QgdW5uZWNlc3Nh cmlseSByZWFkKS4KPiAtCQkgKi8KPiAtCQlpZiAobTJfbjIgJiYgSU5URUxfR0VOKGRldl9wcml2 KSA8IDggJiYKPiAtCQkJY3J0Yy0+Y29uZmlnLT5oYXNfZHJycykgewo+ICsKPiArCQlpZiAobTJf bjIgJiYgdHJhbnNjb2Rlcl9oYXNfbTJfbjIoZGV2X3ByaXYsIHRyYW5zY29kZXIpKSB7Cj4gIAkJ CW0yX24yLT5saW5rX20gPSBJOTE1X1JFQUQoUElQRV9MSU5LX00yKHRyYW5zY29kZXIpKTsKPiAg CQkJbTJfbjItPmxpbmtfbiA9CUk5MTVfUkVBRChQSVBFX0xJTktfTjIodHJhbnNjb2RlcikpOwo+ ICAJCQltMl9uMi0+Z21jaF9tID0JSTkxNV9SRUFEKFBJUEVfREFUQV9NMih0cmFuc2NvZGVyKSkK PiAtLSAKPiAyLjE5LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==