From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinclair Yeh Subject: Re: [PATCH v3 02/18] drm: Add a new helper to validate damage during atomic_check Date: Mon, 15 Oct 2018 22:01:55 +0000 Message-ID: <20181015215759.GA14991@vmware.com> References: <20181011001657.1715-1-drawat@vmware.com> <20181011001657.1715-2-drawat@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0041.outbound.protection.outlook.com [104.47.36.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 512D86E0E8 for ; Mon, 15 Oct 2018 22:02:01 +0000 (UTC) In-Reply-To: <20181011001657.1715-2-drawat@vmware.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Deepak Singh Rawat Cc: Thomas Hellstrom , Daniel Vetter , "dri-devel@lists.freedesktop.org" , linux-graphics-maintainer List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMTAsIDIwMTggYXQgMDU6MTY6NDFQTSAtMDcwMCwgRGVlcGFrIFJhd2F0IHdy b3RlOgo+IFRoaXMgaGVscGVyIGZ1bmN0aW9uIG1ha2VzIHN1cmUgdGhhdCBkYW1hZ2UgZnJvbSBw bGFuZSBzdGF0ZSBpcwo+IGRpc2NhcmRlZCBmb3IgZnVsbCBtb2Rlc2V0IGN5Y2xlLiBGb3Igc29t ZSByZWFzb24sIHdoaWNoIG1ha2VzIGRhbWFnZQo+IGlycmVsZXZhbnQsIGRyaXZlciBtaWdodCB3 YW50IHRvIGRvIGEgZnVsbCBwbGFuZSB1cGRhdGUgZm9yIGUuZy4gZnVsbAo+IG1vZGVzZXQuIFN1 Y2ggY2FzZXMgbXVzdCBiZSBjaGVja2VkIGhlcmUuCj4gCj4gQ2M6IHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tCj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ Cj4gQ2M6IFBla2thIFBhYWxhbmVuIDxwcGFhbGFuZW5AZ21haWwuY29tPgo+IENjOiBEYW5pZWwg U3RvbmUgPGRhbmllbEBmb29pc2hiYXIub3JnPgo+IFNpZ25lZC1vZmYtYnk6IERlZXBhayBSYXdh dCA8ZHJhd2F0QHZtd2FyZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X2hlbHBlci5jIHwgIDMgKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBlci5j IHwgMzggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2Rh bWFnZV9oZWxwZXIuaCAgICAgfCAgMiArKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDQzIGluc2VydGlv bnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IDM1Mzk1NTc3 Y2E4Ni4uNDFkYWJiODE3YzU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMK PiBAQCAtMzIsNiArMzIsNyBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJt X3dyaXRlYmFjay5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9kYW1hZ2VfaGVscGVyLmg+Cj4gICNp bmNsdWRlIDxsaW51eC9kbWEtZmVuY2UuaD4KPiAgCj4gICNpbmNsdWRlICJkcm1fY3J0Y19oZWxw ZXJfaW50ZXJuYWwuaCIKPiBAQCAtODI4LDYgKzgyOSw4IEBAIGRybV9hdG9taWNfaGVscGVyX2No ZWNrX3BsYW5lcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAKPiAgCQlkcm1fYXRvbWljX2hl bHBlcl9wbGFuZV9jaGFuZ2VkKHN0YXRlLCBvbGRfcGxhbmVfc3RhdGUsIG5ld19wbGFuZV9zdGF0 ZSwgcGxhbmUpOwo+ICAKPiArCQlkcm1fYXRvbWljX2hlbHBlcl9jaGVja19wbGFuZV9kYW1hZ2Uo c3RhdGUsIG5ld19wbGFuZV9zdGF0ZSk7Cj4gKwo+ICAJCWlmICghZnVuY3MgfHwgIWZ1bmNzLT5h dG9taWNfY2hlY2spCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RhbWFnZV9o ZWxwZXIuYwo+IGluZGV4IDhkYzkwNmE0ODlhOS4uYzEzMDUxNGJiYjIxIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9kYW1hZ2VfaGVscGVyLmMKPiBAQCAtMjksNiArMjksNyBAQAo+ICAgKgo+ICAgKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKiovCj4gIAo+ICsjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWMuaD4KPiAgI2lu Y2x1ZGUgPGRybS9kcm1fZGFtYWdlX2hlbHBlci5oPgo+ICAKPiAgLyoqCj4gQEAgLTgxLDMgKzgy LDQwIEBAIHZvaWQgZHJtX3BsYW5lX2VuYWJsZV9mYl9kYW1hZ2VfY2xpcHMoc3RydWN0IGRybV9w bGFuZSAqcGxhbmUpCj4gIAkJCQkgICAwKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9wbGFu ZV9lbmFibGVfZmJfZGFtYWdlX2NsaXBzKTsKPiArCj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2hl bHBlcl9jaGVja19wbGFuZV9kYW1hZ2UgLSBWZXJpZnkgcGxhbmUgZGFtYWdlIG9uIGF0b21pY19j aGVjay4KPiArICogQHN0YXRlOiBUaGUgZHJpdmVyIHN0YXRlIG9iamVjdC4KPiArICogQHBsYW5l X3N0YXRlOiBQbGFuZSBzdGF0ZSBmb3Igd2hpY2ggdG8gdmVyaWZ5IGRhbWFnZS4KPiArICoKPiAr ICogVGhpcyBoZWxwZXIgZnVuY3Rpb24gbWFrZXMgc3VyZSB0aGF0IGRhbWFnZSBmcm9tIHBsYW5l IHN0YXRlIGlzIGRpc2NhcmRlZAo+ICsgKiBmb3IgZnVsbCBtb2Rlc2V0IGN5Y2xlLiBGb3Igc29t ZSByZWFzb24sIHdoaWNoIG1ha2VzIGRhbWFnZSBpcnJlbGV2YW50LAogICAgICAgICAgcmVtb3Zl ICJjeWNsZSIgXiAgICAgXlJlYWRzIHdlaXJkLi4gbWF5YmUuLi4KCgkgIklmIHRoZXJlIGFyZSBt b3JlIHJlYXNvbnMgYSBkcml2ZXIgd291bGQgd2FudCB0byBkbyBhIGZ1bGwgcGxhbmUKCSAgdXBk YXRlIHJhdGhlciB0aGFuIHByb2Nlc3NpbmcgaW5kaXZpZHVhbCBkYW1hZ2UgcmVnaW9ucywgdGhl bgoJICB0aG9zZSBjYXNlcyBzaG91bGQgYmUgdGFrZW4gY2FyZSBvZiBoZXJlLiIKCj4gKyAqIGRy aXZlciBtaWdodCB3YW50IHRvIGRvIGEgZnVsbCBwbGFuZSB1cGRhdGUgZm9yIGUuZy4gZnVsbCBt b2Rlc2V0LiBTdWNoCj4gKyAqIGNhc2VzIG11c3QgYmUgY2hlY2tlZCBoZXJlLiBOb3RlIHRoYXQg TlVMTCAmZHJtX3BsYW5lX3N0YXRlLmZiX2RhbWFnZV9jbGlwcwogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIF4gZHJtX3BsYW5lX3N0YXRlLmZiX2RhbWFnZV9jbGlw cyA9PSBOVUxMCgo+ICsgKiBpbiBwbGFuZSBzdGF0ZSBtZWFucyB0aGF0IGZ1bGwgdXBkYXRlIHNo b3VsZCBoYXBwZW4uIEl0IGFsc28gZW5zdWUgaGVscGVyCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeIGVuc3VyZSg/KSB0 aGF0IHRoZQo+ICsgKiBpdGVyYXRvciB0byByZXR1cm4gJmRybV9wbGFuZV9zdGF0ZS5zcmMgYXMg ZGFtYWdlLgogICAgICAgICAgICAgICBecy90by93aWxsCgoKPiArICoKPiArICogQ3VycmVudGx5 IHRoaXMgaGVscGVyIGRpc2NhcmQgZGFtYWdlIGR1cmluZyBmdWxsIG1vZGVzZXQgb25seS4gVGhp cyBpcwogICAgICAgICAgICAgICAgICAgICAgICAgICAgXiBkaXNjYXJkcwoKVGhlIHJlc3Qgb2Yg dGhlIHBhcmFncmFwaCByZWFkcyBraW5kIG9mIHN0cmFuZ2UsIGFuZCBwcmV0dHkgbXVjaCByZXBl YXRzCndoYXQgaGFzIGFscmVhZHkgYmVlbiBzYWlkLCBzbyBtYXliZSBqdXN0IHJlbW92ZSBpdD8K Cj4gKyAqIGJlY2F1c2UsIHByZXNlbnRseSBvbmx5IHZtd2dmeCBleHBvc2VzIGRhbWFnZSBpbnRl cmZhY2UsIHdoaWNoIG5lZWQgZnVsbAo+ICsgKiBwbGFuZSB1cGRhdGUgZHVyaW5nIGZ1bGwgbW9k ZXNldCBvbmx5LiBBcyBtb3JlIGRyaXZlciBhZGQgZGFtYWdlIHN1cHBvcnQsCj4gKyAqIHNob3Vs ZCBhbnkgc3RhdGUgY2hhbmdlIG5lZWQgZnVsbCBwbGFuZSB1cGRhdGUsIG11c3QgYmUgYWRkZWQg aGVyZS4KPiArICovCj4gK3ZvaWQgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVfZGFtYWdl KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJCQkgIHN0cnVjdCBkcm1fcGxh bmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNy dGNfc3RhdGU7Cj4gKwo+ICsJaWYgKHBsYW5lX3N0YXRlLT5jcnRjKSB7Cj4gKwkJY3J0Y19zdGF0 ZSA9IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLAo+ICsJCQkJCQkJICAgcGxh bmVfc3RhdGUtPmNydGMpOwo+ICsKPiArCQlpZiAoV0FSTl9PTighY3J0Y19zdGF0ZSkpCj4gKwkJ CXJldHVybjsKPiArCj4gKwkJaWYgKGRybV9hdG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KGNydGNf c3RhdGUpKSB7Cj4gKwkJCWRybV9wcm9wZXJ0eV9ibG9iX3B1dChwbGFuZV9zdGF0ZS0+ZmJfZGFt YWdlX2NsaXBzKTsKPiArCQkJcGxhbmVfc3RhdGUtPmZiX2RhbWFnZV9jbGlwcyA9IE5VTEw7Cj4g KwkJfQo+ICsJfQo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfY2hlY2tf cGxhbmVfZGFtYWdlKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2RhbWFnZV9oZWxw ZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmgKPiBpbmRleCA0OTQ3YzYxNGZm ZjkuLjU5NTg0Y2JmM2Q0MCAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fZGFtYWdlX2hl bHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2RhbWFnZV9oZWxwZXIuaAo+IEBAIC0zNSw1 ICszNSw3IEBACj4gICNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4KPiAgCj4gIHZv aWQgZHJtX3BsYW5lX2VuYWJsZV9mYl9kYW1hZ2VfY2xpcHMoc3RydWN0IGRybV9wbGFuZSAqcGxh bmUpOwo+ICt2b2lkIGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX2RhbWFnZShzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCQkJICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRl ICpwbGFuZV9zdGF0ZSk7Cj4gIAo+ICAjZW5kaWYKPiAtLSAKPiAyLjE3LjEKPiAKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==