All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick
Date: Mon, 15 Oct 2018 22:15:54 +0200	[thread overview]
Message-ID: <20181015221554.1fade38f@gmx.net> (raw)
In-Reply-To: <20181015190217.GA31890@blarch>

Hello Alexander,

On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch <1zeeky@gmail.com> wrote:

> The Location module for QtQuick depends on this library, which was not
> being copied in the build rule.
> 
> Signed-off-by: Alexander 'z33ky' Hirsch <1zeeky@gmail.com>
> ---
>  package/qt5/qt5location/qt5location.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/qt5/qt5location/qt5location.mk b/package/qt5/qt5location/qt5location.mk
> index 18253e9..fe26b6e 100644
> --- a/package/qt5/qt5location/qt5location.mk
> +++ b/package/qt5/qt5location/qt5location.mk
> @@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION
>  	cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib
>  	cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/
>  endef

Should depend on BR2_PACKAGE_QT5_VERSION_LATEST because the library is not
build/installed in the Qt5.6.x case:

+ ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)

> +define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK
> +	cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib
> +endef

+ endif

Thanks for the patch, mind to resend with the changes?

Regards,
Peter

>  ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
>  define QT5LOCATION_INSTALL_TARGET_EXAMPLES
>  	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/
> @@ -59,6 +62,7 @@ endef
>  
>  define QT5LOCATION_INSTALL_TARGET_CMDS
>  	$(QT5LOCATION_INSTALL_TARGET_POSITION)
> +	$(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK)
>  	$(QT5LOCATION_INSTALL_TARGET_LOCATION)
>  	$(QT5LOCATION_INSTALL_TARGET_QMLS)
>  	$(QT5LOCATION_INSTALL_TARGET_EXAMPLES)

       reply	other threads:[~2018-10-15 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181015190217.GA31890@blarch>
2018-10-15 20:15 ` Peter Seiderer [this message]
2018-10-15 21:22   ` [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick Alexander 'z33ky' Hirsch
2018-10-16 21:49     ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015221554.1fade38f@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.