All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Cheng Fei Phung <feiphung@hotmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>
Subject: Re: [PATCH] Staging : Add RIFFA PCIe driver
Date: Tue, 16 Oct 2018 12:58:24 +0200	[thread overview]
Message-ID: <20181016105824.GA16641@kroah.com> (raw)
In-Reply-To: <SG2PR06MB317677E129AECC23CF5705A3C1FE0@SG2PR06MB3176.apcprd06.prod.outlook.com>

On Tue, Oct 16, 2018 at 10:54:28AM +0000, Cheng Fei Phung wrote:
> This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux
> 
> TODO:
> 
> 1) this driver needs further speed optimization although it can now achieve defined PCIe speed grade
> 2) solve all the coding style errors from scripts/checkpatch.pl

Can you please wrap your lines at 72 columns like your editor wanted you
to?  :)

> 
> Signed-off-by: PHUNG CHENG FEI (feiphung@hotmail.com)

So close, you need to use '<' and '>' here, not '(' and ')'

> 
> ---
> Changes in v1:
> � - added full-duplex capability
> 
> �drivers/staging/riffa/Makefile������ |� 157 +++
> �drivers/staging/riffa/README.txt���� |�� 38 +
> �drivers/staging/riffa/circ_queue.c�� |� 188 +++
> �drivers/staging/riffa/circ_queue.h�� |�� 96 ++
> �drivers/staging/riffa/riffa.c������� |� 152 +++
> �drivers/staging/riffa/riffa.h������� |� 121 ++
> �drivers/staging/riffa/riffa_driver.c | 1633 ++++++++++++++++++++++++++
> �drivers/staging/riffa/riffa_driver.h |� 131 +++
> �8 files changed, 2516 insertions(+)
> �create mode 100644 drivers/staging/riffa/Makefile
> �create mode 100644 drivers/staging/riffa/README.txt
> �create mode 100644 drivers/staging/riffa/circ_queue.c
> �create mode 100644 drivers/staging/riffa/circ_queue.h
> �create mode 100644 drivers/staging/riffa/riffa.c
> �create mode 100644 drivers/staging/riffa/riffa.h
> �create mode 100644 drivers/staging/riffa/riffa_driver.c
> �create mode 100644 drivers/staging/riffa/riffa_driver.h

This does not actually add the driver to the kernel build process at
all.  How are you testing this?  You need to hook it up by adding a
Kconfig file and touching the drivers/staging/Kconfig and
drivers/staging/Makefile files to add your code to the build system.

As it is, this doesn't work at all :(

And none of your code has any tabs in it at all.  You should at least
fix that up first, otherwise the very first patch people are going to
be forced to send will be to replace all lines in all of these files
with that type of modification.  It is better if you do that first.

thanks,

greg k-h

  parent reply	other threads:[~2018-10-16 18:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <SG2PR06MB31763736BF5D2F346D19C12EC1FE0@SG2PR06MB3176.apcprd06.prod.outlook.com>
     [not found] ` <SG2PR06MB3176B20AA8DAB164A73568B7C1FE0@SG2PR06MB3176.apcprd06.prod.outlook.com>
2018-10-16  8:27   ` [PATCH] Add RIFFA PCIe driver to staging tree gregkh
     [not found]   ` <SG2PR06MB317685E4238622AF0EB38684C1FE0@SG2PR06MB3176.apcprd06.prod.outlook.com>
     [not found]     ` <SG2PR06MB31766B83E9967845C17E7B58C1FE0@SG2PR06MB3176.apcprd06.prod.outlook.com>
     [not found]       ` <SG2PR06MB317677E129AECC23CF5705A3C1FE0@SG2PR06MB3176.apcprd06.prod.outlook.com>
2018-10-16 10:58         ` gregkh [this message]
2018-10-16 11:54         ` [PATCH] Staging : Add RIFFA PCIe driver Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016105824.GA16641@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=feiphung@hotmail.com \
    --cc=linux-fpga@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.