From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6612898342094503936 X-Received: by 2002:a50:ba57:: with SMTP id 23-v6mr5104950eds.7.1539693465497; Tue, 16 Oct 2018 05:37:45 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a50:9970:: with SMTP id l45-v6ls8475705edb.9.gmail; Tue, 16 Oct 2018 05:37:44 -0700 (PDT) X-Google-Smtp-Source: ACcGV61eRpu4ER1WgwLs8/dcorP3RLMHLVf5OwXgGN4qWAEY7CJie5kGGOqx8QOD+FZfUtYeTZzj X-Received: by 2002:a50:a550:: with SMTP id z16-v6mr5106404edb.12.1539693464392; Tue, 16 Oct 2018 05:37:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539693464; cv=none; d=google.com; s=arc-20160816; b=kqlhXg6XBJBlyqEPof6gJsrnHfALYhx3pGITVwvbEKxfIH/eW2ZuiB5lm+MJFi+1HR +h87784Cd0vBiW8X2UQrXT+hlzKY5NpzHzw3n+tHKFNA6T5rYqcxXEZhW3y63i/SQ+ah 6kwO25hr2L5HJ4AsTEKEOsXwt7YrRcO9wYwkS22jWZjDMUfxNTyTvnk3RLstyyO5Dw9z 6AedZPGJsQ1k0xDQsOXgSK8+pGKLtNvXjXBwOXnHRLYA0Dj2QD1P8UMXAyKRDAVEIMmF PFEMpdXQsYssi9Xj150U1/u7pH4p3Gi43ELViBaXMg0H95bhY44AzGw1c327xmvsv8rX P45Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:sender:dkim-signature; bh=4OZ+nFkCP+OZ+hRduxtHg76wiasGfzqEvFS8NknmPOE=; b=KutU3IOOij31bsxICo4Js7OFFYQ/jDfqJmuV3pGvGB75/ZdqcsRk5TGONfz9vjg7Eq VVymIgKZMHf4RKYScOuBed25jvZJdD/EYEHIgA1xpDcHtJz/m+gRFHrYrszNskgp38I3 FmoCEzNHkmLJZNJTOZIG51GKcOWqUl9071QTqftNhjj9HE6u0HirogC3TwlFK4A8Rl+x hziwT5GLVc/YQWuxFPlWRf5MrhkyLOKEfkfzt0tBs4hXz6aCiw+cxmWou3zsrnf9WU4n k0etUxnJhovrXGjVBxw1ObnoCTfArRGfvfeV9OVgmAvKsChKl/Q6PNDuLDs0EdtDcKE0 JXBQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="Xhxk/YIb"; spf=neutral (google.com: 2a00:1450:4864:20::544 is neither permitted nor denied by best guess record for domain of daniel@ffwll.ch) smtp.mailfrom=daniel@ffwll.ch Return-Path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com. [2a00:1450:4864:20::544]) by gmr-mx.google.com with ESMTPS id cj24-v6si453671ejb.1.2018.10.16.05.37.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 05:37:44 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:4864:20::544 is neither permitted nor denied by best guess record for domain of daniel@ffwll.ch) client-ip=2a00:1450:4864:20::544; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="Xhxk/YIb"; spf=neutral (google.com: 2a00:1450:4864:20::544 is neither permitted nor denied by best guess record for domain of daniel@ffwll.ch) smtp.mailfrom=daniel@ffwll.ch Received: by mail-ed1-x544.google.com with SMTP id r1-v6so21161059edd.7 for ; Tue, 16 Oct 2018 05:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4OZ+nFkCP+OZ+hRduxtHg76wiasGfzqEvFS8NknmPOE=; b=Xhxk/YIbESI8iNPTP/38BIypOp0TOEZ4ShaabccQxpSd8/cWHd3u7oTznx19QDxEU9 jOihJUlnYtraTsZ2Jj9nSaWffpLU81vUH/8aq9U9KuYYLCK8HtaiugPlJ03qmDV78X6M Tt0egMaj8LAxyOUe35HjrfhyzKdJHGfjO7xjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=4OZ+nFkCP+OZ+hRduxtHg76wiasGfzqEvFS8NknmPOE=; b=KUZ20WnzDivMQSSczUNSm2FJQbwL1wA/GiPhPIrikhbWJ/tl/KKQObpFEvQCp4uQ1x ZiIPfTDKNiiu/wrwjie/aiZcctWKS9e6xtAfgbbVnJNAly/6p4pbax9JqHghX8ADb+VW 8sG/m4qELqFJaz5lEfpvIXjzl5ERL6PhYgRri60/sxeBr9LWF5F37fLQ1AZqwPqhV2qi 7t6RJKwh8Da7g447R7ppyH83IjCJYG6fa3v490/yUvhROkTmEEjvdyf9cwrg37rWaG4x fZ6HqE0RPo/7E27mn6hMjXOgGG9Wc4X9PVAdUZ1kBsy3aaASQj5U8len2SqASSzPxRD7 ip2w== X-Gm-Message-State: ABuFfoiqTDK04LOl9hxgeRvudgWfaxIUVZVfBifywPwGejn5zjZvxs8F 3ciEE64hJdcy5p0MG78alE7Jnw== X-Received: by 2002:a17:906:5f8b:: with SMTP id a11-v6mr23444491eju.10.1539693464006; Tue, 16 Oct 2018 05:37:44 -0700 (PDT) Return-Path: Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id c11-v6sm2914534ejr.6.2018.10.16.05.37.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Oct 2018 05:37:43 -0700 (PDT) Sender: Daniel Vetter Date: Tue, 16 Oct 2018 14:37:41 +0200 From: Daniel Vetter To: Julia Lawall Cc: Mamta Shukla , outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, sean@poorly.run, airlied@linux.ie Subject: Re: [Outreachy kernel] [PATCH DRM] drm: Shift * to be adjacent to pointer name Message-ID: <20181016123741.GX31561@phenom.ffwll.local> References: <20181015212644.GA28579@armorer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.14.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) On Tue, Oct 16, 2018 at 12:30:16PM +0200, Julia Lawall wrote: > > > On Tue, 16 Oct 2018, Mamta Shukla wrote: > > > Shift * to be adjacent to pointer name to follow Linux coding style. > > Issue found with checkpatch.pl > > ERROR: "foo * bar" should be "foo *bar" > > The patch looks OK, but at this point, you know how to send a patch, so it > would be better to focus on changes that are more complex than whitespace > issues. Can't hurt to test-drive patch submission to a non-outreachy mailing list with something simple :-) Thanks for your patch, applied to drm-misc-next (for 4.21/5.1 most likely). -Daniel > > julia > > > > > > Signed-off-by: Mamta Shukla > > --- > > drivers/gpu/drm/drm_memory.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c > > index d69e4fc..40c4349 100644 > > --- a/drivers/gpu/drm/drm_memory.c > > +++ b/drivers/gpu/drm/drm_memory.c > > @@ -51,7 +51,7 @@ > > #endif > > > > static void *agp_remap(unsigned long offset, unsigned long size, > > - struct drm_device * dev) > > + struct drm_device *dev) > > { > > unsigned long i, num_pages = > > PAGE_ALIGN(size) / PAGE_SIZE; > > @@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size, > > } > > > > /** Wrapper around agp_free_memory() */ > > -void drm_free_agp(struct agp_memory * handle, int pages) > > +void drm_free_agp(struct agp_memory *handle, int pages) > > { > > agp_free_memory(handle); > > } > > > > /** Wrapper around agp_bind_memory() */ > > -int drm_bind_agp(struct agp_memory * handle, unsigned int start) > > +int drm_bind_agp(struct agp_memory *handle, unsigned int start) > > { > > return agp_bind_memory(handle, start); > > } > > > > /** Wrapper around agp_unbind_memory() */ > > -int drm_unbind_agp(struct agp_memory * handle) > > +int drm_unbind_agp(struct agp_memory *handle) > > { > > return agp_unbind_memory(handle); > > } > > > > #else /* CONFIG_AGP */ > > static inline void *agp_remap(unsigned long offset, unsigned long size, > > - struct drm_device * dev) > > + struct drm_device *dev) > > { > > return NULL; > > } > > -- > > 1.9.1 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015212644.GA28579%40armorer. > > For more options, visit https://groups.google.com/d/optout. > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Outreachy kernel] [PATCH DRM] drm: Shift * to be adjacent to pointer name Date: Tue, 16 Oct 2018 14:37:41 +0200 Message-ID: <20181016123741.GX31561@phenom.ffwll.local> References: <20181015212644.GA28579@armorer> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 820A66E207 for ; Tue, 16 Oct 2018 12:37:45 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id z21-v6so21127247edb.11 for ; Tue, 16 Oct 2018 05:37:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, outreachy-kernel@googlegroups.com, Mamta Shukla , daniel.vetter@ffwll.ch, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMTI6MzA6MTZQTSArMDIwMCwgSnVsaWEgTGF3YWxsIHdy b3RlOgo+IAo+IAo+IE9uIFR1ZSwgMTYgT2N0IDIwMTgsIE1hbXRhIFNodWtsYSB3cm90ZToKPiAK PiA+IFNoaWZ0ICogdG8gYmUgYWRqYWNlbnQgdG8gcG9pbnRlciBuYW1lIHRvIGZvbGxvdyBMaW51 eCBjb2Rpbmcgc3R5bGUuCj4gPiBJc3N1ZSBmb3VuZCB3aXRoIGNoZWNrcGF0Y2gucGwKPiA+IEVS Uk9SOiAiZm9vICogYmFyIiBzaG91bGQgYmUgImZvbyAqYmFyIgo+IAo+IFRoZSBwYXRjaCBsb29r cyBPSywgYnV0IGF0IHRoaXMgcG9pbnQsIHlvdSBrbm93IGhvdyB0byBzZW5kIGEgcGF0Y2gsIHNv IGl0Cj4gd291bGQgYmUgYmV0dGVyIHRvIGZvY3VzIG9uIGNoYW5nZXMgdGhhdCBhcmUgbW9yZSBj b21wbGV4IHRoYW4gd2hpdGVzcGFjZQo+IGlzc3Vlcy4KCkNhbid0IGh1cnQgdG8gdGVzdC1kcml2 ZSBwYXRjaCBzdWJtaXNzaW9uIHRvIGEgbm9uLW91dHJlYWNoeSBtYWlsaW5nIGxpc3QKd2l0aCBz b21ldGhpbmcgc2ltcGxlIDotKQoKVGhhbmtzIGZvciB5b3VyIHBhdGNoLCBhcHBsaWVkIHRvIGRy bS1taXNjLW5leHQgKGZvciA0LjIxLzUuMSBtb3N0Cmxpa2VseSkuCi1EYW5pZWwKCj4gCj4ganVs aWEKPiAKPiAKPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBNYW10YSBTaHVrbGEgPG1hbXRhc2h1a2xh NTU1QGdtYWlsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fbWVtb3J5LmMg fCAxMCArKysrKy0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBk ZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9tZW1v cnkuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWVtb3J5LmMKPiA+IGluZGV4IGQ2OWU0ZmMuLjQw YzQzNDkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21lbW9yeS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX21lbW9yeS5jCj4gPiBAQCAtNTEsNyArNTEsNyBAQAo+ ID4gICNlbmRpZgo+ID4KPiA+ICBzdGF0aWMgdm9pZCAqYWdwX3JlbWFwKHVuc2lnbmVkIGxvbmcg b2Zmc2V0LCB1bnNpZ25lZCBsb25nIHNpemUsCj4gPiAtCQkgICAgICAgc3RydWN0IGRybV9kZXZp Y2UgKiBkZXYpCj4gPiArCQkgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICB7Cj4g PiAgCXVuc2lnbmVkIGxvbmcgaSwgbnVtX3BhZ2VzID0KPiA+ICAJICAgIFBBR0VfQUxJR04oc2l6 ZSkgLyBQQUdFX1NJWkU7Cj4gPiBAQCAtOTQsMjYgKzk0LDI2IEBAIHN0YXRpYyB2b2lkICphZ3Bf cmVtYXAodW5zaWduZWQgbG9uZyBvZmZzZXQsIHVuc2lnbmVkIGxvbmcgc2l6ZSwKPiA+ICB9Cj4g Pgo+ID4gIC8qKiBXcmFwcGVyIGFyb3VuZCBhZ3BfZnJlZV9tZW1vcnkoKSAqLwo+ID4gLXZvaWQg ZHJtX2ZyZWVfYWdwKHN0cnVjdCBhZ3BfbWVtb3J5ICogaGFuZGxlLCBpbnQgcGFnZXMpCj4gPiAr dm9pZCBkcm1fZnJlZV9hZ3Aoc3RydWN0IGFncF9tZW1vcnkgKmhhbmRsZSwgaW50IHBhZ2VzKQo+ ID4gIHsKPiA+ICAJYWdwX2ZyZWVfbWVtb3J5KGhhbmRsZSk7Cj4gPiAgfQo+ID4KPiA+ICAvKiog V3JhcHBlciBhcm91bmQgYWdwX2JpbmRfbWVtb3J5KCkgKi8KPiA+IC1pbnQgZHJtX2JpbmRfYWdw KHN0cnVjdCBhZ3BfbWVtb3J5ICogaGFuZGxlLCB1bnNpZ25lZCBpbnQgc3RhcnQpCj4gPiAraW50 IGRybV9iaW5kX2FncChzdHJ1Y3QgYWdwX21lbW9yeSAqaGFuZGxlLCB1bnNpZ25lZCBpbnQgc3Rh cnQpCj4gPiAgewo+ID4gIAlyZXR1cm4gYWdwX2JpbmRfbWVtb3J5KGhhbmRsZSwgc3RhcnQpOwo+ ID4gIH0KPiA+Cj4gPiAgLyoqIFdyYXBwZXIgYXJvdW5kIGFncF91bmJpbmRfbWVtb3J5KCkgKi8K PiA+IC1pbnQgZHJtX3VuYmluZF9hZ3Aoc3RydWN0IGFncF9tZW1vcnkgKiBoYW5kbGUpCj4gPiAr aW50IGRybV91bmJpbmRfYWdwKHN0cnVjdCBhZ3BfbWVtb3J5ICpoYW5kbGUpCj4gPiAgewo+ID4g IAlyZXR1cm4gYWdwX3VuYmluZF9tZW1vcnkoaGFuZGxlKTsKPiA+ICB9Cj4gPgo+ID4gICNlbHNl IC8qICBDT05GSUdfQUdQICAqLwo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCAqYWdwX3JlbWFwKHVu c2lnbmVkIGxvbmcgb2Zmc2V0LCB1bnNpZ25lZCBsb25nIHNpemUsCj4gPiAtCQkJICAgICAgc3Ry dWN0IGRybV9kZXZpY2UgKiBkZXYpCj4gPiArCQkJICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiA+ICB7Cj4gPiAgCXJldHVybiBOVUxMOwo+ID4gIH0KPiA+IC0tCj4gPiAxLjkuMQo+ID4K PiA+IC0tCj4gPiBZb3UgcmVjZWl2ZWQgdGhpcyBtZXNzYWdlIGJlY2F1c2UgeW91IGFyZSBzdWJz Y3JpYmVkIHRvIHRoZSBHb29nbGUgR3JvdXBzICJvdXRyZWFjaHkta2VybmVsIiBncm91cC4KPiA+ IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBncm91cCBhbmQgc3RvcCByZWNlaXZpbmcgZW1haWxz IGZyb20gaXQsIHNlbmQgYW4gZW1haWwgdG8gb3V0cmVhY2h5LWtlcm5lbCt1bnN1YnNjcmliZUBn b29nbGVncm91cHMuY29tLgo+ID4gVG8gcG9zdCB0byB0aGlzIGdyb3VwLCBzZW5kIGVtYWlsIHRv IG91dHJlYWNoeS1rZXJuZWxAZ29vZ2xlZ3JvdXBzLmNvbS4KPiA+IFRvIHZpZXcgdGhpcyBkaXNj dXNzaW9uIG9uIHRoZSB3ZWIgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9kL21zZ2lk L291dHJlYWNoeS1rZXJuZWwvMjAxODEwMTUyMTI2NDQuR0EyODU3OSU0MGFybW9yZXIuCj4gPiBG b3IgbW9yZSBvcHRpb25zLCB2aXNpdCBodHRwczovL2dyb3Vwcy5nb29nbGUuY29tL2Qvb3B0b3V0 Lgo+ID4KCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK