From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder Date: Tue, 16 Oct 2018 14:47:45 +0200 Message-ID: <20181016124745.GA7733@kroah.com> References: <20181004143750.30880-1-jani.nikula@intel.com> <20181016104845.GB4768@kroah.com> <87pnwakto2.fsf@intel.com> <20181016114347.GA21790@kroah.com> <87k1miks7j.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11CE26E20C for ; Tue, 16 Oct 2018 12:47:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87k1miks7j.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDM6MTA6MjRQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAxNiBPY3QgMjAxOCwgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGlu dXhmb3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiBPbiBUdWUsIE9jdCAxNiwgMjAxOCBhdCAwMjoz ODo1M1BNICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+PiBPbiBUdWUsIDE2IE9jdCAyMDE4 LCBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPiB3cm90ZToK PiA+PiA+IE9uIFRodSwgT2N0IDA0LCAyMDE4IGF0IDA1OjM3OjQ5UE0gKzAzMDAsIEphbmkgTmlr dWxhIHdyb3RlOgo+ID4+ID4+IExldCB0aGUgcGFzc2VkIGluIGFycmF5IGJlIGNvbnN0IChhbmQg dGh1cyBwbGFjZWQgaW4gcm9kYXRhKSBpbnN0ZWFkIG9mCj4gPj4gPj4gYSBtdXRhYmxlIGFycmF5 IG9mIGNvbnN0IHBvaW50ZXJzLgo+ID4+ID4+IAo+ID4+ID4+IENjOiBHcmVnIEtyb2FoLUhhcnRt YW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgo+ID4+ID4+IENjOiAiUmFmYWVsIEouIFd5 c29ja2kiIDxyYWZhZWxAa2VybmVsLm9yZz4KPiA+PiA+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5p a3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ID4+ID4+IC0tLQo+ID4+ID4+ICBmcy9zeXNm cy9maWxlLmMgICAgICAgfCA0ICsrLS0KPiA+PiA+PiAgaW5jbHVkZS9saW51eC9zeXNmcy5oIHwg OCArKysrLS0tLQo+ID4+ID4+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNiBk ZWxldGlvbnMoLSkKPiA+PiA+Cj4gPj4gPiBSZXZpZXdlZC1ieTogR3JlZyBLcm9haC1IYXJ0bWFu IDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiA+PiAKPiA+PiBUaGFua3M7IHdobyBzaG91 bGQgcGljayB0aGVtIHVwPwo+ID4KPiA+IEkgY291bGQgcGljayB0aGUgZmlyc3Qgb25lIHVwLCBi dXQgYXMgeW91IG5lZWQgdGhpcyBmb3IgYSBkcm0gcGF0Y2gsCj4gPiBib3RoIHNob3VsZCBwcm9i YWJseSBnbyB0aHJvdWdoIHRoYXQgdHJlZSwgcmlnaHQ/Cj4gCj4gSSBjYW4gcGljayB0aGVtIGJv dGggaWYgaXQgZG9lc24ndCBib3RoZXIgeW91IHRoYXQgdGhlIHN5c2ZzIHBhcnRzIHdpbGwKPiBi ZSBtZXJnZWQgaW4gdGhlIG1lcmdlIHdpbmRvdyBmb3IgdjQuMjEgaS5lLiB0aGUgY2hhbmdlIHdv dWxkIGJlIGluIGRybQo+IHRyZWVzIGZvciBhbiBlbnRpcmUgcmVsZWFzZSBjeWNsZS4gV2UndmUg YmVlbiBkb25lIGZvciB2NC4yMCBtZXJnZQo+IHdpbmRvdyBmb3IgYSB3aGlsZSBub3cuCgpObyBv YmplY3Rpb24gZnJvbSBtZS4KCmdyZWcgay1oCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B07C04EBD for ; Tue, 16 Oct 2018 12:47:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C057B20869 for ; Tue, 16 Oct 2018 12:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nwv1ti2S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C057B20869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbeJPUiH (ORCPT ); Tue, 16 Oct 2018 16:38:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:42614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726718AbeJPUiH (ORCPT ); Tue, 16 Oct 2018 16:38:07 -0400 Received: from localhost (ip-213-127-77-176.ip.prioritytelecom.net [213.127.77.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B6FD20869; Tue, 16 Oct 2018 12:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539694067; bh=bLz0sZD4d5SnIPRTuRRvhmsYA1bEdDr14t8NtgrZEiE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nwv1ti2S4Gn9754DBq9qzFY5DgiwC/mnS1uVH9uaLoooiuGAIp8bH3ABud/kBSTZX C/wi5OYnTjmFnd1RkFbaKkXGNiNpfUAhwTv/TCM5+RoBUfX6hjaziCDbx6ZzO5Og+K au1vl/BO/m6LKOD/Yw8eazoUACAWQgvPDGdREjuo= Date: Tue, 16 Oct 2018 14:47:45 +0200 From: Greg Kroah-Hartman To: Jani Nikula Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "Rafael J. Wysocki" Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder Message-ID: <20181016124745.GA7733@kroah.com> References: <20181004143750.30880-1-jani.nikula@intel.com> <20181016104845.GB4768@kroah.com> <87pnwakto2.fsf@intel.com> <20181016114347.GA21790@kroah.com> <87k1miks7j.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k1miks7j.fsf@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 16, 2018 at 03:10:24PM +0300, Jani Nikula wrote: > On Tue, 16 Oct 2018, Greg Kroah-Hartman wrote: > > On Tue, Oct 16, 2018 at 02:38:53PM +0300, Jani Nikula wrote: > >> On Tue, 16 Oct 2018, Greg Kroah-Hartman wrote: > >> > On Thu, Oct 04, 2018 at 05:37:49PM +0300, Jani Nikula wrote: > >> >> Let the passed in array be const (and thus placed in rodata) instead of > >> >> a mutable array of const pointers. > >> >> > >> >> Cc: Greg Kroah-Hartman > >> >> Cc: "Rafael J. Wysocki" > >> >> Signed-off-by: Jani Nikula > >> >> --- > >> >> fs/sysfs/file.c | 4 ++-- > >> >> include/linux/sysfs.h | 8 ++++---- > >> >> 2 files changed, 6 insertions(+), 6 deletions(-) > >> > > >> > Reviewed-by: Greg Kroah-Hartman > >> > >> Thanks; who should pick them up? > > > > I could pick the first one up, but as you need this for a drm patch, > > both should probably go through that tree, right? > > I can pick them both if it doesn't bother you that the sysfs parts will > be merged in the merge window for v4.21 i.e. the change would be in drm > trees for an entire release cycle. We've been done for v4.20 merge > window for a while now. No objection from me. greg k-h