From: Greg KH <gregkh@linuxfoundation.org>
To: Roman Gushchin <guro@fb.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"mhocko@suse.com" <mhocko@suse.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: FAILED: patch "[PATCH] mm: treat indirectly reclaimable memory as free in overcommit" failed to apply to 4.16-stable tree
Date: Tue, 16 Oct 2018 16:01:12 +0200 [thread overview]
Message-ID: <20181016140112.GE20256@kroah.com> (raw)
In-Reply-To: <20181011210409.GA4320@tower.DHCP.thefacebook.com>
On Thu, Oct 11, 2018 at 09:04:17PM +0000, Roman Gushchin wrote:
> On Thu, Oct 11, 2018 at 04:27:46PM +0200, Greg KH wrote:
> > On Mon, May 14, 2018 at 11:46:00AM +0100, Roman Gushchin wrote:
> > > On Sat, May 12, 2018 at 03:35:59PM +0200, gregkh@linuxfoundation.org wrote:
> > > >
> > > > The patch below does not apply to the 4.16-stable tree.
> > > > If someone wants it applied there, or to any other stable or longterm
> > > > tree, then please email the backport, including the original git commit
> > > > id to <stable@vger.kernel.org>.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Hi, Greg!
> > >
> > > This patch is a part of the following patchset:
> > > 7aaf77272358 mm: don't show nr_indirectly_reclaimable in /proc/vmstat
> > > d79f7aa496fc mm: treat indirectly reclaimable memory as free in overcommit logic
> > > f1782c9bc547 dcache: account external names as indirectly reclaimable memory
> > > 034ebf65c3c2 mm: treat indirectly reclaimable memory as available in MemAvailable
> > > eb59254608bc mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES
> > >
> > > It should be backported as a whole. It applies cleanly on 4.16-stable,
> > > and with a minor trivial adjustment to 4.14-stable.
> >
> > Sorry for the long delay, digging out of my stable backlog...
> >
> > Anyway, is this still needed for 4.14-stable?
>
> There is a security issue, which these patches are closing. It allows to cause
> a system-wide memory allocation failure, if overcommit logic is enabled and
> it's possible to create negative dentries (e.g. asking httpd for non-existing
> files). The issue is very old and exists in most stable branches, so Idk how
> bad is to leave it open in 4.14.
> Anyway, please, let me know if I can help somehow.
Ok, all now queued up, let's see how it goes :)
thanks,
greg k-h
prev parent reply other threads:[~2018-10-16 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 13:35 FAILED: patch "[PATCH] mm: treat indirectly reclaimable memory as free in overcommit" failed to apply to 4.16-stable tree gregkh
2018-05-14 10:46 ` Roman Gushchin
2018-10-11 14:27 ` Greg KH
2018-10-11 21:04 ` Roman Gushchin
2018-10-16 14:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016140112.GE20256@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=mhocko@suse.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.