From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Tue, 16 Oct 2018 20:39:49 +0300 Message-ID: <20181016173949.GI9144@intel.com> References: <20181016094045.23021-1-boris.brezillon@bootlin.com> <20181016125743.GZ31561@phenom.ffwll.local> <20181016151045.76944938@bbrezillon> <20181016132809.GF9144@intel.com> <20181016164151.GB31561@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id A424C89D6C for ; Tue, 16 Oct 2018 17:39:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181016164151.GB31561@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Boris Brezillon , gordon@raspberrypi.org, dri-devel , eben@raspberrypi.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDY6NDE6NTFQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIE9jdCAxNiwgMjAxOCBhdCAwNDoyODowOVBNICswMzAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUdWUsIE9jdCAxNiwgMjAxOCBhdCAwMzoxMjo1NFBNICsw MjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIE9jdCAxNiwgMjAxOCBhdCAz OjEwIFBNIEJvcmlzIEJyZXppbGxvbgo+ID4gPiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29t PiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IEhpIERhbmllbCwKPiA+ID4gPgo+ID4gPiA+IE9uIFR1 ZSwgMTYgT2N0IDIwMTggMTQ6NTc6NDMgKzAyMDAKPiA+ID4gPiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gPiBPbiBUdWUsIE9jdCAxNiwgMjAx OCBhdCAxMTo0MDo0NUFNICswMjAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gPiA+ID4gPiA+ IFRoZSBIVlMgYmxvY2sgaXMgc3VwcG9zZWQgdG8gZmlsbCB0aGUgcGl4ZWx2YWx2ZSBGSUZPcyBm YXN0IGVub3VnaCB0bwo+ID4gPiA+ID4gPiBtZWV0IHRoZSByZXF1ZXN0ZWQgZnJhbWVyYXRlLiBU aGUgcHJvYmxlbSBpcywgdGhlIEhWUyBhbmQgbWVtb3J5IGJ1cwo+ID4gPiA+ID4gPiBiYW5kd2lk dGhzIGFyZSBsaW1pdGVkLCBhbmQgaWYgd2UgZG9uJ3QgdGFrZSB0aGVzZSBsaW1pdGF0aW9ucyBp bnRvCj4gPiA+ID4gPiA+IGFjY291bnQgd2UgbWlnaHQgZW5kIHVwIHdpdGggSFZTIHVuZGVyZmxv dyBlcnJvcnMuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoaXMgcGF0Y2ggaXMgdHJ5aW5nIHRv IG1vZGVsIHRoZSBwZXItcGxhbmUgSFZTIGFuZCBtZW1vcnkgYnVzIGJhbmR3aWR0aAo+ID4gPiA+ ID4gPiBjb25zdW1wdGlvbiBhbmQgdGFrZSBhIGRlY2lzaW9uIGF0IGF0b21pY19jaGVjaygpIHRp bWUgd2hldGhlciB0aGUKPiA+ID4gPiA+ID4gZXN0aW1hdGVkIGxvYWQgd2lsbCBmaXQgaW4gdGhl IEhWUyBhbmQgbWVtYnVzIGJ1ZGdldC4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gTm90ZSB0aGF0 IHdlIHRha2UgYW4gZXh0cmEgbWFyZ2luIG9uIHRoZSBtZW1vcnkgYnVzIGNvbnN1bXB0aW9uIHRv IGxldAo+ID4gPiA+ID4gPiB0aGUgc3lzdGVtIHJ1biBzbW9vdGhseSB3aGVuIG90aGVyIGJsb2Nr cyBhcmUgZG9pbmcgaGVhdnkgdXNlIG9mIHRoZQo+ID4gPiA+ID4gPiBtZW1vcnkgYnVzLiBTYW1l IGdvZXMgZm9yIHRoZSBIVlMgbGltaXQsIGV4Y2VwdCB0aGUgbWFyZ2luIGlzIHNtYWxsZXIgaW4K PiA+ID4gPiA+ID4gdGhpcyBjYXNlLCBzaW5jZSB0aGUgSFZTIGlzIG5vdCB1c2VkIGJ5IGV4dGVy bmFsIGNvbXBvbmVudHMuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJv cmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gPiA+ID4gPiAt LS0KPiA+ID4gPiA+ID4gVGhpcyBsb2dpYyBoYXMgYmVlbiB2YWxpZGF0ZWQgdXNpbmcgYSBzaW1w bGUgc2hlbGwgc2NyaXB0IGFuZAo+ID4gPiA+ID4gPiBzb21lIGluc3RydW1lbnRhdGlvbiBpbiB0 aGUgVkM0IGRyaXZlcjoKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gLSBjYXB0dXJlIHVuZGVyZmxv dyBlcnJvcnMgYXQgdGhlIEhWUyBsZXZlbCBhbmQgZXhwb3NlIGEgZGVidWdmcyBmaWxlCj4gPiA+ ID4gPiA+ICAgcmVwb3J0aW5nIHRob3NlIGVycm9ycwo+ID4gPiA+ID4gPiAtIGFkZCBkZWJ1Z2Zz IGZpbGVzIHRvIGV4cG9zZSB3aGVuIGF0b21pY19jaGVjayBmYWlscyBiZWNhdXNlIG9mIHRoZQo+ ID4gPiA+ID4gPiAgIEhWUyBvciBtZW1idXMgbG9hZCBsaW1pdGF0aW9uIG9yIHdoZW4gaXQgZmFp bHMgZm9yIG90aGVyIHJlYXNvbnMKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gVGhlIGJyYW5jaCBj b250YWluaW5nIHRob3NlIG1vZGlmaWNhdGlvbiBpcyBhdmFpbGFibGUgaGVyZSBbMV0sIGFuZCB0 aGUKPiA+ID4gPiA+ID4gc2NyaXB0ICh3aGljaCBpcyBpbnRlcm5hbGx5IHVzaW5nIG1vZGV0ZXN0 KSBpcyBoZXJlIFsyXSAocGxlYXNlIG5vdGUKPiA+ID4gPiA+ID4gdGhhdCBJJ20gYmFkIGF0IHdy aXRpbmcgc2hlbGwgc2NyaXB0cyA6LSkpLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBOb3RlIHRo YXQgdGhvc2UgbW9kaWZpY2F0aW9uIHRlbmQgdG8gb3Zlci1lc3RpbWF0ZSB0aGUgbG9hZCwgYW5k IHRodXMKPiA+ID4gPiA+ID4gcmVqZWN0IHNldHVwcyB0aGF0IG1pZ2h0IGhhdmUgcHJldmlvdXNs eSB3b3JrZWQsIHNvIHdlIG1pZ2h0IHdhbnQgdG8KPiA+ID4gPiA+ID4gYWRqdXN0IHRoZSBsaW1p dHMgdG8gYXZvaWQgdGhhdC4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gWzFdaHR0cHM6Ly9naXRo dWIuY29tL2JicmV6aWxsb24vbGludXgvdHJlZS92YzQvaHZzLWJhbmR3aWR0aC1ldmFsCj4gPiA+ ID4gPiA+IFsyXWh0dHBzOi8vZ2l0aHViLmNvbS9iYnJlemlsbG9uL3ZjNC1odnMtYmFuZHdpZHRo LXRlc3QKPiA+ID4gPiA+Cj4gPiA+ID4gPiBBbnkgaW50ZXJlc3QgaW4gdXNpbmcgaWd0IHRvIHRl c3QgdGhpcyBzdHVmZj8gV2UgaGF2ZSBhdCBsZWFzdCBhIGJ1bmNoIG9mCj4gPiA+ID4gPiB0ZXN0 cyBhbHJlYWR5IGluIHRoZXJlIHRoYXQgdHJ5IGFsbCBraW5kcyBvZiBwbGFuZSBzZXR1cHMuIEFu ZCB3ZSB1c2UKPiA+ID4gPiA+IHRob3NlIHRvIGh1bnQgZm9yIHVuZGVycnVucyBvbiBpOTE1IGh3 Lgo+ID4gPiA+ID4KPiA+ID4gPiA+IFdydCB1bmRlcnJ1biByZXBvcnRpbmc6IE9uIGk5MTUgd2Ug anVzdCBkdW1wIHRoZW0gaW50byBkbWVzZyBhdCB0aGUgZXJyb3IKPiA+ID4gPiA+IGxldmVsLCB1 c2luZyBEUk1fRVJST1IsIHBsdXMgYSB0cmFjZXBvaW50LiBTZWUgZS5nLgo+ID4gPiA+ID4gaW50 ZWxfcGNoX2ZpZm9fdW5kZXJydW5faXJxX2hhbmRsZXIoKS4gSWYgdGhlcmUncyBpbnRlcmVzdCB3 ZSBjb3VsZAo+ID4gPiA+ID4gcGVyaGFwcyBleHRyYWN0IHRoaXMgaW50byBzb21ldGhpbmcgY29t bW9uLCBzaW1pbGFyIHRvIHdoYXQgd2FzIGRvbmUgd2l0aAo+ID4gPiA+ID4gY3JjIHN1cHBvcnQg YWxyZWFkeS4KPiA+ID4gPgo+ID4gPiA+IFNvdW5kcyBsaWtlIGEgZ29vZCBpZGVhLiBJJ2xsIGhh dmUgYSBsb29rIGF0IHdoYXQncyBkb25lIGluIHRoZSBpbnRlbAo+ID4gPiA+IGRyaXZlciBhbmQg d2lsbCBjaGVjayBob3cgZmVhc2libGUgdGhpcyBpcyB0byBoYXZlIGEgY29tbW9uCj4gPiA+ID4g aW5mcmFzdHJ1Y3R1cmUgdG8gdGVzdCB0aGF0IGluIGlndC4KPiA+ID4gPgo+ID4gPiA+IFRoYW5r cyBmb3IgdGhlIHBvaW50ZXJzLgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiA+ID4gK3N0YXRpYyBp bnQgdmM0X2xvYWRfdHJhY2tlcl9hdG9taWNfY2hlY2soc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ID4gPiA+ID4gPiArewo+ID4gPiA+ID4gPiArICAgc3RydWN0IGRybV9wbGFuZV9z dGF0ZSAqb2xkX3BsYW5lX3N0YXRlLCAqbmV3X3BsYW5lX3N0YXRlOwo+ID4gPiA+ID4gPiArICAg c3RydWN0IHZjNF9kZXYgKnZjNCA9IHRvX3ZjNF9kZXYoc3RhdGUtPmRldik7Cj4gPiA+ID4gPiA+ ICsgICBzdHJ1Y3QgdmM0X2xvYWRfdHJhY2tlcl9zdGF0ZSAqbG9hZF9zdGF0ZTsKPiA+ID4gPiA+ ID4gKyAgIHN0cnVjdCBkcm1fcHJpdmF0ZV9zdGF0ZSAqcHJpdl9zdGF0ZTsKPiA+ID4gPiA+ID4g KyAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ID4gPiA+ID4gPiArICAgaW50IHJldCwgaTsK PiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4KPiA+ID4gPiA+IFlvdSdyZSBtaXNzaW5nIHRoZSBtb2Rl c2V0IGxvY2tpbmcgZm9yIHZjNC0+bG9hZF90cmFja2VyLiBTZWUgdGhlCj4gPiA+ID4gPiBrZXJu ZWxkb2MgZm9yIGRybV9hdG9taWNfZ2V0X3ByaXZhdGVfb2JqX3N0YXRlKCkuCj4gPiA+ID4KPiA+ ID4gPiBIbSwgSSBtaXNzZWQgdGhpcyBwYXJ0IG9mIHRoZSBkb2MsIGFuZCBJIHRob3VnaHQgd2Ug d2VyZSBwcm90ZWN0ZWQgYnkKPiA+ID4gPiB0aGUgbW9kZXNldCBsb2NrLgo+ID4gPiA+Cj4gPiA+ ID4gPiBQcm9iYWJseSBhIGdvb2QgdGltZSB0bwo+ID4gPiA+ID4gaW1wbGVtZW50IHRoZSBsb2Nr aW5nIHJlZmFjdG9yaW5nIGlkZWEgSSBoYXZlIGFuZCBqdXN0IGltcGxlbWVudCBhIHBlcgo+ID4g PiA+ID4gcHJpdmF0ZV9vYmogbG9jaywgYW5kIHJlbW92ZSBhbGwgdGhlIGFkLWhvYyBsb2NraW5n IGZyb20gYWxsIHRoZSBjYWxsZXJzPwo+ID4gPiA+Cj4gPiA+ID4gTGV0IG1lIHNlZSBpZiBJIGdl dCBpdCBjb3JyZWN0bHkuIFlvdSB3YW50IHRvIGFkZCBhIGxvY2sgdG8gdGhlCj4gPiA+ID4gZHJt X3ByaXZhdGVfb2JqIHN0cnVjdCwgcmlnaHQ/Cj4gPiA+IAo+ID4gPiBZdXAsIHBsdXMgYXV0b21h dGljYWxseSBncmFiIHRoYXQgbG9jayBpbiBnZXRfcHJpdmF0ZV9vYmpfc3RhdGUsIGFuZAo+ID4g PiB0aGVuIGRyb3AgdGhlIG5vdyBzdXBlcmZsdW91cyBsb2NraW5nIGZyb20gYWxsIHRoZSBjYWxs ZXJzLgo+ID4gCj4gPiBZb3UgbWVhbiB0aGlzPwo+ID4gaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRl c2t0b3Aub3JnL3BhdGNoLzIwNTk0My8KPiAKPiBZdXAsIHRoYXQgb25lIGV4YWN0bHkuIE5vIGlk ZWEgd2h5IGl0IGRpZWQgaW4gYSBiaWtlc2hlZCwgZXhjZXB0IG1heWJlIHdlCj4gc2hvdWxkIHB1 dCBhbGwgdGhlIHByaXZhdGUgb2JqIG9uIGEgbGlzdCBhbmQgYWRkIHNvbWUgY29kZSB0bwo+IGxv Y2tfYWxsX2N0eCgpIHRvIGFsc28gbG9jayB0aG9zZS4KClllYWgsIEkgd2FzIGFsc28gdGhpbmtp bmcgYWxvbmcgdGhvc2UgbGluZXMgYSB3aGlsZSBhZ28gd2hlbiBsb29raW5nCmF0IHNvbWUgZnVu Y3Rpb24gdGhhdCBpdGVyYXRlcyBhbGwgdGhlIG90aGVyIG9iamVjdHMgYWxyZWFkeS4gQ2FuJ3QK cmVjYWxsIHdoYXQgZnVuY3Rpb24gdGhhdCB3YXMgdGhvdWdoIDooCgpXcnQuIHRoZSBwZXItcHJp dmF0ZSBvYmogbG9ja3MsIHdlIHN0aWxsIGRvbid0IHVzZSB0aGF0IGZvciBpOTE1IGNkY2xrCmV0 Yy4gc28gSSBjYW4ndCBpbiBnb29kIGNvbmNpZW5zZSBuYWsgaXQuIElmIGl0J3MgdXNlZnVsIGZv ciBvdGhlcgpkcml2ZXJzIHRoZW4gaXQgc2hvdWxkIGdvIGluLiBBbmQgd2UnbGwganVzdCBoYXZl IHRvIHRoaW5rIG9mIHNvbWUKb3RoZXIgd2F5IHRvIGhhbmRsZSB0aGUgaTkxNSBjYXNlIHNob3Vs ZCB3ZSBldmVyIGRlY2lkZSB0byBjb252ZXJ0Cml0IG92ZXIuCgotLSAKVmlsbGUgU3lyasOkbMOk CkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=