From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: uwe@kleine-koenig.org, gregkh@linuxfoundation.org,
corbet@lwn.net, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, Michal.Vokac@ysoft.com,
akpm@linux-foundation.org, kernel@pengutronix.de
Subject: Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true
Date: Tue, 16 Oct 2018 19:06:51 +0100 [thread overview]
Message-ID: <20181016180650.GZ32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181015093708.GA22876@mail.gnudd.com>
On Mon, Oct 15, 2018 at 11:37:08AM +0200, Alessandro Rubini wrote:
> OTOH I admit you can compare any value with -EINVAL, after PTR_ERR.
> But in general you first detect the error condition and then split
> among error (or print a message according to the exact value.
if (IS_ERR(p) && PTR_ERR(p) == -ENOENT)
instead of
if (p == ERR_PTR(-ENOENT))
is ugly, obfuscating what's going on for no good reason and I'm going
to keep killing those every time I run into one...
next prev parent reply other threads:[~2018-10-16 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 20:28 [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true Uwe Kleine-König
2018-10-15 9:37 ` Alessandro Rubini
2018-10-15 9:46 ` Uwe Kleine-König
2018-10-16 18:06 ` Al Viro [this message]
2018-10-16 19:29 ` Uwe Kleine-König
2018-10-16 20:10 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016180650.GZ32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Michal.Vokac@ysoft.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
--cc=thierry.reding@gmail.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.