From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Use
 i915_gem_object_get_dma_address() to populate rotated vmas
Date: Tue, 16 Oct 2018 21:18:34 +0300
Message-ID: <20181016181834.GK9144@intel.com>
References: <20181016150413.11577-1-ville.syrjala@linux.intel.com>
 <1038c59f-a630-6301-3f4d-bd81b188281d@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 8E9E16E277
 for <intel-gfx@lists.freedesktop.org>; Tue, 16 Oct 2018 18:18:37 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1038c59f-a630-6301-3f4d-bd81b188281d@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDY6NTQ6NTlQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g
d3JvdGU6Cj4gCj4gT24gMTYvMTAvMjAxOCAxNjowNCwgVmlsbGUgU3lyamFsYSB3cm90ZToKPiA+
IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g
PiAKPiA+IFJlcGxhY2UgdGhlIGt2bWFsbG9jX2FycmF5KCkgd2l0aCBpOTE1X2dlbV9vYmplY3Rf
Z2V0X2RtYV9hZGRyZXNzKCkgd2hlbgo+ID4gcG9wdWxhdGluZyByb3RhdGVkIHZtYXMuIE9uZSBy
YW5kb20gYWNjZXNzIG1lY2hhbmlzbSBvdWdodCB0byBiZSBlbm91Z2gKPiA+IGZvciBldmVyeW9u
ZT8KPiA+IAo+ID4gVG8gY2FsY3VsYXRlIHRoZSBzaXplIG9mIHRoZSByYWRpeCB0cmVlIEkgdGhp
bmsgd2UgY2FuIGRvCj4gPiBzb21ldGhpbmcgbGlrZSB0aGlzIChhc3N1bWluZyA2NGJpdCBwb2lu
dGVycyk6Cj4gPiAgIG51bV9wYWdlcyA9IG9ial9zaXplIC8gNDA5Ngo+ID4gICB0cmVlX2hlaWdo
dCA9IGNlaWwobG9nNjQobnVtX3BhZ2VzKSkKPiA+ICAgbnVtX25vZGVzID0gc3VtKDY0Xm4sIG4s
IDAsIHRyZWVfaGVpZ2h0LTEpCj4gPiAgIHRyZWVfc2l6ZSA9IG51bV9ub2RlcyAqIDU3Ngo+IAo+
IEZvciAxOTIweDEwODB4NCBJIGdldCBhcm91bmQgMTlrIGluIHJlYWwgbGlmZSAtIGRvZXMgdGhh
dCBtYXRjaCB5b3VyIAo+IG1hdGg/CgpUaGUgbWF0aCBhc3N1bWVzIHRoZSBzZWNvbmQgbGV2ZWwg
b2YgdHJlZSBpcyBmdWxseSBwb3B1bGF0ZWQgc28KZ2l2ZXMgbWUgfjM3S2lCLiBJbiB0aGlzIGNh
c2Ugd2UgaGF2ZSBvbmx5IDIwMjUgcGFnZXMgc28gd2Ugc2hvdWxkCm9ubHkgbmVlZCAzMyBub2Rl
cyBpbiB0b3RhbCBpbnN0ZWFkIG9mIHRoZSBmdWxsIDY1LiAzMyo1NzYgaXMgfjE5S2lCLgoKPiBG
b3Igc29tZXRoaW5nIGxpa2UgdHdvIFVIRCBzY3JlZW5zIHdpdGggZG91YmxlIGJ1ZmZlcmluZyBJ
IGd1ZXNzIAo+IHRoYXQncyBhcm91bmQgNCAqIDIgKiAyID0gMTYgdGltZXMgbW9yZSwgd2hpY2gg
aXMgcGVyaGFwcyBhIHdvcnN0IGNhc2UgCj4gc2V0dXA/IFNvIH4zMDBLaUIgcGVybWFuZW50bHkg
cGlubmVkIGFuZCBsaWtlbHkgbm90IHVzZWQgcG9zdCBmaXJzdCBwaW4gCj4gdG8gZGlzcGxheS4g
SWYgdGhhdCBpcyBPSyB3aXRoIHlvdSB0aGVuIHlvdSBoYXZlIG15IGFjayBmb3IgdGhlIHBhdGNo
LiAKCkkgdGhpbmsgSSdtIE9LIHdpdGggaXQuIEFuZCBDaHJpcyBjYW4gb3B0aW1pemUgaXQgbGF0
ZXIgOykKCklmIHdlJ3JlIHJlYWxseSBzaG9ydCBvbiBtZW1vcnkgdGhlIHNocmlua2VyIHNob3Vs
ZCBiZSBhYmxlIHRvIGdldApyaWQgb2YgdGhpcyB3aGVuIGl0J3MgZ29pbmcgdG8gc3dhcCBvdXQg
dGhlIHBhZ2VzLiBGb3IgYW55IGZiIHRoYXQncwpub3QgY3VycmVudGx5IHBpbm5lZCB0aGF0IGlz
LgoKPiBPciBhIHJldmlldyBpZiB5b3UgY2FuIGxpdmUgd2l0aCBzb21lIGRlbGF5Lgo+IAo+IFJl
Z2FyZHMsCj4gCj4gVHZydGtvCj4gCj4gPiBJZiB3ZSBjb21wYXJlIHRoYXQgd2l0aCB0aGUgb2Jq
ZWN0IHNpemUgd2Ugc2hvdWxkIGdldCBhIHJlbGF0aXZlCj4gPiBvdmVyaGVhZCBvZiBhcm91bmQg
LjIlIHRvIDElIGZvciByZWFzb25hYmxlIHNpemVkIG9iamVjdHMsCj4gPiB3aGljaCBmcmFtZWJ1
ZmZlcnMgdGVuZCB0byBiZS4KPiA+IAo+ID4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt
d2lsc29uLmNvLnVrPgo+ID4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51
eC5pbnRlbC5jb20+Cj4gPiBTdWdnZXN0ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt
d2lsc29uLmNvLnVrPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z
eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2dlbV9ndHQuYyB8IDMxICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAg
IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+ID4gCj4g
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ID4gaW5kZXggMjljYTkwMDdhNzA0Li45
OGQ5YTFlYjFlZDIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl
bV9ndHQuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiA+
IEBAIC0zNjM3LDcgKzM2MzcsNyBAQCB2b2lkIGk5MTVfZ2VtX3Jlc3RvcmVfZ3R0X21hcHBpbmdz
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAgfQo+ID4gICAKPiA+ICAg
c3RhdGljIHN0cnVjdCBzY2F0dGVybGlzdCAqCj4gPiAtcm90YXRlX3BhZ2VzKGNvbnN0IGRtYV9h
ZGRyX3QgKmluLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LAo+ID4gK3JvdGF0ZV9wYWdlcyhzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LAo+ID4gICAJICAg
ICB1bnNpZ25lZCBpbnQgd2lkdGgsIHVuc2lnbmVkIGludCBoZWlnaHQsCj4gPiAgIAkgICAgIHVu
c2lnbmVkIGludCBzdHJpZGUsCj4gPiAgIAkgICAgIHN0cnVjdCBzZ190YWJsZSAqc3QsIHN0cnVj
dCBzY2F0dGVybGlzdCAqc2cpCj4gPiBAQCAtMzY0Niw3ICszNjQ2LDcgQEAgcm90YXRlX3BhZ2Vz
KGNvbnN0IGRtYV9hZGRyX3QgKmluLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LAo+ID4gICAJdW5zaWdu
ZWQgaW50IHNyY19pZHg7Cj4gPiAgIAo+ID4gICAJZm9yIChjb2x1bW4gPSAwOyBjb2x1bW4gPCB3
aWR0aDsgY29sdW1uKyspIHsKPiA+IC0JCXNyY19pZHggPSBzdHJpZGUgKiAoaGVpZ2h0IC0gMSkg
KyBjb2x1bW47Cj4gPiArCQlzcmNfaWR4ID0gc3RyaWRlICogKGhlaWdodCAtIDEpICsgY29sdW1u
ICsgb2Zmc2V0Owo+ID4gICAJCWZvciAocm93ID0gMDsgcm93IDwgaGVpZ2h0OyByb3crKykgewo+
ID4gICAJCQlzdC0+bmVudHMrKzsKPiA+ICAgCQkJLyogV2UgZG9uJ3QgbmVlZCB0aGUgcGFnZXMs
IGJ1dCBuZWVkIHRvIGluaXRpYWxpemUKPiA+IEBAIC0zNjU0LDcgKzM2NTQsOCBAQCByb3RhdGVf
cGFnZXMoY29uc3QgZG1hX2FkZHJfdCAqaW4sIHVuc2lnbmVkIGludCBvZmZzZXQsCj4gPiAgIAkJ
CSAqIFRoZSBvbmx5IHRoaW5nIHdlIG5lZWQgYXJlIERNQSBhZGRyZXNzZXMuCj4gPiAgIAkJCSAq
Lwo+ID4gICAJCQlzZ19zZXRfcGFnZShzZywgTlVMTCwgSTkxNV9HVFRfUEFHRV9TSVpFLCAwKTsK
PiA+IC0JCQlzZ19kbWFfYWRkcmVzcyhzZykgPSBpbltvZmZzZXQgKyBzcmNfaWR4XTsKPiA+ICsJ
CQlzZ19kbWFfYWRkcmVzcyhzZykgPQo+ID4gKwkJCQlpOTE1X2dlbV9vYmplY3RfZ2V0X2RtYV9h
ZGRyZXNzKG9iaiwgc3JjX2lkeCk7Cj4gPiAgIAkJCXNnX2RtYV9sZW4oc2cpID0gSTkxNV9HVFRf
UEFHRV9TSVpFOwo+ID4gICAJCQlzZyA9IHNnX25leHQoc2cpOwo+ID4gICAJCQlzcmNfaWR4IC09
IHN0cmlkZTsKPiA+IEBAIC0zNjY4LDIyICszNjY5LDExIEBAIHN0YXRpYyBub2lubGluZSBzdHJ1
Y3Qgc2dfdGFibGUgKgo+ID4gICBpbnRlbF9yb3RhdGVfcGFnZXMoc3RydWN0IGludGVsX3JvdGF0
aW9uX2luZm8gKnJvdF9pbmZvLAo+ID4gICAJCSAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0
ICpvYmopCj4gPiAgIHsKPiA+IC0JY29uc3QgdW5zaWduZWQgbG9uZyBuX3BhZ2VzID0gb2JqLT5i
YXNlLnNpemUgLyBJOTE1X0dUVF9QQUdFX1NJWkU7Cj4gPiAgIAl1bnNpZ25lZCBpbnQgc2l6ZSA9
IGludGVsX3JvdGF0aW9uX2luZm9fc2l6ZShyb3RfaW5mbyk7Cj4gPiAtCXN0cnVjdCBzZ3RfaXRl
ciBzZ3RfaXRlcjsKPiA+IC0JZG1hX2FkZHJfdCBkbWFfYWRkcjsKPiA+IC0JdW5zaWduZWQgbG9u
ZyBpOwo+ID4gLQlkbWFfYWRkcl90ICpwYWdlX2FkZHJfbGlzdDsKPiA+ICAgCXN0cnVjdCBzZ190
YWJsZSAqc3Q7Cj4gPiAgIAlzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+ID4gICAJaW50IHJldCA9
IC1FTk9NRU07Cj4gPiAtCj4gPiAtCS8qIEFsbG9jYXRlIGEgdGVtcG9yYXJ5IGxpc3Qgb2Ygc291
cmNlIHBhZ2VzIGZvciByYW5kb20gYWNjZXNzLiAqLwo+ID4gLQlwYWdlX2FkZHJfbGlzdCA9IGt2
bWFsbG9jX2FycmF5KG5fcGFnZXMsCj4gPiAtCQkJCQlzaXplb2YoZG1hX2FkZHJfdCksCj4gPiAt
CQkJCQlHRlBfS0VSTkVMKTsKPiA+IC0JaWYgKCFwYWdlX2FkZHJfbGlzdCkKPiA+IC0JCXJldHVy
biBFUlJfUFRSKHJldCk7Cj4gPiArCWludCBpOwo+ID4gICAKPiA+ICAgCS8qIEFsbG9jYXRlIHRh
cmdldCBTRyBsaXN0LiAqLwo+ID4gICAJc3QgPSBrbWFsbG9jKHNpemVvZigqc3QpLCBHRlBfS0VS
TkVMKTsKPiA+IEBAIC0zNjk0LDI5ICszNjg0LDIwIEBAIGludGVsX3JvdGF0ZV9wYWdlcyhzdHJ1
Y3QgaW50ZWxfcm90YXRpb25faW5mbyAqcm90X2luZm8sCj4gPiAgIAlpZiAocmV0KQo+ID4gICAJ
CWdvdG8gZXJyX3NnX2FsbG9jOwo+ID4gICAKPiA+IC0JLyogUG9wdWxhdGUgc291cmNlIHBhZ2Ug
bGlzdCBmcm9tIHRoZSBvYmplY3QuICovCj4gPiAtCWkgPSAwOwo+ID4gLQlmb3JfZWFjaF9zZ3Rf
ZG1hKGRtYV9hZGRyLCBzZ3RfaXRlciwgb2JqLT5tbS5wYWdlcykKPiA+IC0JCXBhZ2VfYWRkcl9s
aXN0W2krK10gPSBkbWFfYWRkcjsKPiA+IC0KPiA+IC0JR0VNX0JVR19PTihpICE9IG5fcGFnZXMp
Owo+ID4gICAJc3QtPm5lbnRzID0gMDsKPiA+ICAgCXNnID0gc3QtPnNnbDsKPiA+ICAgCj4gPiAg
IAlmb3IgKGkgPSAwIDsgaSA8IEFSUkFZX1NJWkUocm90X2luZm8tPnBsYW5lKTsgaSsrKSB7Cj4g
PiAtCQlzZyA9IHJvdGF0ZV9wYWdlcyhwYWdlX2FkZHJfbGlzdCwgcm90X2luZm8tPnBsYW5lW2ld
Lm9mZnNldCwKPiA+ICsJCXNnID0gcm90YXRlX3BhZ2VzKG9iaiwgcm90X2luZm8tPnBsYW5lW2ld
Lm9mZnNldCwKPiA+ICAgCQkJCSAgcm90X2luZm8tPnBsYW5lW2ldLndpZHRoLCByb3RfaW5mby0+
cGxhbmVbaV0uaGVpZ2h0LAo+ID4gICAJCQkJICByb3RfaW5mby0+cGxhbmVbaV0uc3RyaWRlLCBz
dCwgc2cpOwo+ID4gICAJfQo+ID4gICAKPiA+IC0Ja3ZmcmVlKHBhZ2VfYWRkcl9saXN0KTsKPiA+
IC0KPiA+ICAgCXJldHVybiBzdDsKPiA+ICAgCj4gPiAgIGVycl9zZ19hbGxvYzoKPiA+ICAgCWtm
cmVlKHN0KTsKPiA+ICAgZXJyX3N0X2FsbG9jOgo+ID4gLQlrdmZyZWUocGFnZV9hZGRyX2xpc3Qp
Owo+ID4gICAKPiA+ICAgCURSTV9ERUJVR19EUklWRVIoIkZhaWxlZCB0byBjcmVhdGUgcm90YXRl
ZCBtYXBwaW5nIGZvciBvYmplY3Qgc2l6ZSAlenUhICgldXgldSB0aWxlcywgJXUgcGFnZXMpXG4i
LAo+ID4gICAJCQkgb2JqLT5iYXNlLnNpemUsIHJvdF9pbmZvLT5wbGFuZVswXS53aWR0aCwgcm90
X2luZm8tPnBsYW5lWzBdLmhlaWdodCwgc2l6ZSk7Cj4gPiAKCi0tIApWaWxsZSBTeXJqw6Rsw6QK
SW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50
ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==