From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/10] drm/i915: Remove crtc->config dereference from drrs_ctl Date: Tue, 16 Oct 2018 23:13:29 +0300 Message-ID: <20181016201329.GQ9144@intel.com> References: <20181011100457.8776-1-maarten.lankhorst@linux.intel.com> <20181011100457.8776-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72D4A6E0A0 for ; Tue, 16 Oct 2018 20:13:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181011100457.8776-2-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMTI6MDQ6NDhQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2FpdCBmb3IgaWRsZSwgYW5kIGl0ZXJhdGUgb3ZlciBjb25uZWN0b3JzIGlu c3RlYWQgb2YgZW5jb2RlcnMuCj4gV2l0aCB0aGlzIGluZm9ybWF0aW9uIHdlIGtub3cgY3J0Yy0+ c3RhdGUgaXMgdGhlIGFjdHVhbCBzdGF0ZSwKPiBhbmQgd2UgY2FuIGVuYWJsZS9kaXNhYmxlIGRy cnMgc2FmZWx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVu Lmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpMb29rcyBzZW5zaWJsZQoKUmV2aWV3ZWQtYnk6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8IDU0ICsrKysrKysrKysrKysr KysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAxMiBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k ZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IGY0 MmU5M2I3MWU2Ny4uYjA0ZDVhZGU1YTE1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1 Z2ZzLmMKPiBAQCAtNDY2MSwyMCArNDY2MSw0NSBAQCBzdGF0aWMgaW50IGk5MTVfZHJyc19jdGxf c2V0KHZvaWQgKmRhdGEsIHU2NCB2YWwpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IGRhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gJmRldl9wcml2 LT5kcm07Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiAtCXN0cnVjdCBpbnRl bF9lbmNvZGVyICplbmNvZGVyOwo+IC0Jc3RydWN0IGludGVsX2RwICppbnRlbF9kcDsKPiArCXN0 cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ICAKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwg NykKPiAgCQlyZXR1cm4gLUVOT0RFVjsKPiAgCj4gLQlkcm1fbW9kZXNldF9sb2NrX2FsbChkZXYp Owo+IC0JZm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGludGVsX2NydGMpIHsKPiAtCQlpZiAoIWlu dGVsX2NydGMtPmJhc2Uuc3RhdGUtPmFjdGl2ZSB8fAo+IC0JCQkJCSFpbnRlbF9jcnRjLT5jb25m aWctPmhhc19kcnJzKQo+IC0JCQljb250aW51ZTsKPiArCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2 LCBjcnRjKSB7Cj4gKwkJc3RydWN0IGRybV9jb25uZWN0b3JfbGlzdF9pdGVyIGNvbm5faXRlcjsK PiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCQlzdHJ1Y3QgZHJt X2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICsJCXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1p dDsKPiArCQlpbnQgcmV0Owo+ICsKPiArCQlyZXQgPSBkcm1fbW9kZXNldF9sb2NrX3NpbmdsZV9p bnRlcnJ1cHRpYmxlKCZjcnRjLT5iYXNlLm11dGV4KTsKPiArCQlpZiAocmV0KQo+ICsJCQlyZXR1 cm4gcmV0Owo+ICsKPiArCQljcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5i YXNlLnN0YXRlKTsKPiArCj4gKwkJaWYgKCFjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSB8fAo+ICsJ CSAgICAhY3J0Y19zdGF0ZS0+aGFzX2RycnMpCj4gKwkJCWdvdG8gb3V0Owo+ICAKPiAtCQlmb3Jf ZWFjaF9lbmNvZGVyX29uX2NydGMoZGV2LCAmaW50ZWxfY3J0Yy0+YmFzZSwgZW5jb2Rlcikgewo+ ICsJCWNvbW1pdCA9IGNydGNfc3RhdGUtPmJhc2UuY29tbWl0Owo+ICsJCWlmIChjb21taXQpIHsK PiArCQkJcmV0ID0gd2FpdF9mb3JfY29tcGxldGlvbl9pbnRlcnJ1cHRpYmxlKCZjb21taXQtPmh3 X2RvbmUpOwo+ICsJCQlpZiAocmV0KQo+ICsJCQkJZ290byBvdXQ7Cj4gKwkJfQo+ICsKPiArCQlk cm1fY29ubmVjdG9yX2xpc3RfaXRlcl9iZWdpbihkZXYsICZjb25uX2l0ZXIpOwo+ICsJCWRybV9m b3JfZWFjaF9jb25uZWN0b3JfaXRlcihjb25uZWN0b3IsICZjb25uX2l0ZXIpIHsKPiArCQkJc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXI7Cj4gKwkJCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHA7Cj4gKwo+ICsJCQlpZiAoIShjcnRjX3N0YXRlLT5iYXNlLmNvbm5lY3Rvcl9tYXNrICYKPiAr CQkJICAgICAgZHJtX2Nvbm5lY3Rvcl9tYXNrKGNvbm5lY3RvcikpKQo+ICsJCQkJY29udGludWU7 Cj4gKwo+ICsJCQllbmNvZGVyID0gaW50ZWxfYXR0YWNoZWRfZW5jb2Rlcihjb25uZWN0b3IpOwo+ ICAJCQlpZiAoZW5jb2Rlci0+dHlwZSAhPSBJTlRFTF9PVVRQVVRfRURQKQo+ICAJCQkJY29udGlu dWU7Cj4gIAo+IEBAIC00Njg0LDEzICs0NzA5LDE4IEBAIHN0YXRpYyBpbnQgaTkxNV9kcnJzX2N0 bF9zZXQodm9pZCAqZGF0YSwgdTY0IHZhbCkKPiAgCQkJaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxf ZHAoJmVuY29kZXItPmJhc2UpOwo+ICAJCQlpZiAodmFsKQo+ICAJCQkJaW50ZWxfZWRwX2RycnNf ZW5hYmxlKGludGVsX2RwLAo+IC0JCQkJCQkJaW50ZWxfY3J0Yy0+Y29uZmlnKTsKPiArCQkJCQkJ ICAgICAgY3J0Y19zdGF0ZSk7Cj4gIAkJCWVsc2UKPiAgCQkJCWludGVsX2VkcF9kcnJzX2Rpc2Fi bGUoaW50ZWxfZHAsCj4gLQkJCQkJCQlpbnRlbF9jcnRjLT5jb25maWcpOwo+ICsJCQkJCQkgICAg ICAgY3J0Y19zdGF0ZSk7Cj4gIAkJfQo+ICsJCWRybV9jb25uZWN0b3JfbGlzdF9pdGVyX2VuZCgm Y29ubl9pdGVyKTsKPiArCj4gK291dDoKPiArCQlkcm1fbW9kZXNldF91bmxvY2soJmNydGMtPmJh c2UubXV0ZXgpOwo+ICsJCWlmIChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gIAl9Cj4gLQlkcm1f bW9kZXNldF91bmxvY2tfYWxsKGRldik7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAtLSAKPiAy LjE5LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==