From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme-rdma: always have a valid trsvcid
Date: Wed, 17 Oct 2018 09:08:51 +0200 [thread overview]
Message-ID: <20181017070851.GA23187@lst.de> (raw)
In-Reply-To: <20181004174358.15267-1-sagi@grimberg.me>
On Thu, Oct 04, 2018@10:43:57AM -0700, Sagi Grimberg wrote:
> If not passed, we set the default trsvcid. We can rely
> on having trsvcid and can simplify the controller matching
> logic.
Use your 73 lines for the changelog, please.
> + if (!(opts->mask & NVMF_OPT_TRSVCID)) {
> + opts->trsvcid =
> + kstrdup(__stringify(NVME_RDMA_IP_PORT), GFP_KERNEL);
This needs error handling.
Otherwise the patch looks fine to me.
prev parent reply other threads:[~2018-10-17 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 17:43 [PATCH 1/2] nvme-rdma: always have a valid trsvcid Sagi Grimberg
2018-10-04 17:43 ` [PATCH 2/2] nvme-fabrics: move controller options matching to fabrics Sagi Grimberg
2018-10-17 7:09 ` Christoph Hellwig
2018-10-16 1:04 ` [PATCH 1/2] nvme-rdma: always have a valid trsvcid Sagi Grimberg
2018-10-17 7:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017070851.GA23187@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.