From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] quorum: Return an error if the blkverify mode has invalid settings
Date: Wed, 17 Oct 2018 17:31:32 +0200 [thread overview]
Message-ID: <20181017153132.GI31479@localhost.localdomain> (raw)
In-Reply-To: <e0ba08677155b2cf3820b580fb5057458ed017d0.1539786605.git.berto@igalia.com>
Am 17.10.2018 um 16:33 hat Alberto Garcia geschrieben:
> The blkverify mode of Quorum can only be enabled if the number of
> children is exactly two and the value of vote-threshold is also two.
>
> If the user tries to enable it but the other settings are incorrect
> then QEMU simply prints an error message to stderr and carries on
> disabling the blkverify setting.
>
> This patch makes quorum_open() fail and return an error in this case.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reported-by: Markus Armbruster <armbru@redhat.com>
While reviewing this, I think I found another problem: Shouldn't
.bdrv_add_child refuse to add a child if s->is_blkverify == true? (And
probably assert in .bdrv_del_child that s->is_blkverify == false after
checking s->num_children <= s->threshold)
Kevin
next prev parent reply other threads:[~2018-10-17 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 14:33 [Qemu-devel] [PATCH 0/3] Misc Quorum fixes Alberto Garcia
2018-10-17 14:33 ` [Qemu-devel] [PATCH 1/3] quorum: Remove quorum_err() Alberto Garcia
2018-10-17 14:33 ` [Qemu-devel] [PATCH 2/3] quorum: Return an error if the blkverify mode has invalid settings Alberto Garcia
2018-10-17 15:31 ` Kevin Wolf [this message]
2018-10-17 15:34 ` Alberto Garcia
2018-10-17 15:44 ` Kevin Wolf
2018-10-17 14:33 ` [Qemu-devel] [PATCH 3/3] iotest: Test the blkverify mode of the Quorum driver Alberto Garcia
2018-10-17 15:33 ` [Qemu-devel] [PATCH 0/3] Misc Quorum fixes Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017153132.GI31479@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.