From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A82E4E00ABE; Wed, 17 Oct 2018 12:46:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [198.47.19.142 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 132BEE00A0C for ; Wed, 17 Oct 2018 12:46:24 -0700 (PDT) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id w9HJkOSO071155; Wed, 17 Oct 2018 14:46:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1539805584; bh=5Pz5Q9XUYkC4jfGDs8HxA0ZgAi5bUmIxRQHV3xEIMJU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=I2kF1pL22loDLYysVUZvhmSmCU9n/aa2qXcwoUZ/8SqLvAxKcIhTk5cYd58BhsHfv 6jSa2xToxXl0EC5569tVJXPKZrm7yOkfmkxuukjQHnCPqPebLynHx3EzbNDPFjsWJX swK4UAyAH0A9SeyzPJxyHrBvtQPg1iTstURJ3x+A= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9HJkOX9006305; Wed, 17 Oct 2018 14:46:24 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 17 Oct 2018 14:46:23 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 17 Oct 2018 14:46:24 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9HJkNIW029096; Wed, 17 Oct 2018 14:46:23 -0500 Date: Wed, 17 Oct 2018 15:46:23 -0400 From: Denys Dmytriyenko To: Khem Raj Message-ID: <20181017194623.GJ4031@beryl> References: <20181017192853.42942-1-raj.khem@gmail.com> <20181017192853.42942-4-raj.khem@gmail.com> MIME-Version: 1.0 In-Reply-To: <20181017192853.42942-4-raj.khem@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-ti@yoctoproject.org Subject: Re: [PATCH 4/5] beaglebone.conf: Package kernel and devicetree X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 19:46:25 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Oct 17, 2018 at 12:28:52PM -0700, Khem Raj wrote: > Use variables from upstream u-boot, makes it easy to switch to > mainline u-boot from oe-core if someone wants to Actually, those vars are not unique to upstream u-boot: http://arago-project.org/git/?p=meta-ti.git;a=blob;f=recipes-bsp/u-boot/u-boot-ti.inc;hb=HEAD Lines #13 and #54. > Signed-off-by: Khem Raj > --- > conf/machine/beaglebone.conf | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/conf/machine/beaglebone.conf b/conf/machine/beaglebone.conf > index 25147926..9b656d01 100644 > --- a/conf/machine/beaglebone.conf > +++ b/conf/machine/beaglebone.conf > @@ -1,6 +1,6 @@ > #@TYPE: Machine > #@NAME: BeagleBone machine > -#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board > +#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board > > require conf/machine/include/ti33x.inc > > @@ -17,10 +17,16 @@ SERIAL_CONSOLE = "115200 ttyS0" > #UBOOT_MACHINE = "am335x_boneblack_config" > > WKS_FILE = "sdimage-bootpart.wks" > -IMAGE_BOOT_FILES = "MLO u-boot.img" > -IMAGE_FSTYPES += "tar.xz wic.xz" > > do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot" > +IMAGE_BOOT_FILES ?= "u-boot.${UBOOT_SUFFIX} MLO" > + > +IMAGE_FSTYPES += "tar.xz wic.xz" > > # Refine the list of device targets for ti-pdk class recipes > TI_PDK_LIMIT_BOARDS = "bbbAM335x" > + > +SPL_BINARY = "MLO" > +UBOOT_SUFFIX = "img" Well, I see your point defining these 2 vars here, but then you don't use MLO above for IMAGE_BOOT_FILES... Also, it would make sense to start moving those vars into machine configs for other machines. And make them conditional in u-boot recipe... > +IMAGE_INSTALL_append = " kernel-devicetree kernel-image-zimage" > -- > 2.19.1 > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti