Re: [PATCH V2 4/5] beaglebone.conf: Package kernel and devicetree

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Oct 17, 2018 at 01:02:00PM -0700, Khem Raj wrote:
> Use variables from upstream u-boot, makes it easy to switch to
> mainline u-boot from oe-core if someone wants to

Thanks for addressing most of my comments. If you don't mind, I'll re-phrase 
this comment slightly.


> Use SPL_BINARY and UBOOT_SUFFIX to define IMAGE_BOOT_FILES
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> V2: Use SPL_BINARY var
> 
>  conf/machine/beaglebone.conf | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/conf/machine/beaglebone.conf b/conf/machine/beaglebone.conf
> index 25147926..36920673 100644
> --- a/conf/machine/beaglebone.conf
> +++ b/conf/machine/beaglebone.conf
> @@ -1,6 +1,6 @@
>  #@TYPE: Machine
>  #@NAME: BeagleBone machine
> -#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board 
> +#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board
>  
>  require conf/machine/include/ti33x.inc
>  
> @@ -17,10 +17,16 @@ SERIAL_CONSOLE = "115200 ttyS0"
>  #UBOOT_MACHINE = "am335x_boneblack_config"
>  
>  WKS_FILE = "sdimage-bootpart.wks"
> -IMAGE_BOOT_FILES = "MLO u-boot.img"
> -IMAGE_FSTYPES += "tar.xz wic.xz"
>  
>  do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot"
> +IMAGE_BOOT_FILES ?= "u-boot.${UBOOT_SUFFIX} ${SPL_BINARY}"
> +
> +IMAGE_FSTYPES += "tar.xz wic.xz"
>  
>  # Refine the list of device targets for ti-pdk class recipes
>  TI_PDK_LIMIT_BOARDS = "bbbAM335x"
> +
> +SPL_BINARY = "MLO"
> +UBOOT_SUFFIX = "img"
> +
> +IMAGE_INSTALL_append = " kernel-devicetree kernel-image-zimage"
> -- 
> 2.19.1
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti