Re: [master][PATCH] ti-gc320-driver: workaround for gcc8 stringop-overflow error

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Oct 17, 2018 at 06:53:50PM -0700, Khem Raj wrote:
> On Wed, Oct 17, 2018 at 6:04 PM Denys Dmytriyenko <denys@ti.com> wrote:
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  ...build-bypass-gcc8-stringop-overflow-error.patch | 26 ++++++++++++++++++++++
> >  .../gc320-drivers/ti-gc320-driver_5.0.11.p7.bb     |  4 +++-
> >  2 files changed, 29 insertions(+), 1 deletion(-)
> >  create mode 100644 recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch
> >
> > diff --git a/recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch b/recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch
> > new file mode 100644
> > index 0000000..431afa7
> > --- /dev/null
> > +++ b/recipes-bsp/gc320-drivers/ti-gc320-driver/0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch
> > @@ -0,0 +1,26 @@
> > +From c93a4217425ffebae1fb2d5c6c7fc957eb8aa18c Mon Sep 17 00:00:00 2001
> > +From: Denys Dmytriyenko <denys@ti.com>
> > +Date: Tue, 16 Oct 2018 21:16:48 -0400
> > +Subject: [PATCH] Kbuild: bypass gcc8 stringop-overflow error
> > +
> > +Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > +---
> > + src/Kbuild | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/src/Kbuild b/src/Kbuild
> > +index 574a107..df4368d 100755
> > +--- a/src/Kbuild
> > ++++ b/src/Kbuild
> > +@@ -87,7 +87,7 @@ MODULE_NAME ?= galcore
> > + CUSTOMER_ALLOCATOR_OBJS    ?=
> > + ALLOCATOR_ARRAY_H_LOCATION ?= $(OS_KERNEL_DIR)/allocator/default/
> > +
> > +-EXTRA_CFLAGS += -Werror
> > ++EXTRA_CFLAGS += -Werror -Wno-stringop-overflow
> > +
> 
> while its clear you are marking it as workaround, but this may be one
> time when you can also fix it and it might be showing you a latent
> issue that went unoticed in past unless you ran static analysers on
> this code. So are
> there many errors ? then the workaround might be ok. Otherwise may be
> fixing the underlying cause might be a good option.

Yes, I realize that. I tried fixing it, but since I'm not really familiar 
with this code, I wasn't sure about one place and decided to leave to the 
corresponding team to fix properly. For now I just needed to unbreak it.


> > + OBJS := $(OS_KERNEL_DIR)/gc_hal_kernel_device.o \
> > +         $(OS_KERNEL_DIR)/gc_hal_kernel_linux.o \
> > +--
> > +2.7.4
> > +
> > diff --git a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> > index 94485b6..e49a41f 100644
> > --- a/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> > +++ b/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
> > @@ -13,7 +13,9 @@ BRANCH = "ti-${PV}-k4.14"
> >
> >  SRCREV = "a36799d9329efcfff19e30e690156d5ebf7e0c55"
> >
> > -SRC_URI = "git://git.ti.com/graphics/ti-gc320-driver.git;protocol=git;branch=${BRANCH}"
> > +SRC_URI = "git://git.ti.com/graphics/ti-gc320-driver.git;protocol=git;branch=${BRANCH} \
> > +       file://0001-Kbuild-bypass-gcc8-stringop-overflow-error.patch;striplevel=2"
> > +
> >  S = "${WORKDIR}/git/src"
> >
> >  EXTRA_OEMAKE += "-f Kbuild AQROOT=${S} KERNEL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PATH=${TOOLCHAIN_PATH} CROSS_COMPILE=${TARGET_PREFIX} ARCH_TYPE=${TARGET_ARCH}"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti