From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500 From: Vinod Koul Message-Id: <20181018095507.GC2400@vkoul-mobl> Date: Thu, 18 Oct 2018 15:25:07 +0530 To: Benjamin Herrenschmidt Cc: "sudheer.v" , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Russell King , Dan Williams , Jiri Slaby , Thomas Gleixner , Marc Zyngier , Christian Borntraeger , Michael Moese , Hendrik Brueckner , Kate Stewart , Philippe Ombredanne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Sudheer V , ShivahShankar Shakarnarayan rao List-ID: T24gMTctMTAtMTgsIDE5OjU2LCBCZW5qYW1pbiBIZXJyZW5zY2htaWR0IHdyb3RlOgo+IE9uIFdl ZCwgMjAxOC0xMC0xNyBhdCAxMTozNSArMDUzMCwgVmlub2Qgd3JvdGU6Cj4gPiBPbiAxNy0xMC0x OCwgMDk6NDEsIHN1ZGhlZXIudiB3cm90ZToKPiA+IAo+ID4gUGxlYXNlIGFkZCB0aGUgY2hhbmdl IGxvZyBkZXNjcmliaW5nIHRoZSBkcml2ZXIgYW5kIGl0cyBmZWF0dXJlcwo+ID4gCj4gPiA+IFNp Z25lZC1vZmYtYnk6IHN1ZGhlZXIudiA8b3Blbi5zdWRoZWVyQGdtYWlsLmNvbT4KPiA+ID4gLS0t Cj4gPiA+ICBkcml2ZXJzL3R0eS9zZXJpYWwvODI1MC84MjUwX2FzcGVlZF91YXJ0X2RtYS5jIHwg MTU5NCArKysrKysrKysrKysrKysrKysrKysrKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNTk0 IGluc2VydGlvbnMoKykKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL3R0eS9zZXJp YWwvODI1MC84MjUwX2FzcGVlZF91YXJ0X2RtYS5jCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9hc3BlZWRfdWFydF9kbWEuYyBiL2RyaXZlcnMv dHR5L3NlcmlhbC84MjUwLzgyNTBfYXNwZWVkX3VhcnRfZG1hLmMKPiA+ID4gbmV3IGZpbGUgbW9k ZSAxMDA2NDQKPiA+ID4gaW5kZXggMDAwMDAwMC4uZTEwMTlhOAo+ID4gPiAtLS0gL2Rldi9udWxs Cj4gPiA+ICsrKyBiL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUwLzgyNTBfYXNwZWVkX3VhcnRfZG1h LmMKPiA+IAo+ID4gd2h5IGlzIHRoaXMgaW4gc2VyaWFsLiBJdCBpcyBkbWFlbmdpbmUgZHJpdmVy IHNvIGJlbG9uZ3MgdG8gZHJpdmVycy9kbWEvCj4gPiBsaWtlIG90aGVyIGNvbnRyb2xsZXJzLiBQ bGVhc2UgbW92ZSBpdCBvdXQgYW5kIHJlc3VibWl0Lgo+ICAKPiBJdCdzIG5vdCBhIGRtYWVuZ2lu ZSBkcml2ZXIuIEl0J3MgYSBzZXJpYWwgVUFSVCBkcml2ZXIgdGhhdCBoYXBwZW5zIHRvCj4gdXNl IGEgZGVkaWNhdGVkIERNQSBlbmdpbmUuCgpUaGVuIEkgc2VlIG5vIHJlYXNvbiBmb3IgaXQgdG8g dXNlIGRtYWVuZ2luZSBBUElzLiBUaGUgZnJhbWV3b3JrIGFsbG93cwpwZW9wbGUgdG8gc2hhcmUg YSBjb250cm9sbGVyIGZvciBtYW55IGNsaWVudHMsIGJ1dCBpZiB5b3UgaGF2ZSBkZWRpY2F0ZWQK b25lIHRoZW4geW91IG1heSB1c2UgaXQgZGlyZWN0bHkKCj4gSXQncyB1bmNsZWFyIHdoZXRoZXIg aXQgc2hvdWxkIGJlIHNwbGl0IGludG8gdHdvIGRyaXZlcnMsIG9yIGp1c3QgaGF2ZQo+IHRoZSBz ZXJpYWwgZHJpdmVyIGRpcmVjdGx5IHVzZSB0aGUgZG1hIGVuZ2luZSBzaW5jZSB0aGF0IGVuZ2lu ZSBpcwo+IGRlZGljYXRlZCBpbiBIVyB0byBvbmx5IHdvcmsgb24gdGhvc2UgVUFSVHMgYW5kIG5v dGhpbmcgZWxzZS4uLgo+IAo+IENoZWVycywKPiBCZW4uCj4gCj4gCj4gPiBXaGlsZSBkb2luZyBy ZXN1Ym1pc3Npb24gcGxlYXNlIHRha2Ugc29tZSB0aW1lIHRvIHVuZGVyc3RhbmQgc3Vic3lzdGVt Cj4gPiB0YWdzIHRvIHVzZS4gKGhpbnQgZ2l0IGxvZyA8c3Vic3lzdGVtPiB3aWxsIHRlbGwgeW91 KQo+ID4gCj4gPiBBbHNvIHNlcmllcyBoYXMgW1tQQVRDSF0gOC85XSB3aGVyZWFzIGl0IHNob3Vs ZCBiZSBbUEFUQ0ggOC85XSBwbGVhc2UKPiA+IGxldCBnaXQgZ2VuZXJhdGUgdGhhdCBmb3IgeW91 IChoaW50IGdpdCBmb3JtYXQtcGF0Y2ggc3RhcnQuLmVuZCBkb2VzIGEKPiA+IGdvb2Qgam9iKQo+ ID4gCj4gPiA+IEBAIC0wLDAgKzEsMTU5NCBAQAo+ID4gPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50 aWZpZXI6IEdQTC0yLjAKPiA+ID4gKy8qCj4gPiA+ICsgKiAgIGRyaXZlcnMvdHR5L3NlcmlhbC84 MjUwLzgyNTBfYXNwZWVkX3VhcnRfZG1hLmMKPiA+ID4gKyAqICAgIDEuIDIwMTgvMDcvMDEgU2hp dmFoIFNoYW5rYXIgY3JlYXRlZAo+ID4gPiArICogICAgMi4gMjAxOC8wOC8yNSBzdWRoZWVyLnZl bGlzZXRpPG9wZW4uc3VkaGVlckBnbWFpbC5jb20+IG1vZGlmaWVkCj4gPiAKPiA+IHdlIGRvbnQg dXNlIHRoaXMgbG9nIGluIGtlcm5lbC4gSSBkbyBub3Qgc2VlIHMtby1iIGJ5IFNoaXZhaCwgdGhh dAo+ID4gc2hvdWxkIGJlIGFkZGVkLiBJIHRoaW5rIGhlIHNob3VsZCBiZSBhdXRob3IgYW5kIHlv dSBuZWVkIHRvIGxpc3QKPiA+IGNoYW5nZXMgeW91IGRpZC4uCj4gPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Date: Thu, 18 Oct 2018 15:25:07 +0530 Subject: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500 In-Reply-To: <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> References: <1539749466-3912-1-git-send-email-open.sudheer@gmail.com> <1539749466-3912-9-git-send-email-open.sudheer@gmail.com> <20181017060531.GU2400@vkoul-mobl> <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> Message-ID: <20181018095507.GC2400@vkoul-mobl> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 17-10-18, 19:56, Benjamin Herrenschmidt wrote: > On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote: > > On 17-10-18, 09:41, sudheer.v wrote: > > > > Please add the change log describing the driver and its features > > > > > Signed-off-by: sudheer.v > > > --- > > > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 ++++++++++++++++++++++++ > > > 1 file changed, 1594 insertions(+) > > > create mode 100644 drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > > > diff --git a/drivers/tty/serial/8250/8250_aspeed_uart_dma.c b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > new file mode 100644 > > > index 0000000..e1019a8 > > > --- /dev/null > > > +++ b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > why is this in serial. It is dmaengine driver so belongs to drivers/dma/ > > like other controllers. Please move it out and resubmit. > > It's not a dmaengine driver. It's a serial UART driver that happens to > use a dedicated DMA engine. Then I see no reason for it to use dmaengine APIs. The framework allows people to share a controller for many clients, but if you have dedicated one then you may use it directly > It's unclear whether it should be split into two drivers, or just have > the serial driver directly use the dma engine since that engine is > dedicated in HW to only work on those UARTs and nothing else... > > Cheers, > Ben. > > > > While doing resubmission please take some time to understand subsystem > > tags to use. (hint git log will tell you) > > > > Also series has [[PATCH] 8/9] whereas it should be [PATCH 8/9] please > > let git generate that for you (hint git format-patch start..end does a > > good job) > > > > > @@ -0,0 +1,1594 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > + * 1. 2018/07/01 Shivah Shankar created > > > + * 2. 2018/08/25 sudheer.veliseti modified > > > > we dont use this log in kernel. I do not see s-o-b by Shivah, that > > should be added. I think he should be author and you need to list > > changes you did.. > > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Subject: Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500 Date: Thu, 18 Oct 2018 15:25:07 +0530 Message-ID: <20181018095507.GC2400@vkoul-mobl> References: <1539749466-3912-1-git-send-email-open.sudheer@gmail.com> <1539749466-3912-9-git-send-email-open.sudheer@gmail.com> <20181017060531.GU2400@vkoul-mobl> <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Herrenschmidt Cc: "sudheer.v" , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Russell King , Dan Williams , Jiri Slaby , Thomas Gleixner , Marc Zyngier , Christian Borntraeger , Michael Moese , Hendrik Brueckner , Kate Stewart , Philippe Ombredanne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-k List-Id: linux-serial@vger.kernel.org On 17-10-18, 19:56, Benjamin Herrenschmidt wrote: > On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote: > > On 17-10-18, 09:41, sudheer.v wrote: > > > > Please add the change log describing the driver and its features > > > > > Signed-off-by: sudheer.v > > > --- > > > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 ++++++++++++++++++++++++ > > > 1 file changed, 1594 insertions(+) > > > create mode 100644 drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > > > diff --git a/drivers/tty/serial/8250/8250_aspeed_uart_dma.c b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > new file mode 100644 > > > index 0000000..e1019a8 > > > --- /dev/null > > > +++ b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > why is this in serial. It is dmaengine driver so belongs to drivers/dma/ > > like other controllers. Please move it out and resubmit. > > It's not a dmaengine driver. It's a serial UART driver that happens to > use a dedicated DMA engine. Then I see no reason for it to use dmaengine APIs. The framework allows people to share a controller for many clients, but if you have dedicated one then you may use it directly > It's unclear whether it should be split into two drivers, or just have > the serial driver directly use the dma engine since that engine is > dedicated in HW to only work on those UARTs and nothing else... > > Cheers, > Ben. > > > > While doing resubmission please take some time to understand subsystem > > tags to use. (hint git log will tell you) > > > > Also series has [[PATCH] 8/9] whereas it should be [PATCH 8/9] please > > let git generate that for you (hint git format-patch start..end does a > > good job) > > > > > @@ -0,0 +1,1594 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > + * 1. 2018/07/01 Shivah Shankar created > > > + * 2. 2018/08/25 sudheer.veliseti modified > > > > we dont use this log in kernel. I do not see s-o-b by Shivah, that > > should be added. I think he should be author and you need to list > > changes you did.. > > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: vkoul@kernel.org (Vinod) Date: Thu, 18 Oct 2018 15:25:07 +0530 Subject: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500 In-Reply-To: <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> References: <1539749466-3912-1-git-send-email-open.sudheer@gmail.com> <1539749466-3912-9-git-send-email-open.sudheer@gmail.com> <20181017060531.GU2400@vkoul-mobl> <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> Message-ID: <20181018095507.GC2400@vkoul-mobl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17-10-18, 19:56, Benjamin Herrenschmidt wrote: > On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote: > > On 17-10-18, 09:41, sudheer.v wrote: > > > > Please add the change log describing the driver and its features > > > > > Signed-off-by: sudheer.v > > > --- > > > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 ++++++++++++++++++++++++ > > > 1 file changed, 1594 insertions(+) > > > create mode 100644 drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > > > diff --git a/drivers/tty/serial/8250/8250_aspeed_uart_dma.c b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > new file mode 100644 > > > index 0000000..e1019a8 > > > --- /dev/null > > > +++ b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > why is this in serial. It is dmaengine driver so belongs to drivers/dma/ > > like other controllers. Please move it out and resubmit. > > It's not a dmaengine driver. It's a serial UART driver that happens to > use a dedicated DMA engine. Then I see no reason for it to use dmaengine APIs. The framework allows people to share a controller for many clients, but if you have dedicated one then you may use it directly > It's unclear whether it should be split into two drivers, or just have > the serial driver directly use the dma engine since that engine is > dedicated in HW to only work on those UARTs and nothing else... > > Cheers, > Ben. > > > > While doing resubmission please take some time to understand subsystem > > tags to use. (hint git log will tell you) > > > > Also series has [[PATCH] 8/9] whereas it should be [PATCH 8/9] please > > let git generate that for you (hint git format-patch start..end does a > > good job) > > > > > @@ -0,0 +1,1594 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > + * 1. 2018/07/01 Shivah Shankar created > > > + * 2. 2018/08/25 sudheer.veliseti modified > > > > we dont use this log in kernel. I do not see s-o-b by Shivah, that > > should be added. I think he should be author and you need to list > > changes you did.. > > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70216C5ACCC for ; Thu, 18 Oct 2018 09:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2294021557 for ; Thu, 18 Oct 2018 09:55:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="h08tFYmk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2294021557 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbeJRRzb (ORCPT ); Thu, 18 Oct 2018 13:55:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:43404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727516AbeJRRza (ORCPT ); Thu, 18 Oct 2018 13:55:30 -0400 Received: from localhost (unknown [106.200.232.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 301412154D; Thu, 18 Oct 2018 09:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539856516; bh=MfdJjJk1hZ12jgUKZujsgPG7KdjeTExKU6EDMb8ip0o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h08tFYmkK3gACx5BgGbnYrknwO7D8PUlwCOmvie8F6lW28jqRvgoJnuLUOD+vySrk Zt2FnZjdawF7D87f67o4xW7L+C9cfYt59yqMO08Gle98WrTnjpCHi+ix/hNlFaVK8f 5cuv1LkbAlpScc0882ly3cJactcDGcQNRpmRpB/Y= Date: Thu, 18 Oct 2018 15:25:07 +0530 From: Vinod To: Benjamin Herrenschmidt Cc: "sudheer.v" , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Russell King , Dan Williams , Jiri Slaby , Thomas Gleixner , Marc Zyngier , Christian Borntraeger , Michael Moese , Hendrik Brueckner , Kate Stewart , Philippe Ombredanne , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Sudheer V , ShivahShankar Shakarnarayan rao Subject: Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500 Message-ID: <20181018095507.GC2400@vkoul-mobl> References: <1539749466-3912-1-git-send-email-open.sudheer@gmail.com> <1539749466-3912-9-git-send-email-open.sudheer@gmail.com> <20181017060531.GU2400@vkoul-mobl> <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-10-18, 19:56, Benjamin Herrenschmidt wrote: > On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote: > > On 17-10-18, 09:41, sudheer.v wrote: > > > > Please add the change log describing the driver and its features > > > > > Signed-off-by: sudheer.v > > > --- > > > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 ++++++++++++++++++++++++ > > > 1 file changed, 1594 insertions(+) > > > create mode 100644 drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > > > diff --git a/drivers/tty/serial/8250/8250_aspeed_uart_dma.c b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > new file mode 100644 > > > index 0000000..e1019a8 > > > --- /dev/null > > > +++ b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > > why is this in serial. It is dmaengine driver so belongs to drivers/dma/ > > like other controllers. Please move it out and resubmit. > > It's not a dmaengine driver. It's a serial UART driver that happens to > use a dedicated DMA engine. Then I see no reason for it to use dmaengine APIs. The framework allows people to share a controller for many clients, but if you have dedicated one then you may use it directly > It's unclear whether it should be split into two drivers, or just have > the serial driver directly use the dma engine since that engine is > dedicated in HW to only work on those UARTs and nothing else... > > Cheers, > Ben. > > > > While doing resubmission please take some time to understand subsystem > > tags to use. (hint git log will tell you) > > > > Also series has [[PATCH] 8/9] whereas it should be [PATCH 8/9] please > > let git generate that for you (hint git format-patch start..end does a > > good job) > > > > > @@ -0,0 +1,1594 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * drivers/tty/serial/8250/8250_aspeed_uart_dma.c > > > + * 1. 2018/07/01 Shivah Shankar created > > > + * 2. 2018/08/25 sudheer.veliseti modified > > > > we dont use this log in kernel. I do not see s-o-b by Shivah, that > > should be added. I think he should be author and you need to list > > changes you did.. > > -- ~Vinod