From: Christian Hesse <list@eworm.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] subtree: make install targets depend on build targets
Date: Thu, 18 Oct 2018 10:05:04 +0200 [thread overview]
Message-ID: <20181018100504.053e4827@leda> (raw)
In-Reply-To: <xmqqftx4vwe5.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
Junio C Hamano <gitster@pobox.com> on Thu, 2018/10/18 11:09:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> > The rule says
> >
> > install-html: html
> > $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir)
> > $(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir)
> >
> > and $^ substitutes to "html" after this change.
>
> Sorry about that.
>
> From: Junio C Hamano <gitster@pobox.com>
> Date: Thu, 18 Oct 2018 11:07:17 +0900
> Subject: [PATCH] Revert "subtree: make install targets depend on build
> targets"
>
> This reverts commit 744f7c4c314dc0e7816ac05520e8358c8318187a.
>
> These targets do depend on the fact that each prereq is explicitly
> listed via their use of $^, which I failed to notice, and broke the
> build.
>
> [...]
>
> @@ -98,4 +98,4 @@ clean:
> $(RM) $(GIT_SUBTREE)
> $(RM) *.xml *.html *.1
>
> -.PHONY: FORCE man html install-man install-html
> +.PHONY: FORCE
We could keep the phony part at least...
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-10-18 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 7:30 [PATCH 1/1] subtree: add build targets 'man' and 'html' Christian Hesse
2018-10-10 2:26 ` Junio C Hamano
2018-10-12 8:08 ` Johannes Schindelin
2018-10-15 21:15 ` Christian Hesse
2018-10-16 2:05 ` Junio C Hamano
2018-10-16 5:01 ` Junio C Hamano
2018-10-16 7:56 ` [PATCH 1/1] subtree: make install targets depend on build targets Christian Hesse
2018-10-16 8:00 ` Junio C Hamano
2018-10-17 2:45 ` Jonathan Nieder
2018-10-18 2:05 ` Junio C Hamano
2018-10-18 2:09 ` Junio C Hamano
2018-10-18 8:05 ` Christian Hesse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018100504.053e4827@leda \
--to=list@eworm.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.