From: Phillip Potter <phil@philpotter.co.uk>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: dushistov@mail.ru, David.Laight@aculab.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: ufs: Remove switch statement from ufs_set_de_type function
Date: Thu, 18 Oct 2018 11:19:45 +0100 [thread overview]
Message-ID: <20181018101945.GA4787@pathfinder> (raw)
In-Reply-To: <20181017233305.GC32577@ZenIV.linux.org.uk>
On Thu, Oct 18, 2018 at 12:33:05AM +0100, Al Viro wrote:
> They are. BSD folks had (sanely, IMO) put the 'type' bits of st_mode
> into directory entry verbatim. Again, "symbolic constant" != "can be
> expected to change"... If, e.g., some port decides to change S_IFIFO,
> they'll have no end of fun accessing ext*, xfs, ufs, etc. since that
> value is stored in the on-disk inode and in effect pinned down by
> that.
>
> All S_... constants are universal and going to remain unchanged on
> any Unices.
Dear Al,
Shall I resubmit without the compile-time checks in the latest patch then?
Regards,
Phil
next prev parent reply other threads:[~2018-10-18 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:08 [PATCH] fs: ufs: Remove switch statement from ufs_set_de_type function Phillip Potter
2018-10-17 10:11 ` David Laight
2018-10-17 23:33 ` Al Viro
2018-10-18 10:19 ` Phillip Potter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-20 22:09 Phillip Potter
2018-10-20 22:26 ` Matthew Wilcox
2018-10-20 23:07 ` Al Viro
2018-10-21 5:30 ` Amir Goldstein
2018-10-21 9:57 ` Phillip Potter
2018-10-21 11:02 ` Amir Goldstein
2018-10-22 8:20 ` Phillip Potter
2018-10-17 12:34 Phillip Potter
2018-10-09 13:16 Phillip Potter
2018-10-02 16:41 Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018101945.GA4787@pathfinder \
--to=phil@philpotter.co.uk \
--cc=David.Laight@aculab.com \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.