From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Jan Kara <jack@suse.cz>
Cc: amir73il@gmail.com, linux-api@vger.kernel.org, sgrubb@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] fanotify: introduce new event type FAN_OPEN_EXEC_PERM
Date: Thu, 18 Oct 2018 22:55:55 +1100 [thread overview]
Message-ID: <20181018115553.GA3620@workstation> (raw)
In-Reply-To: <20181018092620.GM23493@quack2.suse.cz>
On Thu, Oct 18, 2018 at 11:26:20AM +0200, Jan Kara wrote:
> On Wed 17-10-18 20:05:37, Matthew Bobrowski wrote:
> > diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
> > index 329ac6684326..96616651220c 100644
> > --- a/include/linux/fsnotify_backend.h
> > +++ b/include/linux/fsnotify_backend.h
> > @@ -44,8 +44,9 @@
> > #define FS_Q_OVERFLOW 0x00004000 /* Event queued overflowed */
> > #define FS_IN_IGNORED 0x00008000 /* last inotify event here */
> >
> > -#define FS_OPEN_PERM 0x00010000 /* open event in an permission hook */
> > +#define FS_OPEN_PERM 0x00010000 /* open event in a permission hook */
>
> This hunk would belong to patch 1 instead of this one.
Strange and totally agree. I'm quite perplexed as to why this came through
in like this in this particular patch. Something really weird must've
happened when I was "amending" previously recommended updates.
>
> > #define FS_ACCESS_PERM 0x00020000 /* access event in a permissions hook */
> > +#define FS_OPEN_EXEC_PERM 0x00040000 /* open/exec in a permission hook */
> >
> > #define FS_EXCL_UNLINK 0x04000000 /* do not send events if object is unlinked */
> > #define FS_ISDIR 0x40000000 /* event occurred against dir */
> > @@ -64,7 +65,7 @@
> > FS_CLOSE_WRITE | FS_CLOSE_NOWRITE | FS_OPEN |\
> > FS_MOVED_FROM | FS_MOVED_TO | FS_CREATE |\
> > FS_DELETE | FS_OPEN_PERM | FS_ACCESS_PERM |\
> > - FS_OPEN_EXEC)
> > + FS_OPEN_EXEC | FS_OPEN_EXEC_PERM)
> >
> > #define FS_MOVE (FS_MOVED_FROM | FS_MOVED_TO)
> >
>
> You seem to be missing an update of ALL_FSNOTIFY_PERM_EVENTS to also
> include FS_OPEN_EXEC_PERM.
Oh, yep! Thanks for pointing that out.
> Otherwise the patch looks good to me.
:-)
--
Matthew Bobrowski <mbobrowski@mbobrowski.org>
next prev parent reply other threads:[~2018-10-18 19:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:04 [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Matthew Bobrowski
2018-10-17 9:05 ` [PATCH v5 1/3] fanotify: introduce new event type FAN_OPEN_EXEC Matthew Bobrowski
2018-10-17 9:05 ` [PATCH v5 2/3] fanotify: return only user requested event types in event mask Matthew Bobrowski
2018-10-17 9:05 ` [PATCH v5 3/3] fanotify: introduce new event type FAN_OPEN_EXEC_PERM Matthew Bobrowski
2018-10-18 9:26 ` Jan Kara
2018-10-18 11:55 ` Matthew Bobrowski [this message]
2018-10-18 9:28 ` [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Jan Kara
2018-10-18 12:06 ` Matthew Bobrowski
2018-10-18 12:48 ` Jan Kara
2018-10-24 4:52 ` Matthew Bobrowski
2018-10-18 10:07 ` Amir Goldstein
2018-10-18 12:12 ` Matthew Bobrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018115553.GA3620@workstation \
--to=mbobrowski@mbobrowski.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.