From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 08/11] drm/i915: reorganize the error
 message for invalid watermarks
Date: Thu, 18 Oct 2018 16:55:52 +0300
Message-ID: <20181018135552.GC9144@intel.com>
References: <20181016220133.26991-1-paulo.r.zanoni@intel.com>
 <20181016220133.26991-9-paulo.r.zanoni@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id EDEC58957D
 for <intel-gfx@lists.freedesktop.org>; Thu, 18 Oct 2018 13:57:27 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181016220133.26991-9-paulo.r.zanoni@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDM6MDE6MzBQTSAtMDcwMCwgUGF1bG8gWmFub25pIHdy
b3RlOgo+IFByaW50IGEgbW9yZSBnZW5lcmljICJmYWlsZWQgdG8gY29tcHV0ZSB3YXRlcm1hcmsg
bGV2ZWxzIiB3aGVuZXZlciBhbnkKPiBvZiBza2xfY29tcHV0ZV93bV9sZXZlbHMoKSBmYWlsLCBh
bmQgcHJpbnQgb25seSB0aGUgc3BlY2lmaWMgZXJyb3IKPiBtZXNzYWdlIGZvciB0aGUgc3BlY2lm
aWMgY2FzZXMuIFRoaXMgYWxsb3dzIHVzIHRvIHN0b3AgcGFzc2luZyBwc3RhdGUKPiBldmVyeXdo
ZXJlLCBtYWtpbmcgdGhlIHdhdGVybWFya3MgY29tcHV0YXRpb24gY29kZSBhIGxpdHRsZSBsZXNz
Cj4gZGVwZW5kZW50IG9uIHJhbmRvbSBpbnRlbCBzdGF0ZSBzdHJ1Y3RzLgoKTm90aGluZyByYW5k
b20gYWJvdXQgdGhvc2Ugc3RydWN0cy4gVGhleSBhcmUgKnRoZSogc3RhdGUuClVzaW5nIHRoZW0g
ZGlyZWN0bHkgcmF0aGVyIHRoYW4gZHVwbGljYXRpbmcgaW5mb3JtYXRpb25hIGluIHRoZQp3bV9w
YXJhbXMgc3RydWN0IHdvdWxkIHByb2JhYmx5IG1ha2UgdGhlIGNvZGUgbG9vayBhIGJpdCBsZXNz
IGFsaWVuLgoKQnV0IGdpdmVuIHRoYXQgdGhlIGluZm9ybWF0aW9uIGlzIGR1cGxpY2F0ZWQgSSBn
dWVzcyB3ZSBkb24ndCBoYXZlIHRvCnBhc3MgaW4gdGhlIHBsYW5lIHN0YXRlLiBTbyB0aGUgcGF0
Y2ggc2VlbXMgZmluZSBpbiB0aGF0IHNlbnNlLgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzD
pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBh
dWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgMjcgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4g
IDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCA0MDUzZjRhNjg2NTcuLjEyOTBlZmM2NDg2OSAx
MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC00NjM1LDEzICs0NjM1LDExIEBAIHNr
bF9jb21wdXRlX3BsYW5lX3dtX3BhcmFtcyhjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYsCj4gIAo+ICBzdGF0aWMgaW50IHNrbF9jb21wdXRlX3BsYW5lX3dtKGNvbnN0IHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCXN0cnVjdCBpbnRlbF9jcnRj
X3N0YXRlICpjc3RhdGUsCj4gLQkJCQljb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKmlu
dGVsX3BzdGF0ZSwKPiAgCQkJCWludCBsZXZlbCwKPiAgCQkJCWNvbnN0IHN0cnVjdCBza2xfd21f
cGFyYW1zICp3cCwKPiAgCQkJCWNvbnN0IHN0cnVjdCBza2xfd21fbGV2ZWwgKnJlc3VsdF9wcmV2
LAo+ICAJCQkJc3RydWN0IHNrbF93bV9sZXZlbCAqcmVzdWx0IC8qIG91dCAqLykKPiAgewo+IC0J
Y29uc3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcHN0YXRlID0gJmludGVsX3BzdGF0ZS0+YmFz
ZTsKPiAgCXVpbnQzMl90IGxhdGVuY3kgPSBkZXZfcHJpdi0+d20uc2tsX2xhdGVuY3lbbGV2ZWxd
Owo+ICAJdWludF9maXhlZF8xNl8xNl90IG1ldGhvZDEsIG1ldGhvZDI7Cj4gIAl1aW50X2ZpeGVk
XzE2XzE2X3Qgc2VsZWN0ZWRfcmVzdWx0Owo+IEBAIC00NzYzLDExICs0NzYxLDcgQEAgc3RhdGlj
IGludCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYsCj4gIAkJaWYgKGxldmVsKSB7Cj4gIAkJCXJldHVybiAwOwo+ICAJCX0gZWxzZSB7
Cj4gLQkJCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gcHN0YXRlLT5wbGFuZTsKPiAtCj4gLQkJ
CURSTV9ERUJVR19LTVMoIlJlcXVlc3RlZCBkaXNwbGF5IGNvbmZpZ3VyYXRpb24gZXhjZWVkcyBz
eXN0ZW0gd2F0ZXJtYXJrIGxpbWl0YXRpb25zXG4iKTsKPiAtCQkJRFJNX0RFQlVHX0tNUygiW1BM
QU5FOiVkOiVzXSBibG9ja3MgcmVxdWlyZWQgPSAldS8ldSwgbGluZXMgcmVxdWlyZWQgPSAldS8z
MVxuIiwKPiAtCQkJCSAgICAgIHBsYW5lLT5iYXNlLmlkLCBwbGFuZS0+bmFtZSwKPiArCQkJRFJN
X0RFQlVHX0tNUygiUmVxdWVzdGVkIGRpc3BsYXkgY29uZmlndXJhdGlvbiBleGNlZWRzIHN5c3Rl
bSB3YXRlcm1hcmsgbGltaXRhdGlvbnM6IGJsb2NrcyByZXF1aXJlZCA9ICV1LyV1LCBsaW5lcyBy
ZXF1aXJlZCA9ICV1LzMxXG4iLAo+ICAJCQkJICAgICAgcmVzX2Jsb2Nrcywgd3AtPmRkYl9ibG9j
a3MsIHJlc19saW5lcyk7Cj4gIAkJCXJldHVybiAtRUlOVkFMOwo+ICAJCX0KPiBAQCAtNDc5NSw3
ICs0Nzg5LDYgQEAgc3RhdGljIGludCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHN0YXRpYyBpbnQKPiAgc2tsX2NvbXB1dGVf
d21fbGV2ZWxzKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkg
ICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+IC0JCSAgICAgIGNvbnN0IHN0
cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfcHN0YXRlLAo+ICAJCSAgICAgIGNvbnN0IHN0
cnVjdCBza2xfd21fcGFyYW1zICp3bV9wYXJhbXMsCj4gIAkJICAgICAgc3RydWN0IHNrbF9wbGFu
ZV93bSAqd20sCj4gIAkJICAgICAgaW50IHBsYW5lX2lkKQo+IEBAIC00ODE2LDcgKzQ4MDksNiBA
QCBza2xfY29tcHV0ZV93bV9sZXZlbHMoY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ICAKPiAgCQlyZXQgPSBza2xfY29tcHV0ZV9wbGFuZV93bShkZXZfcHJpdiwKPiAg
CQkJCQkgICBjc3RhdGUsCj4gLQkJCQkJICAgaW50ZWxfcHN0YXRlLAo+ICAJCQkJCSAgIGxldmVs
LAo+ICAJCQkJCSAgIHdtX3BhcmFtcywKPiAgCQkJCQkgICByZXN1bHRfcHJldiwKPiBAQCAtNDk1
MSwxMCArNDk0MywxMyBAQCBzdGF0aWMgaW50IHNrbF9idWlsZF9waXBlX3dtKHN0cnVjdCBpbnRl
bF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkJaWYgKCF3bV9wYXJhbXMucGxhbmVfdmlzaWJsZSkK
PiAgCQkJY29udGludWU7Cj4gIAo+IC0JCXJldCA9IHNrbF9jb21wdXRlX3dtX2xldmVscyhkZXZf
cHJpdiwgY3N0YXRlLAo+IC0JCQkJCSAgICBpbnRlbF9wc3RhdGUsICZ3bV9wYXJhbXMsIHdtLCAw
KTsKPiAtCQlpZiAocmV0KQo+ICsJCXJldCA9IHNrbF9jb21wdXRlX3dtX2xldmVscyhkZXZfcHJp
diwgY3N0YXRlLCAmd21fcGFyYW1zLCB3bSwKPiArCQkJCQkgICAgMCk7Cj4gKwkJaWYgKHJldCkg
ewo+ICsJCQlEUk1fREVCVUdfS01TKCJbUExBTkU6JWQ6JXNdIGZhaWxlZCB0byBjb21wdXRlIHdh
dGVybWFyayBsZXZlbHNcbiIsCj4gKwkJCQkgICAgICBwbGFuZS0+YmFzZS5pZCwgcGxhbmUtPm5h
bWUpOwo+ICAJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiAgCj4gIAkJc2tsX2NvbXB1dGVfdHJhbnNp
dGlvbl93bShjc3RhdGUsICZ3bV9wYXJhbXMsICZ3bS0+d21bMF0sCj4gIAkJCQkJICAmd20tPnRy
YW5zX3dtKTsKPiBAQCAtNDk2OCwxMCArNDk2MywxMiBAQCBzdGF0aWMgaW50IHNrbF9idWlsZF9w
aXBlX3dtKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkJCQlyZXR1cm4gcmV0
Owo+ICAKPiAgCQkJcmV0ID0gc2tsX2NvbXB1dGVfd21fbGV2ZWxzKGRldl9wcml2LCBjc3RhdGUs
Cj4gLQkJCQkJCSAgICBpbnRlbF9wc3RhdGUsICZ3bV9wYXJhbXMsCj4gLQkJCQkJCSAgICB3bSwg
MSk7Cj4gLQkJCWlmIChyZXQpCj4gKwkJCQkJCSAgICAmd21fcGFyYW1zLCB3bSwgMSk7Cj4gKwkJ
CWlmIChyZXQpIHsKPiArCQkJCURSTV9ERUJVR19LTVMoIltQTEFORTolZDolc10gZmFpbGVkIHRv
IGNvbXB1dGUgcGxhbmFyIHdhdGVybWFyayBsZXZlbHNcbiIsCj4gKwkJCQkJICAgICAgcGxhbmUt
PmJhc2UuaWQsIHBsYW5lLT5uYW1lKTsKPiAgCQkJCXJldHVybiByZXQ7Cj4gKwkJCX0KPiAgCQl9
Cj4gIAl9Cj4gIAo+IC0tIAo+IDIuMTQuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdm
eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t
YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK