From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas Date: Thu, 18 Oct 2018 20:02:56 +0300 Message-ID: <20181018170256.GR9144@intel.com> References: <20181016150413.11577-1-ville.syrjala@linux.intel.com> <68e4830a-42fa-b6a3-901f-7f23467de43f@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 98B246E046 for ; Thu, 18 Oct 2018 17:03:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <68e4830a-42fa-b6a3-901f-7f23467de43f@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTgsIDIwMTggYXQgMDM6NTI6MjdQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMTYvMTAvMjAxOCAxNjowNCwgVmlsbGUgU3lyamFsYSB3cm90ZToKPiA+ IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiAKPiA+IFJlcGxhY2UgdGhlIGt2bWFsbG9jX2FycmF5KCkgd2l0aCBpOTE1X2dlbV9vYmplY3Rf Z2V0X2RtYV9hZGRyZXNzKCkgd2hlbgo+ID4gcG9wdWxhdGluZyByb3RhdGVkIHZtYXMuIE9uZSBy YW5kb20gYWNjZXNzIG1lY2hhbmlzbSBvdWdodCB0byBiZSBlbm91Z2gKPiA+IGZvciBldmVyeW9u ZT8KPiA+IAo+ID4gVG8gY2FsY3VsYXRlIHRoZSBzaXplIG9mIHRoZSByYWRpeCB0cmVlIEkgdGhp bmsgd2UgY2FuIGRvCj4gPiBzb21ldGhpbmcgbGlrZSB0aGlzIChhc3N1bWluZyA2NGJpdCBwb2lu dGVycyk6Cj4gPiAgIG51bV9wYWdlcyA9IG9ial9zaXplIC8gNDA5Ngo+ID4gICB0cmVlX2hlaWdo dCA9IGNlaWwobG9nNjQobnVtX3BhZ2VzKSkKPiA+ICAgbnVtX25vZGVzID0gc3VtKDY0Xm4sIG4s IDAsIHRyZWVfaGVpZ2h0LTEpCj4gPiAgIHRyZWVfc2l6ZSA9IG51bV9ub2RlcyAqIDU3Ngo+ID4g Cj4gPiBJZiB3ZSBjb21wYXJlIHRoYXQgd2l0aCB0aGUgb2JqZWN0IHNpemUgd2Ugc2hvdWxkIGdl dCBhIHJlbGF0aXZlCj4gPiBvdmVyaGVhZCBvZiBhcm91bmQgLjIlIHRvIDElIGZvciByZWFzb25h YmxlIHNpemVkIG9iamVjdHMsCj4gPiB3aGljaCBmcmFtZWJ1ZmZlcnMgdGVuZCB0byBiZS4KPiA+ IAo+ID4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gPiBTdWdn ZXN0ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gU2ln bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyB8IDMx ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuYwo+ID4gaW5kZXggMjljYTkwMDdhNzA0Li45OGQ5YTFlYjFlZDIgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiA+IEBAIC0zNjM3LDcgKzM2MzcsNyBA QCB2b2lkIGk5MTVfZ2VtX3Jlc3RvcmVfZ3R0X21hcHBpbmdzKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiA+ICAgfQo+ID4gICAKPiA+ICAgc3RhdGljIHN0cnVjdCBzY2F0dGVy bGlzdCAqCj4gPiAtcm90YXRlX3BhZ2VzKGNvbnN0IGRtYV9hZGRyX3QgKmluLCB1bnNpZ25lZCBp bnQgb2Zmc2V0LAo+ID4gK3JvdGF0ZV9wYWdlcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LAo+ID4gICAJICAgICB1bnNpZ25lZCBpbnQgd2lkdGgs IHVuc2lnbmVkIGludCBoZWlnaHQsCj4gPiAgIAkgICAgIHVuc2lnbmVkIGludCBzdHJpZGUsCj4g PiAgIAkgICAgIHN0cnVjdCBzZ190YWJsZSAqc3QsIHN0cnVjdCBzY2F0dGVybGlzdCAqc2cpCj4g PiBAQCAtMzY0Niw3ICszNjQ2LDcgQEAgcm90YXRlX3BhZ2VzKGNvbnN0IGRtYV9hZGRyX3QgKmlu LCB1bnNpZ25lZCBpbnQgb2Zmc2V0LAo+ID4gICAJdW5zaWduZWQgaW50IHNyY19pZHg7Cj4gPiAg IAo+ID4gICAJZm9yIChjb2x1bW4gPSAwOyBjb2x1bW4gPCB3aWR0aDsgY29sdW1uKyspIHsKPiA+ IC0JCXNyY19pZHggPSBzdHJpZGUgKiAoaGVpZ2h0IC0gMSkgKyBjb2x1bW47Cj4gPiArCQlzcmNf aWR4ID0gc3RyaWRlICogKGhlaWdodCAtIDEpICsgY29sdW1uICsgb2Zmc2V0Owo+ID4gICAJCWZv ciAocm93ID0gMDsgcm93IDwgaGVpZ2h0OyByb3crKykgewo+ID4gICAJCQlzdC0+bmVudHMrKzsK PiA+ICAgCQkJLyogV2UgZG9uJ3QgbmVlZCB0aGUgcGFnZXMsIGJ1dCBuZWVkIHRvIGluaXRpYWxp emUKPiA+IEBAIC0zNjU0LDcgKzM2NTQsOCBAQCByb3RhdGVfcGFnZXMoY29uc3QgZG1hX2FkZHJf dCAqaW4sIHVuc2lnbmVkIGludCBvZmZzZXQsCj4gPiAgIAkJCSAqIFRoZSBvbmx5IHRoaW5nIHdl IG5lZWQgYXJlIERNQSBhZGRyZXNzZXMuCj4gPiAgIAkJCSAqLwo+ID4gICAJCQlzZ19zZXRfcGFn ZShzZywgTlVMTCwgSTkxNV9HVFRfUEFHRV9TSVpFLCAwKTsKPiA+IC0JCQlzZ19kbWFfYWRkcmVz cyhzZykgPSBpbltvZmZzZXQgKyBzcmNfaWR4XTsKPiA+ICsJCQlzZ19kbWFfYWRkcmVzcyhzZykg PQo+ID4gKwkJCQlpOTE1X2dlbV9vYmplY3RfZ2V0X2RtYV9hZGRyZXNzKG9iaiwgc3JjX2lkeCk7 Cj4gPiAgIAkJCXNnX2RtYV9sZW4oc2cpID0gSTkxNV9HVFRfUEFHRV9TSVpFOwo+ID4gICAJCQlz ZyA9IHNnX25leHQoc2cpOwo+ID4gICAJCQlzcmNfaWR4IC09IHN0cmlkZTsKPiA+IEBAIC0zNjY4 LDIyICszNjY5LDExIEBAIHN0YXRpYyBub2lubGluZSBzdHJ1Y3Qgc2dfdGFibGUgKgo+ID4gICBp bnRlbF9yb3RhdGVfcGFnZXMoc3RydWN0IGludGVsX3JvdGF0aW9uX2luZm8gKnJvdF9pbmZvLAo+ ID4gICAJCSAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gPiAgIHsKPiA+IC0J Y29uc3QgdW5zaWduZWQgbG9uZyBuX3BhZ2VzID0gb2JqLT5iYXNlLnNpemUgLyBJOTE1X0dUVF9Q QUdFX1NJWkU7Cj4gPiAgIAl1bnNpZ25lZCBpbnQgc2l6ZSA9IGludGVsX3JvdGF0aW9uX2luZm9f c2l6ZShyb3RfaW5mbyk7Cj4gPiAtCXN0cnVjdCBzZ3RfaXRlciBzZ3RfaXRlcjsKPiA+IC0JZG1h X2FkZHJfdCBkbWFfYWRkcjsKPiA+IC0JdW5zaWduZWQgbG9uZyBpOwo+ID4gLQlkbWFfYWRkcl90 ICpwYWdlX2FkZHJfbGlzdDsKPiA+ICAgCXN0cnVjdCBzZ190YWJsZSAqc3Q7Cj4gPiAgIAlzdHJ1 Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+ID4gICAJaW50IHJldCA9IC1FTk9NRU07Cj4gPiAtCj4gPiAt CS8qIEFsbG9jYXRlIGEgdGVtcG9yYXJ5IGxpc3Qgb2Ygc291cmNlIHBhZ2VzIGZvciByYW5kb20g YWNjZXNzLiAqLwo+ID4gLQlwYWdlX2FkZHJfbGlzdCA9IGt2bWFsbG9jX2FycmF5KG5fcGFnZXMs Cj4gPiAtCQkJCQlzaXplb2YoZG1hX2FkZHJfdCksCj4gPiAtCQkJCQlHRlBfS0VSTkVMKTsKPiA+ IC0JaWYgKCFwYWdlX2FkZHJfbGlzdCkKPiA+IC0JCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gPiAr CWludCBpOwo+ID4gICAKPiA+ICAgCS8qIEFsbG9jYXRlIHRhcmdldCBTRyBsaXN0LiAqLwo+ID4g ICAJc3QgPSBrbWFsbG9jKHNpemVvZigqc3QpLCBHRlBfS0VSTkVMKTsKPiA+IEBAIC0zNjk0LDI5 ICszNjg0LDIwIEBAIGludGVsX3JvdGF0ZV9wYWdlcyhzdHJ1Y3QgaW50ZWxfcm90YXRpb25faW5m byAqcm90X2luZm8sCj4gPiAgIAlpZiAocmV0KQo+ID4gICAJCWdvdG8gZXJyX3NnX2FsbG9jOwo+ ID4gICAKPiA+IC0JLyogUG9wdWxhdGUgc291cmNlIHBhZ2UgbGlzdCBmcm9tIHRoZSBvYmplY3Qu ICovCj4gPiAtCWkgPSAwOwo+ID4gLQlmb3JfZWFjaF9zZ3RfZG1hKGRtYV9hZGRyLCBzZ3RfaXRl ciwgb2JqLT5tbS5wYWdlcykKPiA+IC0JCXBhZ2VfYWRkcl9saXN0W2krK10gPSBkbWFfYWRkcjsK PiA+IC0KPiA+IC0JR0VNX0JVR19PTihpICE9IG5fcGFnZXMpOwo+ID4gICAJc3QtPm5lbnRzID0g MDsKPiA+ICAgCXNnID0gc3QtPnNnbDsKPiA+ICAgCj4gPiAgIAlmb3IgKGkgPSAwIDsgaSA8IEFS UkFZX1NJWkUocm90X2luZm8tPnBsYW5lKTsgaSsrKSB7Cj4gPiAtCQlzZyA9IHJvdGF0ZV9wYWdl cyhwYWdlX2FkZHJfbGlzdCwgcm90X2luZm8tPnBsYW5lW2ldLm9mZnNldCwKPiA+ICsJCXNnID0g cm90YXRlX3BhZ2VzKG9iaiwgcm90X2luZm8tPnBsYW5lW2ldLm9mZnNldCwKPiA+ICAgCQkJCSAg cm90X2luZm8tPnBsYW5lW2ldLndpZHRoLCByb3RfaW5mby0+cGxhbmVbaV0uaGVpZ2h0LAo+ID4g ICAJCQkJICByb3RfaW5mby0+cGxhbmVbaV0uc3RyaWRlLCBzdCwgc2cpOwo+ID4gICAJfQo+ID4g ICAKPiA+IC0Ja3ZmcmVlKHBhZ2VfYWRkcl9saXN0KTsKPiA+IC0KPiA+ICAgCXJldHVybiBzdDsK PiA+ICAgCj4gPiAgIGVycl9zZ19hbGxvYzoKPiA+ICAgCWtmcmVlKHN0KTsKPiA+ICAgZXJyX3N0 X2FsbG9jOgo+ID4gLQlrdmZyZWUocGFnZV9hZGRyX2xpc3QpOwo+ID4gICAKPiA+ICAgCURSTV9E RUJVR19EUklWRVIoIkZhaWxlZCB0byBjcmVhdGUgcm90YXRlZCBtYXBwaW5nIGZvciBvYmplY3Qg c2l6ZSAlenUhICgldXgldSB0aWxlcywgJXUgcGFnZXMpXG4iLAo+ID4gICAJCQkgb2JqLT5iYXNl LnNpemUsIHJvdF9pbmZvLT5wbGFuZVswXS53aWR0aCwgcm90X2luZm8tPnBsYW5lWzBdLmhlaWdo dCwgc2l6ZSk7Cj4gPiAKPiAKPiBSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPiAKPiBBbmQgYXBvbG9naWVzIGZvciB0aGUgZGVsYXkuIFByZXZp b3VzbHkgSSB3YXMgY2VydGFpbiB0aGUgY2FjaGUgc2l6ZSAKPiB3b3VsZCB0eXBpY2FsbHkgYmUg bXVjaCBiaWdnZXIuIFBlcmhhcHMgSSBtZWFzdXJlZCBpbmNvcnJlY3RseSBiYWNrIAo+IHRoZW4s IG9yIHNvbWV0aGluZy4uLgoKTm8gd29ycmllcy4gUGF0Y2ggcHVzaGVkIHRvIGRpbnEuIFRoYW5r cyBmb3IgdGhlIHJldmlldy4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==