From: Sam Ravnborg <sam@ravnborg.org>
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: seanpaul@chromium.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
abhinavk@codeaurora.org
Subject: Re: [PATCH 06/11] drm/msm/dpu: Cleanup callers of dpu_hw_blk_init
Date: Thu, 18 Oct 2018 23:53:59 +0200 [thread overview]
Message-ID: <20181018215359.GA5328@ravnborg.org> (raw)
In-Reply-To: <20181018195836.15885-7-jcrouse@codeaurora.org>
Hi Jordan.
On Thu, Oct 18, 2018 at 01:58:31PM -0600, Jordan Crouse wrote:
> Outside of superfluous parameter checks the dpu_hw_blk_init()
> doesn't have any failure paths. Switch it over to be a void
> function and we can remove error handling paths in all the functions
> that call it. While we're in those functions remove unneeded
> initialization for a static variable.
I like the simplification resulting after removing the
error handling.
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
> index 200cd874b683..27699000aaca 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
> @@ -61,11 +61,6 @@ struct dpu_hw_lm_ops {
> void (*setup_border_color)(struct dpu_hw_mixer *ctx,
> struct dpu_mdss_color *color,
> u8 border_en);
> - /**
> - * setup_gc : enable/disable gamma correction feature
> - */
> - void (*setup_gc)(struct dpu_hw_mixer *mixer,
> - void *cfg);
> };
>
> struct dpu_hw_mixer {
This part looks like it do not belong in this patch.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-18 21:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 19:58 [PATCH 00/11] DPU cleanups Jordan Crouse
[not found] ` <20181018195836.15885-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-18 19:58 ` [PATCH 01/11] drm/msm/dpu: Remove dpu_dbg Jordan Crouse
[not found] ` <20181018195836.15885-2-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-19 17:34 ` Bruce Wang
2018-10-19 18:11 ` Bruce Wang
[not found] ` <CAA3FfWU-KB=VCmrkriO8M1zdPg9FGO_bii7qjbzGXupapJFF9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-19 19:59 ` Jordan Crouse
2018-10-18 19:58 ` [PATCH 02/11] drm/msm/dpu: Use DEFINE_SHOW_ATTRIBUTE Jordan Crouse
[not found] ` <20181018195836.15885-3-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-18 21:43 ` Bruce Wang
2018-10-18 19:58 ` [PATCH 03/11] drm/msm/dpu: Remove dpu_crtc_get_mixer_height Jordan Crouse
[not found] ` <20181018195836.15885-4-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-18 21:44 ` Bruce Wang
2018-10-18 19:58 ` [PATCH 04/11] drm/msm/dpu: Remove dpu_crtc_is_enabled() Jordan Crouse
[not found] ` <20181018195836.15885-5-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-18 21:45 ` Bruce Wang
2018-10-18 19:58 ` [PATCH 05/11] drm/msm/dpu: Cleanup some container_of helper functions Jordan Crouse
2018-10-18 21:49 ` Sam Ravnborg
2018-10-18 19:58 ` [PATCH 06/11] drm/msm/dpu: Cleanup callers of dpu_hw_blk_init Jordan Crouse
2018-10-18 21:53 ` Sam Ravnborg [this message]
[not found] ` <20181018215359.GA5328-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2018-10-19 17:13 ` Jordan Crouse
2018-10-18 19:58 ` [PATCH 07/11] drm/msm: Make irq_postinstall optional Jordan Crouse
[not found] ` <20181018195836.15885-8-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-19 13:56 ` Bruce Wang
2018-10-18 19:58 ` [PATCH 08/11] drm/msm/dpu: Remove dpu_irq and unused functions Jordan Crouse
[not found] ` <20181018195836.15885-9-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-19 14:56 ` Bruce Wang
2018-10-18 19:58 ` [PATCH 09/11] drm/msm/dpu: Debugfs related cleanups Jordan Crouse
[not found] ` <20181018195836.15885-10-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-22 15:45 ` Bruce Wang
2018-10-18 19:58 ` [PATCH 10/11] drm/msm/dpu: Further cleanups for static inline functions Jordan Crouse
2018-10-18 22:06 ` Sam Ravnborg
[not found] ` <20181018220620.GB5328-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2018-10-19 17:09 ` Jordan Crouse
2018-10-18 19:58 ` [PATCH 11/11] drm/msm/dpu: Clean up dpu_media_info.h " Jordan Crouse
[not found] ` <20181018195836.15885-12-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-19 15:10 ` Bruce Wang
-- strict thread matches above, loose matches on Subject: below --
2018-11-05 23:30 [PATCH v2 00/11] DPU cleanups Jordan Crouse
[not found] ` <20181105233103.7657-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-05 23:30 ` [PATCH 06/11] drm/msm/dpu: Cleanup callers of dpu_hw_blk_init Jordan Crouse
[not found] ` <20181105233103.7657-7-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 14:45 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018215359.GA5328@ravnborg.org \
--to=sam@ravnborg.org \
--cc=abhinavk@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.