All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-pci@vger.kernel.org,
	Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type
Date: Thu, 18 Oct 2018 17:28:04 -0600	[thread overview]
Message-ID: <20181018232804.GA23571@localhost.localdomain> (raw)
In-Reply-To: <201810190748.HGswAA5P%fengguang.wu@intel.com>

On Fri, Oct 19, 2018 at 07:18:52AM +0800, kbuild test robot wrote:
>    drivers/pci/pcie/aer.c: In function 'aer_probe':
> >> drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>      struct device *device = &dev->port->device;
>                              ^
>    cc1: some warnings being treated as errors
> 
> vim +1387 drivers/pci/pcie/aer.c
> 
>   1376	
>   1377	/**
>   1378	 * aer_probe - initialize resources
>   1379	 * @dev: pointer to the pcie_dev data structure
>   1380	 *
>   1381	 * Invoked when PCI Express bus loads AER service driver.
>   1382	 */
>   1383	static int aer_probe(struct pcie_device *dev)
>   1384	{
>   1385		int status;
>   1386		struct aer_rpc *rpc;
> > 1387		struct device *device = &dev->port->device;

You must be building patches incrementally since this was (inadvertently)
fixed by the following commit 09d260ca3ad04d9b4c4d5e8b0fa1e3501b3e3793
("PCI/AER: Use managed resource allocations").

Bjorn,
If you want to replay the history, I quickly rebase the two affected
patches so this intermediate compile breakage doesn't happen. Up to you.

  reply	other threads:[~2018-10-18 23:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 23:18 [pci:pci/hotplug 45/50] drivers/pci/pcie/aer.c:1387:26: error: initialization from incompatible pointer type kbuild test robot
2018-10-18 23:28 ` Keith Busch [this message]
2018-10-19  0:49   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018232804.GA23571@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=helgaas@kernel.org \
    --cc=kbuild-all@01.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.