From: Sinan Kaya <okaya@kernel.org>
To: linux-pci@vger.kernel.org
Cc: Sinan Kaya <okaya@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex.williamson@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Peter Xu <peterx@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: [PATCH v6 6/7] PCI: Expose reset type to users of pci_reset_bus()
Date: Fri, 19 Oct 2018 02:11:26 +0000 [thread overview]
Message-ID: <20181019021132.14743-6-okaya@kernel.org> (raw)
In-Reply-To: <20181019021132.14743-1-okaya@kernel.org>
Looking to have more control between the users of the API vs. what the API
can do internally. The new reset_type tells the PCI core about the bounds
of the request.
pci_reset_bus() calls different slot reset mechanisms based on given mask.
Slot based reset is prioritized over bus reset.
Users are expected to use PCI_RESET_SLOT mask by default.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/pci/pci.c | 12 +++++++++---
drivers/vfio/pci/vfio_pci.c | 6 ++++--
include/linux/pci.h | 2 +-
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index a1a7dd6988be..1feecbb7f85d 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -5236,13 +5236,19 @@ static int __pci_reset_bus(struct pci_bus *bus)
/**
* pci_reset_bus - Try to reset a PCI bus
* @pdev: top level PCI device to reset via slot/bus
+ * @reset_type: resets to try
*
* Same as above except return -EAGAIN if the bus cannot be locked
*/
-int pci_reset_bus(struct pci_dev *pdev)
+int pci_reset_bus(struct pci_dev *pdev, u32 reset_type)
{
- return (!pci_probe_reset_slot(pdev->slot)) ?
- __pci_reset_slot(pdev->slot) : __pci_reset_bus(pdev->bus);
+ if ((reset_type & PCI_RESET_SLOT) && !pci_probe_reset_slot(pdev->slot))
+ return __pci_reset_slot(pdev->slot);
+
+ if ((reset_type & PCI_RESET_BUS) && !pci_probe_reset_bus(pdev->bus))
+ return __pci_reset_bus(pdev->bus);
+
+ return -EINVAL;
}
EXPORT_SYMBOL_GPL(pci_reset_bus);
diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index fe7ada997c51..0e80c72b1eaa 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -1015,7 +1015,8 @@ static long vfio_pci_ioctl(void *device_data,
&info, slot);
if (!ret)
/* User has access, do the reset */
- ret = pci_reset_bus(vdev->pdev);
+ ret = pci_reset_bus(vdev->pdev,
+ slot ? PCI_RESET_SLOT : PCI_RESET_BUS);
hot_reset_release:
for (i--; i >= 0; i--)
@@ -1390,7 +1391,8 @@ static void vfio_pci_try_bus_reset(struct vfio_pci_device *vdev)
}
if (needs_reset)
- ret = pci_reset_bus(vdev->pdev);
+ ret = pci_reset_bus(vdev->pdev,
+ slot ? PCI_RESET_SLOT : PCI_RESET_BUS);
put_devs:
for (i = 0; i < devs.cur_index; i++) {
diff --git a/include/linux/pci.h b/include/linux/pci.h
index cde63e0a85ea..8ee4e3c177fe 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1173,7 +1173,7 @@ int pci_reset_function_locked(struct pci_dev *dev, u32 reset_type);
int pci_try_reset_function(struct pci_dev *dev, u32 reset_type);
int pci_probe_reset_slot(struct pci_slot *slot);
int pci_probe_reset_bus(struct pci_bus *bus);
-int pci_reset_bus(struct pci_dev *dev);
+int pci_reset_bus(struct pci_dev *dev, u32 reset_type);
void pci_reset_secondary_bus(struct pci_dev *dev);
void pcibios_reset_secondary_bus(struct pci_dev *dev);
void pci_update_resource(struct pci_dev *dev, int resno);
--
2.19.0
next prev parent reply other threads:[~2018-10-19 2:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 2:11 [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked() Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 2/7] PCI: Expose reset_type to users of pci_reset_function() Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 3/7] PCI: Expose reset_type to users of pci_reset_function_locked() Sinan Kaya
2018-10-19 20:20 ` Bjorn Helgaas
2018-10-19 22:18 ` Sinan Kaya
2018-10-19 2:11 ` [PATCH v6 4/7] PCI: Expose reset type to users of pci_try_reset_function() Sinan Kaya
2018-10-19 20:14 ` Bjorn Helgaas
2018-10-19 20:21 ` Brian Norris
2018-10-19 2:11 ` [PATCH v6 5/7] PCI: Expose reset type to users of pci_probe_reset_function() Sinan Kaya
2018-10-19 2:11 ` Sinan Kaya [this message]
2018-10-19 2:11 ` [PATCH v6 7/7] IB/hfi1,PCI: switch to __pci_function_locked() for reset request Sinan Kaya
2018-10-19 13:10 ` Doug Ledford
2018-10-20 2:09 ` [PATCH v6 1/7] PCI: Expose reset_type to users of __pci_reset_function_locked() Bjorn Helgaas
2018-10-20 2:58 ` Sinan Kaya
2018-10-20 15:03 ` Bjorn Helgaas
2018-10-20 16:21 ` Sinan Kaya
2018-11-08 20:31 ` Alex Williamson
2018-11-08 21:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019021132.14743-6-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=gustavo@embeddedor.com \
--cc=linux-pci@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.