From: Borislav Petkov <bp@alien8.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "Leonardo Brás" <leobras.c@gmail.com>,
lkcamp@lists.libreplanetbr.org,
"Matthew Wilcox" <willy6545@gmail.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, "X86 ML" <x86@kernel.org>,
"Michal Marek" <michal.lkml@markovi.net>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS
Date: Fri, 19 Oct 2018 10:08:53 +0200 [thread overview]
Message-ID: <20181019080853.GA28610@zn.tnic> (raw)
In-Reply-To: <CAK7LNAQhbn-qZg_Bywk8rf0+oZhVbDjJ=PtcKGCL+k4Fp-ijSw@mail.gmail.com>
On Fri, Oct 19, 2018 at 11:41:31AM +0900, Masahiro Yamada wrote:
> Adding -Wshadow to KBUILD_HOSTCFLAGS emits another warning in Kconfig.
> Of course, it is easy to fix.
> But, I just started to think this option is a kind of harsh...
What is more, if we added -Wshadow to KBUILD_HOSTCFLAGS, then there'll
be a difference in build options between host and target kernel in that
the host kernel build will be stricter wrt shadowing. Thus, it is a
maintainer decision, IMHO.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-10-19 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 0:08 [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS Leonardo Brás
2018-10-17 4:32 ` [Lkcamp] " Helen Koike
2018-10-17 23:18 ` Leonardo Bras
2018-10-17 8:11 ` Borislav Petkov
2018-10-17 8:21 ` Masahiro Yamada
2018-10-17 8:31 ` Borislav Petkov
2018-10-18 0:40 ` Leonardo Bras
2018-10-18 9:16 ` Borislav Petkov
2018-10-18 16:39 ` Masahiro Yamada
2018-10-18 16:50 ` Borislav Petkov
2018-10-19 2:41 ` Masahiro Yamada
2018-10-19 2:50 ` Leonardo Bras
2018-10-19 8:08 ` Borislav Petkov [this message]
2018-10-19 11:28 ` David Laight
2018-10-28 16:54 ` Masahiro Yamada
2018-10-18 0:36 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019080853.GA28610@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=leobras.c@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=luto@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=willy6545@gmail.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.