All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list
Date: Fri, 19 Oct 2018 12:22:50 +0100	[thread overview]
Message-ID: <20181019112250.GA19474@redhat.com> (raw)
In-Reply-To: <20180823102502.28122-1-berrange@redhat.com>

Copying Paolo, since this probably falls under the "misc patches"
maintainer bucket.

On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote:
> In some cases the Author: email address in patches submitted to the
> list gets mangled such that it says
> 
>     John Doe via Qemu-devel <qemu-devel@nongnu.org>
> 
> This change is a result of workarounds for DMARC policies.
> 
> Subsystem maintainers accepting patches need to catch these and fix
> them before sending pull requests, so a checkpatch.pl test is highly
> desirable.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  scripts/checkpatch.pl | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 42e1c50dd8..be2114a179 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1402,6 +1402,10 @@ sub process {
>  			$is_patch = 1;
>  		}
>  
> +		if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
> +		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
> +		}
> +
>  #check the patch for a signoff:
>  		if ($line =~ /^\s*signed-off-by:/i) {
>  			# This is a signoff, if ugly, so do not double report.
> -- 
> 2.17.1
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  parent reply	other threads:[~2018-10-19 11:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 10:25 [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list Daniel P. Berrangé
2018-08-23 10:33 ` Cornelia Huck
2018-08-23 10:41 ` Peter Maydell
2018-08-23 10:59   ` Daniel P. Berrangé
2018-08-23 16:18   ` Markus Armbruster
2018-08-23 14:07 ` Eric Blake
2018-10-19 11:22 ` Daniel P. Berrangé [this message]
2018-10-19 12:00   ` Paolo Bonzini
2018-10-19 12:13     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019112250.GA19474@redhat.com \
    --to=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.