From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [v2 5/6] i915/dp/fec: Configure the Forward Error Correction bits. Date: Fri, 19 Oct 2018 21:39:11 +0300 Message-ID: <20181019183911.GW9144@intel.com> References: <20181015215037.13901-1-anusha.srivatsa@intel.com> <20181015215037.13901-6-anusha.srivatsa@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30135896EB for ; Fri, 19 Oct 2018 18:39:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181015215037.13901-6-anusha.srivatsa@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anusha Srivatsa Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTUsIDIwMTggYXQgMDI6NTA6MzZQTSAtMDcwMCwgQW51c2hhIFNyaXZhdHNh IHdyb3RlOgo+IElmIEZFQyBpcyBzdXBwb3J0ZWQsIHRoZSBjb3JyZXNwb25kaW5nCj4gRFBfVFBf Q1RMIHJlZ2lzdGVyIGJpdHMgaGF2ZSB0byBiZSBjb25maWd1cmVkLgo+IAo+IFRoZSBkcml2ZXIg aGFzIHRvIHByb2dyYW0gdGhlIEZFQ19FTkFCTEUgaW4gRFBfVFBfQ1RMWzMwXSByZWdpc3Rlcgo+ IGFuZCB3YWl0IHRpbGwgRkVDX1NUQVRVUyBpbiBEUF9UUF9DVExbMjhdIGlzIDEuCj4gQWxzbyBh ZGQgdGhlIHdhcm4gbWVzc2FnZSB0byBtYWtlIHN1cmUgdGhhdCB0aGUgY29udHJvbAo+IHJlZ2lz dGVyIGlzIGFscmVhZHkgYWN0aXZlIHdoaWxlIGVuYWJsaW5nIEZFQy4KPiAKPiB2MjoKPiAtIENo YW5nZSBjb21taXQgbWVzc2FnZS4gQ29uZmlndXJlIGZlYyBzdGF0ZSBhZnRlcgo+ICAgbGluayB0 cmFpbmluZyAoTWFuYXNpLCBHYXVyYXYpCj4gLSBSZW1vdmUgcmVkdW5kZW50IGNoZWNrcyAoTWFu YXNpKQo+IC0gUmVtb3ZlIHRoZSByZWdpc3RlcnMgdGhhdCBnZXQgYWRkZWQgYXV0b21hZ2ljYWxs eSAoQW51c2hhKQo+IAo+IHYzOiBzL2ludGVsX2RwX3NldF9mZWNfc3RhdGUoKS9pbnRlbF9kcF9l bmFibGVfZmVjX3N0YXRlKCkgKEdhdXJhdikKPiAKPiB2NDogcmViYXNlZC4KPiAKPiBDYzogR2F1 cmF2IEsgU2luZ2ggPGdhdXJhdi5rLnNpbmdoQGludGVsLmNvbT4KPiBDYzogSmFuaSBOaWt1bGEg PGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5h dmFyZUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEu c3JpdmF0c2FAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oICB8ICAyICsrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgIDIgKysK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgfCAyNyArKysrKysrKysrKysrKysr KysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggfCAgMyArKy0K PiAgNCBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggYmNkZTc4YmMwMDI3Li5jOGQ3ZmRjZDc4MjMg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtOTA5Myw2ICs5MDkzLDcgQEAgZW51 bSBza2xfcG93ZXJfZ2F0ZSB7Cj4gICNkZWZpbmUgX0RQX1RQX0NUTF9CCQkJMHg2NDE0MAo+ICAj ZGVmaW5lIERQX1RQX0NUTChwb3J0KSBfTU1JT19QT1JUKHBvcnQsIF9EUF9UUF9DVExfQSwgX0RQ X1RQX0NUTF9CKQo+ICAjZGVmaW5lICBEUF9UUF9DVExfRU5BQkxFCQkJKDEgPDwgMzEpCj4gKyNk ZWZpbmUgIERQX1RQX0NUTF9GRUNfRU5BQkxFCQkJKDEgPDwgMzApCj4gICNkZWZpbmUgIERQX1RQ X0NUTF9NT0RFX1NTVAkJCSgwIDw8IDI3KQo+ICAjZGVmaW5lICBEUF9UUF9DVExfTU9ERV9NU1QJ CQkoMSA8PCAyNykKPiAgI2RlZmluZSAgRFBfVFBfQ1RMX0ZPUkNFX0FDVAkJCSgxIDw8IDI1KQo+ IEBAIC05MTExLDYgKzkxMTIsNyBAQCBlbnVtIHNrbF9wb3dlcl9nYXRlIHsKPiAgI2RlZmluZSBf RFBfVFBfU1RBVFVTX0EJCQkweDY0MDQ0Cj4gICNkZWZpbmUgX0RQX1RQX1NUQVRVU19CCQkJMHg2 NDE0NAo+ICAjZGVmaW5lIERQX1RQX1NUQVRVUyhwb3J0KSBfTU1JT19QT1JUKHBvcnQsIF9EUF9U UF9TVEFUVVNfQSwgX0RQX1RQX1NUQVRVU19CKQo+ICsjZGVmaW5lICBEUF9UUF9TVEFUVVNfRkVD X0VOQUJMRV9MSVZFCQkoMSA8PCAyOCkKPiAgI2RlZmluZSAgRFBfVFBfU1RBVFVTX0lETEVfRE9O RQkJCSgxIDw8IDI1KQo+ICAjZGVmaW5lICBEUF9UUF9TVEFUVVNfQUNUX1NFTlQJCQkoMSA8PCAy NCkKPiAgI2RlZmluZSAgRFBfVFBfU1RBVFVTX01PREVfU1RBVFVTX01TVAkJKDEgPDwgMjMpCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCBmNTMxOTAwMTY1YmYuLjY3YzAxM2VhNGQz OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTI5MTEsNiArMjkxMSw4IEBA IHN0YXRpYyB2b2lkIGludGVsX2RkaV9wcmVfZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVy ICplbmNvZGVyLAo+ICAJCQkJCSAgICAgIERQX0RFQ09NUFJFU1NJT05fRU4pOwo+ICAJaW50ZWxf ZHBfc2lua19zZXRfZmVjX3JlYWR5KGludGVsX2RwLCBjcnRjX3N0YXRlLCBEUF9GRUNfUkVBRFkp Owo+ICAJaW50ZWxfZHBfc3RhcnRfbGlua190cmFpbihpbnRlbF9kcCk7Cj4gKwlpbnRlbF9kcF9l bmFibGVfZmVjX3N0YXRlKGludGVsX2RwLCBjcnRjX3N0YXRlKTsKClRoaXMgZG9lc24ndCBsb29r IGxpa2UgdGhlIGNvcnJlY3Qgc3BvdC4gQWNjb3JkaW5nIHRvIHRoZSBzcGVjIGl0CnNob3VsZCBi ZSBhZnRlciBzdG9wX2xpbmtfdHJhaW4oKSAod2hlcmUgd2Ugc2V0IERQX1RQX0NUTCB0bwp0byBu b3JtYWwpLgoKPiArCj4gIAlpZiAocG9ydCAhPSBQT1JUX0EgfHwgSU5URUxfR0VOKGRldl9wcml2 KSA+PSA5KQo+ICAJCWludGVsX2RwX3N0b3BfbGlua190cmFpbihpbnRlbF9kcCk7Cj4gIAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IGI0ZThhZjMxNDJhMi4uYjlmODU1MDJkOWZmIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTMwMTcsNiArMzAxNywzMyBAQCB2b2lk IGludGVsX2RwX3Npbmtfc2V0X2ZlY19yZWFkeShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ ICAJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byBnZXQgRkVDIGVuYWJsZWQgaW4gc2lua1xuIik7 Cj4gIH0KPiAgCj4gK3ZvaWQgaW50ZWxfZHBfZW5hYmxlX2ZlY19zdGF0ZShzdHJ1Y3QgaW50ZWxf ZHAgKmludGVsX2RwLAo+ICsJCQkgICAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNydGNfc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50 ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gKwllbnVtIHBvcnQgcG9y dCA9IGludGVsX2RpZ19wb3J0LT5iYXNlLnBvcnQ7Cj4gKwl1MzIgdmFsOwo+ICsKPiArCS8qIEZF QyBzdXBwb3J0IGV4aXN0cyBmb3IgRFAgMS40IG9ubHkgKi8KPiArCWlmIChpbnRlbF9kcF9pc19l ZHAoaW50ZWxfZHApKQo+ICsJCXJldHVybjsKPiArCj4gKwkvKiBJZiBEaXNwbGF5IENvbXByZXNz aW9uIGlzIG5vdCBlbmFibGVkLCBGRUMgbmVlZCBub3QgYmUgY29uZmlndXJlZCAqLwo+ICsJaWYg KCFjcnRjX3N0YXRlLT5kc2NfcGFyYW1zLmNvbXByZXNzaW9uX2VuYWJsZSkKPiArCQlyZXR1cm47 Cj4gKwo+ICsJdmFsID0gSTkxNV9SRUFEKERQX1RQX0NUTChwb3J0KSk7Cj4gKwl2YWwgfD0gRFBf VFBfQ1RMX0ZFQ19FTkFCTEU7Cj4gKwlJOTE1X1dSSVRFKERQX1RQX0NUTChwb3J0KSwgdmFsKTsK PiArCj4gKwlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIERQX1RQX1NUQVRV Uyhwb3J0KSwKPiArCQkJCSAgICBEUF9UUF9TVEFUVVNfRkVDX0VOQUJMRV9MSVZFLAo+ICsJCQkJ ICAgIERQX1RQX1NUQVRVU19GRUNfRU5BQkxFX0xJVkUsCj4gKwkJCQkgICAgMSkpCj4gKwkJRFJN X0VSUk9SKCJUaW1lZCBvdXQgd2FpdGluZyBmb3IgRkVDIEVuYWJsZSBTdGF0dXNcbiIpOwo+ICt9 CgpUaGVyZSBpcyBubyByZWFzb24gdG8gc3RpY2sgdGhlc2UgaW50byBpbnRlbF9kcC5jIHdoZW4g dGhlCm9ubHkgY2FsbGVyIGlzIGluIGludGVsX2RkaS5jLgoKV2UgYWxzbyBzZWVtIHRvIGJlIG1p c3NpbmcgcGxhdGZvcm0gY2hlY2tzLiBGRUMgZG9lc24ndCBhcHBlYXIgdG8KYmUgYSB0aGluZyBw cmlvciB0byBJQ0wuIEkgZ3Vlc3MgdGhlIGVkcCtjb21wcmVzc2lvbl9lbmFibGUgdGFrZXMgY2Fy ZQpvZiB0aGlzLCBidXQgSSB0aGluayBJJ2QgcmF0aGVyIHN0aWNrIGEgbmV3IGZlY19lbmFibGUg Ym9vbCBpbnRvCnRoZSBjcnRjIHN0YXRlLiBUaGF0IHdheSB3ZSBnZXQgY2FuIGFkZCBpdCB0byB0 aGUgc3RhdGUgY2hlY2tlciBhcyB3ZWxsLgoKPiArCj4gIC8qIElmIHRoZSBzaW5rIHN1cHBvcnRz IGl0LCB0cnkgdG8gc2V0IHRoZSBwb3dlciBzdGF0ZSBhcHByb3ByaWF0ZWx5ICovCj4gIHZvaWQg aW50ZWxfZHBfc2lua19kcG1zKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGludCBtb2RlKQo+ ICB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBmYmM5ZmEwNmU4YmUuLmU1MWQ2 MTJhOWY0MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTE1MzIsNyArMTUz Miw2IEBAIGludGVsX2VuY29kZXJfY3VycmVudF9tb2RlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl bmNvZGVyKTsKPiAgYm9vbCBpbnRlbF9wb3J0X2lzX3RjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpOwo+ICBlbnVtIHRjX3BvcnQgaW50ZWxfcG9ydF90 b190YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgICAgIGVudW0g cG9ydCBwb3J0KTsKPiAtCj4gIGVudW0gcGlwZSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rv cihzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpOwo+ICBpbnQgaW50ZWxfZ2V0X3Bp cGVfZnJvbV9jcnRjX2lkX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEs Cj4gIAkJCQkgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdik7Cj4gQEAgLTE3MTIsNiAr MTcxMSw4IEBAIHZvaWQgaW50ZWxfZHBfc2lua19zZXRfZGVjb21wcmVzc2lvbl9zdGF0ZShzdHJ1 Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICB2b2lkIGludGVsX2RwX3Npbmtfc2V0X2ZlY19yZWFk eShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkJIGludCBzdGF0ZSk7Cj4gK3ZvaWQgaW50ZWxf ZHBfZW5hYmxlX2ZlY19zdGF0ZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICsJCQkgICAg ICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ICB2b2lkIGlu dGVsX2RwX2VuY29kZXJfcmVzZXQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiAgdm9p ZCBpbnRlbF9kcF9lbmNvZGVyX3N1c3BlbmQoc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2Vu Y29kZXIpOwo+ICB2b2lkIGludGVsX2RwX2VuY29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29k ZXIgKmVuY29kZXIpOwo+IC0tIAo+IDIuMTcuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK