From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Consolidate cdclk hooks. Date: Fri, 19 Oct 2018 22:33:26 +0300 Message-ID: <20181019193326.GY9144@intel.com> References: <20181019191153.28915-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D2656E51D for ; Fri, 19 Oct 2018 19:33:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181019191153.28915-1-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTksIDIwMTggYXQgMTI6MTE6NTNQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IFdlIGRvbid0IG5lZWQgMiBkaWZmZXJlbnQgYmxvY2tzLgo+IFNwZWNpYWxseSB3aXRo IG9uIGluIG9yZGVyZWQgb2xkZXItdG8tbmV3ZXIgYW5kIHRoZSBvdGhlcgo+IG9uZSBuZXdlci10 by1vbGRlci4KPiAKPiBMZXQncyBzdGFydCBhbHdheXMgdXNpbmcgbmV3ZXItdG8tb2xkZXIgb3Jk ZXIKPiB3aGVuIGl0IG1ha2VzIHNlbnNlLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8 cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY2RjbGsuYyB8IDkxICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jZGNsay5jCj4gaW5kZXggMjkwNzVjNzYzNDI4Li43NmU2OWM0ZjE1NGYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiBAQCAtMjc3Nyw4MCArMjc3Nyw3MyBA QCB2b2lkIGludGVsX3VwZGF0ZV9yYXdjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICAgKi8KPiAgdm9pZCBpbnRlbF9pbml0X2NkY2xrX2hvb2tzKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+IC0JaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYp KSB7Cj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0gY2h2X3NldF9jZGNsazsKPiAt CQlkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGsgPQo+IC0JCQl2bHZfbW9kZXNl dF9jYWxjX2NkY2xrOwo+IC0JfSBlbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSkgewo+ IC0JCWRldl9wcml2LT5kaXNwbGF5LnNldF9jZGNsayA9IHZsdl9zZXRfY2RjbGs7Cj4gLQkJZGV2 X3ByaXYtPmRpc3BsYXkubW9kZXNldF9jYWxjX2NkY2xrID0KPiAtCQkJdmx2X21vZGVzZXRfY2Fs Y19jZGNsazsKPiAtCX0gZWxzZSBpZiAoSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+IC0JCWRl dl9wcml2LT5kaXNwbGF5LnNldF9jZGNsayA9IGJkd19zZXRfY2RjbGs7Cj4gLQkJZGV2X3ByaXYt PmRpc3BsYXkubW9kZXNldF9jYWxjX2NkY2xrID0KPiAtCQkJYmR3X21vZGVzZXRfY2FsY19jZGNs azsKPiAtCX0gZWxzZSBpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikpIHsKPiAtCQlkZXZfcHJpdi0+ ZGlzcGxheS5zZXRfY2RjbGsgPSBieHRfc2V0X2NkY2xrOwo+IC0JCWRldl9wcml2LT5kaXNwbGF5 Lm1vZGVzZXRfY2FsY19jZGNsayA9Cj4gLQkJCWJ4dF9tb2Rlc2V0X2NhbGNfY2RjbGs7Cj4gLQl9 IGVsc2UgaWYgKElTX0dFTjlfQkMoZGV2X3ByaXYpKSB7Cj4gLQkJZGV2X3ByaXYtPmRpc3BsYXku c2V0X2NkY2xrID0gc2tsX3NldF9jZGNsazsKPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0 X2NhbGNfY2RjbGsgPQo+IC0JCQlza2xfbW9kZXNldF9jYWxjX2NkY2xrOwo+ICsJaWYgKElTX0lD RUxBS0UoZGV2X3ByaXYpKSB7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0gaWNs X3NldF9jZGNsazsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGsgPSBp Y2xfbW9kZXNldF9jYWxjX2NkY2xrOwo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9 IGljbF9nZXRfY2RjbGs7Cj4gIAl9IGVsc2UgaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKSB7 Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0gY25sX3NldF9jZGNsazsKPiAgCQlk ZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGsgPQo+ICAJCQljbmxfbW9kZXNldF9j YWxjX2NkY2xrOwoKQ2FuIHlvdSBlbGltaW5hdGUgdGhlc2UgZXh0cmEgJ1xuJyBpbiB0aGVzZSBh c3NpZ21lbnRzIHdoaWxlIHlvdSdyZQpoZXJlPyBJIHRoaW5rIHRoZXkgc2hvdWxkIGFsbCBmaXQg d2l0aGluIHRoZSA4MCBjb2wgcnVsZSBub3cuCgpBbHNvIGFub3RoZXIgb2NkIHlvdSBjb3VsZCBk byBpcyBvcmRlciB0aGUgYXNzaWdubWVudHMgaW4gYSBiZXR0ZXIKbG9va2luZyB3YXkuIEknZCBz dWdnZXN0IGVpdGhlciBnZXQsc2V0LGNhbGMgb3IgY2FsYyxzZXQsZ2V0LgoKPiAtCX0gZWxzZSBp ZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpIHsKPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5zZXRfY2Rj bGsgPSBpY2xfc2V0X2NkY2xrOwo+IC0JCWRldl9wcml2LT5kaXNwbGF5Lm1vZGVzZXRfY2FsY19j ZGNsayA9IGljbF9tb2Rlc2V0X2NhbGNfY2RjbGs7Cj4gLQl9Cj4gLQo+IC0JaWYgKElTX0lDRUxB S0UoZGV2X3ByaXYpKQo+IC0JCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGljbF9nZXRf Y2RjbGs7Cj4gLQllbHNlIGlmIChJU19DQU5OT05MQUtFKGRldl9wcml2KSkKPiAgCQlkZXZfcHJp di0+ZGlzcGxheS5nZXRfY2RjbGsgPSBjbmxfZ2V0X2NkY2xrOwo+IC0JZWxzZSBpZiAoSVNfR0VO OV9CQyhkZXZfcHJpdikpCj4gKwl9IGVsc2UgaWYgKElTX0dFTjlfQkMoZGV2X3ByaXYpKSB7Cj4g KwkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0gc2tsX3NldF9jZGNsazsKPiArCQlkZXZf cHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGsgPQo+ICsJCQlza2xfbW9kZXNldF9jYWxj X2NkY2xrOwo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IHNrbF9nZXRfY2RjbGs7 Cj4gLQllbHNlIGlmIChJU19HRU45X0xQKGRldl9wcml2KSkKPiArCX0gZWxzZSBpZiAoSVNfR0VO OV9MUChkZXZfcHJpdikpIHsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5zZXRfY2RjbGsgPSBieHRf c2V0X2NkY2xrOwo+ICsJCWRldl9wcml2LT5kaXNwbGF5Lm1vZGVzZXRfY2FsY19jZGNsayA9Cj4g KwkJCWJ4dF9tb2Rlc2V0X2NhbGNfY2RjbGs7Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gYnh0X2dldF9jZGNsazsKCmJ4dCBiZWZvcmUgc2tsIGlmIHdlIHdhbnQgdG8gYmUgY2hy b25vbG9naWNhbGx5IHBlZGFudGljPwoKPiAtCWVsc2UgaWYgKElTX0JST0FEV0VMTChkZXZfcHJp dikpCj4gKwl9IGVsc2UgaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiArCQlkZXZfcHJp di0+ZGlzcGxheS5zZXRfY2RjbGsgPSBiZHdfc2V0X2NkY2xrOwo+ICsJCWRldl9wcml2LT5kaXNw bGF5Lm1vZGVzZXRfY2FsY19jZGNsayA9Cj4gKwkJCWJkd19tb2Rlc2V0X2NhbGNfY2RjbGs7Cj4g IAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gYmR3X2dldF9jZGNsazsKPiAtCWVsc2Ug aWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpKQo+ICsJfSBlbHNlIGlmIChJU19IQVNXRUxMKGRldl9w cml2KSkgewo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGhzd19nZXRfY2RjbGs7 Cgpoc3cgd2lsbCBsb29rIGEgYml0IGxvbmVseSBpbiB0aGUgbWlkZGxlIGhlcmUsIGJ1dCBJIHN1 cHBvc2UgdGhhdCdzCm5vdCBzdWZmaWNpZW50IHJlYXNvbiB0byB1cHN0cmVhbSBteSBoc3dfc2V0 X2NkY2xrIDpQCgo+IC0JZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hF UlJZVklFVyhkZXZfcHJpdikpCj4gKwl9IGVsc2UgaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYp KSB7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0gY2h2X3NldF9jZGNsazsKPiAr CQlkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGsgPQo+ICsJCQl2bHZfbW9kZXNl dF9jYWxjX2NkY2xrOwo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IHZsdl9nZXRf Y2RjbGs7CgpjaHYgYmVmb3JlIGJkdz8KClBhdGNoIGlzIApSZXZpZXdlZC1ieTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCkZlZWwgZnJlZSB0byBpZ25v cmUgYW55IG9mIG15IGJpa2VzaGVkcyB5b3UgZG9uJ3QgYWdyZWUgd2l0aC4KCj4gLQllbHNlIGlm IChJU19HRU42KGRldl9wcml2KSB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKQo+ICsJfSBlbHNl IGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSkgewo+ICsJCWRldl9wcml2LT5kaXNwbGF5LnNl dF9jZGNsayA9IHZsdl9zZXRfY2RjbGs7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkubW9kZXNldF9j YWxjX2NkY2xrID0KPiArCQkJdmx2X21vZGVzZXRfY2FsY19jZGNsazsKPiArCQlkZXZfcHJpdi0+ ZGlzcGxheS5nZXRfY2RjbGsgPSB2bHZfZ2V0X2NkY2xrOwo+ICsJfSBlbHNlIGlmIChJU19HRU42 KGRldl9wcml2KSB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKSB7Cj4gIAkJZGV2X3ByaXYtPmRp c3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dldF9jZGNsazsKPiAtCWVsc2UgaWYgKElT X0dFTjUoZGV2X3ByaXYpKQo+ICsJfSBlbHNlIGlmIChJU19HRU41KGRldl9wcml2KSkgewo+ICAJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQ1MG1oel9nZXRfY2RjbGs7Cj4g LQllbHNlIGlmIChJU19HTTQ1KGRldl9wcml2KSkKPiArCX0gZWxzZSBpZiAoSVNfR000NShkZXZf cHJpdikpIHsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBnbTQ1X2dldF9jZGNs azsKPiAtCWVsc2UgaWYgKElTX0c0NShkZXZfcHJpdikpCj4gKwl9IGVsc2UgaWYgKElTX0c0NShk ZXZfcHJpdikpIHsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBnMzNfZ2V0X2Nk Y2xrOwo+IC0JZWxzZSBpZiAoSVNfSTk2NUdNKGRldl9wcml2KSkKPiArCX0gZWxzZSBpZiAoSVNf STk2NUdNKGRldl9wcml2KSkgewo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGk5 NjVnbV9nZXRfY2RjbGs7Cj4gLQllbHNlIGlmIChJU19JOTY1RyhkZXZfcHJpdikpCj4gKwl9IGVs c2UgaWYgKElTX0k5NjVHKGRldl9wcml2KSkgewo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9j ZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4gLQllbHNlIGlmIChJU19QSU5FVklFVyhk ZXZfcHJpdikpCj4gKwl9IGVsc2UgaWYgKElTX1BJTkVWSUVXKGRldl9wcml2KSkgewo+ICAJCWRl dl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IHBudl9nZXRfY2RjbGs7Cj4gLQllbHNlIGlmIChJ U19HMzMoZGV2X3ByaXYpKQo+ICsJfSBlbHNlIGlmIChJU19HMzMoZGV2X3ByaXYpKSB7Cj4gIAkJ ZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZzMzX2dldF9jZGNsazsKPiAtCWVsc2UgaWYg KElTX0k5NDVHTShkZXZfcHJpdikpCj4gKwl9IGVsc2UgaWYgKElTX0k5NDVHTShkZXZfcHJpdikp IHsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTQ1Z21fZ2V0X2NkY2xrOwo+ IC0JZWxzZSBpZiAoSVNfSTk0NUcoZGV2X3ByaXYpKQo+ICsJfSBlbHNlIGlmIChJU19JOTQ1Ryhk ZXZfcHJpdikpIHsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF80MDBt aHpfZ2V0X2NkY2xrOwo+IC0JZWxzZSBpZiAoSVNfSTkxNUdNKGRldl9wcml2KSkKPiArCX0gZWxz ZSBpZiAoSVNfSTkxNUdNKGRldl9wcml2KSkgewo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9j ZGNsayA9IGk5MTVnbV9nZXRfY2RjbGs7Cj4gLQllbHNlIGlmIChJU19JOTE1RyhkZXZfcHJpdikp Cj4gKwl9IGVsc2UgaWYgKElTX0k5MTVHKGRldl9wcml2KSkgewo+ICAJCWRldl9wcml2LT5kaXNw bGF5LmdldF9jZGNsayA9IGZpeGVkXzMzM21oel9nZXRfY2RjbGs7Cj4gLQllbHNlIGlmIChJU19J ODY1RyhkZXZfcHJpdikpCj4gKwl9IGVsc2UgaWYgKElTX0k4NjVHKGRldl9wcml2KSkgewo+ICAJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGs7Cj4g LQllbHNlIGlmIChJU19JODVYKGRldl9wcml2KSkKPiArCX0gZWxzZSBpZiAoSVNfSTg1WChkZXZf cHJpdikpIHsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODV4X2dldF9jZGNs azsKPiAtCWVsc2UgaWYgKElTX0k4NDVHKGRldl9wcml2KSkKPiArCX0gZWxzZSBpZiAoSVNfSTg0 NUcoZGV2X3ByaXYpKSB7Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRf MjAwbWh6X2dldF9jZGNsazsKPiAtCWVsc2UgeyAvKiA4MzAgKi8KPiArCX0gZWxzZSB7IC8qIDgz MCAqLwo+ICAJCVdBUk4oIUlTX0k4MzAoZGV2X3ByaXYpLAo+ICAJCSAgICAgIlVua25vd24gcGxh dGZvcm0uIEFzc3VtaW5nIDEzMyBNSHogQ0RDTEtcbiIpOwo+ICAJCWRldl9wcml2LT5kaXNwbGF5 LmdldF9jZGNsayA9IGZpeGVkXzEzM21oel9nZXRfY2RjbGs7Cj4gLS0gCj4gMi4xOS4xCgotLSAK VmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=