All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: power_domains_init sort platforms newer-to-older
Date: Fri, 19 Oct 2018 22:55:33 +0300	[thread overview]
Message-ID: <20181019195533.GC9144@intel.com> (raw)
In-Reply-To: <20181019190335.26616-5-rodrigo.vivi@intel.com>

On Fri, Oct 19, 2018 at 12:03:34PM -0700, Rodrigo Vivi wrote:
> No functional change.
> 
> Just sorting this "if" block from newer to older platform.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 31a49bdcf193..bcc639940c5e 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -3084,12 +3084,6 @@ int intel_power_domains_init(struct drm_i915_private *dev_priv)
>  	 */
>  	if (IS_ICELAKE(dev_priv)) {
>  		err = set_power_wells(power_domains, icl_power_wells);
> -	} else if (IS_HASWELL(dev_priv)) {
> -		err = set_power_wells(power_domains, hsw_power_wells);
> -	} else if (IS_BROADWELL(dev_priv)) {
> -		err = set_power_wells(power_domains, bdw_power_wells);
> -	} else if (IS_GEN9_BC(dev_priv)) {
> -		err = set_power_wells(power_domains, skl_power_wells);
>  	} else if (IS_CANNONLAKE(dev_priv)) {
>  		err = set_power_wells(power_domains, cnl_power_wells);
>  
> @@ -3101,15 +3095,20 @@ int intel_power_domains_init(struct drm_i915_private *dev_priv)
>  		 */
>  		if (!IS_CNL_WITH_PORT_F(dev_priv))
>  			power_domains->power_well_count -= 2;
> -
> -	} else if (IS_BROXTON(dev_priv)) {
> -		err = set_power_wells(power_domains, bxt_power_wells);
>  	} else if (IS_GEMINILAKE(dev_priv)) {
>  		err = set_power_wells(power_domains, glk_power_wells);
> +	} else if (IS_GEN9_BC(dev_priv)) {
> +		err = set_power_wells(power_domains, skl_power_wells);
> +	} else if (IS_BROXTON(dev_priv)) {
> +		err = set_power_wells(power_domains, bxt_power_wells);

bxt before skl+ is what my chronometer says

> +	} else if (IS_BROADWELL(dev_priv)) {
> +		err = set_power_wells(power_domains, bdw_power_wells);
>  	} else if (IS_CHERRYVIEW(dev_priv)) {
>  		err = set_power_wells(power_domains, chv_power_wells);

and chv before bdw

>  	} else if (IS_VALLEYVIEW(dev_priv)) {
>  		err = set_power_wells(power_domains, vlv_power_wells);
> +	} else if (IS_HASWELL(dev_priv)) {
> +		err = set_power_wells(power_domains, hsw_power_wells);

and hsw before vlv ... I think

>  	} else if (IS_I830(dev_priv)) {
>  		err = set_power_wells(power_domains, i830_power_wells);

Dang! i830 ruins it anyway ;)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	} else {
> -- 
> 2.19.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-10-19 19:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 19:03 [PATCH 0/5] Sorting "if" blocks and statements from newer to older platform Rodrigo Vivi
2018-10-19 19:03 ` [PATCH 1/5] drm/i915: ddi_clock_get sort platforms newer-to-older Rodrigo Vivi
2018-10-19 19:43   ` Ville Syrjälä
2018-10-19 19:03 ` [PATCH 2/5] drm/i915: compute_min_voltage_level " Rodrigo Vivi
2018-10-19 19:43   ` Ville Syrjälä
2018-10-19 19:03 ` [PATCH 3/5] drm/i915: digital_port_connected " Rodrigo Vivi
2018-10-19 19:50   ` Ville Syrjälä
2018-10-19 19:03 ` [PATCH 4/5] drm/i915: power_domains_init " Rodrigo Vivi
2018-10-19 19:55   ` Ville Syrjälä [this message]
2018-10-19 19:03 ` [PATCH 5/5] drm/i915: uncore_fw_domains_init " Rodrigo Vivi
2018-10-19 19:56   ` Ville Syrjälä
2018-10-22 14:05 ` ✗ Fi.CI.BAT: failure for Sorting "if" blocks and statements from newer to older platform Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-10-22 17:15 [PATCH 1/5] drm/i915: ddi_clock_get sort platforms newer-to-older Rodrigo Vivi
2018-10-22 17:15 ` [PATCH 4/5] drm/i915: power_domains_init " Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019195533.GC9144@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.