From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] package/nvidia-driver: use += where appropriate
Date: Sun, 21 Oct 2018 00:14:35 +0200 [thread overview]
Message-ID: <20181020221437.12687-5-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20181020221437.12687-1-thomas.petazzoni@bootlin.com>
Within the BR2_PACKAGE_NVIDIA_DRIVER_XORG condition, some "="
assignements are used for various variables, which are also appended
in other conditions below in nvidia-driver.mk.
It works fine because those assignements appear earlier in the .mk,
but it is a bit error-prone, so let's use += when adding values to
those variables.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/nvidia-driver/nvidia-driver.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/nvidia-driver/nvidia-driver.mk b/package/nvidia-driver/nvidia-driver.mk
index a595aed4f7..0d051fcaa4 100644
--- a/package/nvidia-driver/nvidia-driver.mk
+++ b/package/nvidia-driver/nvidia-driver.mk
@@ -20,8 +20,8 @@ ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_XORG),y)
# are build dependencies of packages that depend on nvidia-driver, so
# they should be built prior to those packages, and the only simple
# way to do so is to make nvidia-driver depend on them.
-NVIDIA_DRIVER_DEPENDENCIES = mesa3d-headers xlib_libX11 xlib_libXext
-NVIDIA_DRIVER_PROVIDES = libgl libegl libgles
+NVIDIA_DRIVER_DEPENDENCIES += mesa3d-headers xlib_libX11 xlib_libXext
+NVIDIA_DRIVER_PROVIDES += libgl libegl libgles
# libGL.so.$(NVIDIA_DRIVER_VERSION) is the legacy libGL.so library; it
# has been replaced with libGL.so.1.0.0. Installing both is technically
@@ -65,7 +65,7 @@ NVIDIA_DRIVER_LIBS_MISC = \
libvdpau_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
libnvidia-ml.so.$(NVIDIA_DRIVER_VERSION)
-NVIDIA_DRIVER_LIBS = \
+NVIDIA_DRIVER_LIBS += \
$(NVIDIA_DRIVER_LIBS_GL) \
$(NVIDIA_DRIVER_LIBS_EGL) \
$(NVIDIA_DRIVER_LIBS_GLES) \
--
2.14.4
next prev parent reply other threads:[~2018-10-20 22:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 22:14 [Buildroot] [PATCH 0/6] OpenCL support Thomas Petazzoni
2018-10-20 22:14 ` [Buildroot] [PATCH 1/6] package/opengl/opencl: new virtual package Thomas Petazzoni
2018-10-21 10:46 ` Valentin Korenblit
2018-10-21 14:29 ` Thomas Petazzoni
2018-10-20 22:14 ` [Buildroot] [PATCH 2/6] package/mesa3d: enable OpenCL support Thomas Petazzoni
2018-10-21 10:53 ` Valentin Korenblit
2018-10-21 11:10 ` Thomas Petazzoni
2018-10-20 22:14 ` [Buildroot] [PATCH 3/6] package/mesa3d-headers: install OpenCL headers when needed Thomas Petazzoni
2018-10-20 22:14 ` Thomas Petazzoni [this message]
2018-10-20 22:14 ` [Buildroot] [PATCH 5/6] package/nvidia-driver: become an OpenCL provider Thomas Petazzoni
2018-10-20 22:14 ` [Buildroot] [PATCH 6/6] package/clinfo: new package Thomas Petazzoni
2018-12-03 22:09 ` [Buildroot] [PATCH 0/6] OpenCL support Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020221437.12687-5-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.