diff for duplicates of <20181021150857.4f9c2244@archlinux> diff --git a/a/1.txt b/N1/1.txt index 7888675..5639911 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,70 +1,69 @@ On Wed, 17 Oct 2018 16:00:02 +0800 Song Qiang <songqiang1304521@gmail.com> wrote: -> On 2018/10/12 =E4=B8=8B=E5=8D=888:53, Himanshu Jha wrote: +> On 2018/10/12 下午8:53, Himanshu Jha wrote: > > Hi Qiang, > > -> > On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote: =20 +> > On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote: > >> -> >> On 2018=E5=B9=B410=E6=9C=8812=E6=97=A5 15:35, Song Qiang wrote: =20 +> >> On 2018年10月12日 15:35, Song Qiang wrote: > >>> PNI RM3100 is a high resolution, large signal immunity magnetometer, > >>> composed of 3 single sensors and a processing chip with a MagI2C > >>> interface. -> >>> =20 -> >> ... =20 +> >>> +> >> ... > >>> +static irqreturn_t rm3100_trigger_handler(int irq, void *p) > >>> +{ -> >>> + struct iio_poll_func *pf =3D p; -> >>> + struct iio_dev *indio_dev =3D pf->indio_dev; -> >>> + unsigned long scan_mask =3D *indio_dev->active_scan_mask; -> >>> + unsigned int mask_len =3D indio_dev->masklength; -> >>> + struct rm3100_data *data =3D iio_priv(indio_dev); -> >>> + struct regmap *regmap =3D data->regmap; +> >>> + struct iio_poll_func *pf = p; +> >>> + struct iio_dev *indio_dev = pf->indio_dev; +> >>> + unsigned long scan_mask = *indio_dev->active_scan_mask; +> >>> + unsigned int mask_len = indio_dev->masklength; +> >>> + struct rm3100_data *data = iio_priv(indio_dev); +> >>> + struct regmap *regmap = data->regmap; > >>> + int ret, i, bit; > >>> + > >>> + mutex_lock(&data->lock); > >>> + switch (scan_mask) { > >>> + case BIT(0) | BIT(1) | BIT(2): -> >>> + ret =3D regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9); +> >>> + ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9); > >>> + mutex_unlock(&data->lock); > >>> + if (ret < 0) > >>> + goto done; > >>> + break; > >>> + case BIT(0) | BIT(1): -> >>> + ret =3D regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6); +> >>> + ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6); > >>> + mutex_unlock(&data->lock); > >>> + if (ret < 0) > >>> + goto done; > >>> + break; > >>> + case BIT(1) | BIT(2): -> >>> + ret =3D regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6); +> >>> + ret = regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6); > >>> + mutex_unlock(&data->lock); > >>> + if (ret < 0) > >>> + goto done; -> >>> + break; =20 +> >>> + break; > >> Hi Jonathan, > >> -> >> I just noticed that these three breaks are not proper aligned. =20 +> >> I just noticed that these three breaks are not proper aligned. > > Please send the new version of a patch as a *new* thread and don't > > use `--in-reply-to` flag(if you're using) to chain into older versions > > as whole thread of older discussion comes up and is often not required. > > > > The changelog gives enough info of what's new in the revised series. > > -> > =20 +> > > Hi Himanshu, ->=20 ->=20 +> +> > Thanks for your advise. ->=20 -> I did it because the following instruction tells me to, and I think it's= -=20 +> +> I did it because the following instruction tells me to, and I think it's > also a very quick way of gathering ->=20 -> all scattered messages. Both ways have their own advantages and=20 +> +> all scattered messages. Both ways have their own advantages and > disadvantages I think. :) ->=20 -> <https://kernelnewbies.org/PatchPhilosophy> Section "Updating and=20 +> +> <https://kernelnewbies.org/PatchPhilosophy> Section "Updating and > resending patches". That's a curious bit of advice. There are certainly a lot of maintainers who would not want that. It never works with anything beyond trivial @@ -80,9 +79,9 @@ Thanks, Jonathan ->=20 ->=20 +> +> > yours, ->=20 +> > Song Qiang ->=20 +> diff --git a/a/content_digest b/N1/content_digest index f668e31..d9e6102 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -23,70 +23,69 @@ "On Wed, 17 Oct 2018 16:00:02 +0800\n" "Song Qiang <songqiang1304521@gmail.com> wrote:\n" "\n" - "> On 2018/10/12 =E4=B8=8B=E5=8D=888:53, Himanshu Jha wrote:\n" + "> On 2018/10/12 \344\270\213\345\215\2108:53, Himanshu Jha wrote:\n" "> > Hi Qiang,\n" "> >\n" - "> > On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote: =20\n" + "> > On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote: \n" "> >>\n" - "> >> On 2018=E5=B9=B410=E6=9C=8812=E6=97=A5 15:35, Song Qiang wrote: =20\n" + "> >> On 2018\345\271\26410\346\234\21012\346\227\245 15:35, Song Qiang wrote: \n" "> >>> PNI RM3100 is a high resolution, large signal immunity magnetometer,\n" "> >>> composed of 3 single sensors and a processing chip with a MagI2C\n" "> >>> interface.\n" - "> >>> =20\n" - "> >> ... =20\n" + "> >>> \n" + "> >> ... \n" "> >>> +static irqreturn_t rm3100_trigger_handler(int irq, void *p)\n" "> >>> +{\n" - "> >>> +\tstruct iio_poll_func *pf =3D p;\n" - "> >>> +\tstruct iio_dev *indio_dev =3D pf->indio_dev;\n" - "> >>> +\tunsigned long scan_mask =3D *indio_dev->active_scan_mask;\n" - "> >>> +\tunsigned int mask_len =3D indio_dev->masklength;\n" - "> >>> +\tstruct rm3100_data *data =3D iio_priv(indio_dev);\n" - "> >>> +\tstruct regmap *regmap =3D data->regmap;\n" + "> >>> +\tstruct iio_poll_func *pf = p;\n" + "> >>> +\tstruct iio_dev *indio_dev = pf->indio_dev;\n" + "> >>> +\tunsigned long scan_mask = *indio_dev->active_scan_mask;\n" + "> >>> +\tunsigned int mask_len = indio_dev->masklength;\n" + "> >>> +\tstruct rm3100_data *data = iio_priv(indio_dev);\n" + "> >>> +\tstruct regmap *regmap = data->regmap;\n" "> >>> +\tint ret, i, bit;\n" "> >>> +\n" "> >>> +\tmutex_lock(&data->lock);\n" "> >>> +\tswitch (scan_mask) {\n" "> >>> +\tcase BIT(0) | BIT(1) | BIT(2):\n" - "> >>> +\t\tret =3D regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9);\n" + "> >>> +\t\tret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9);\n" "> >>> +\t\tmutex_unlock(&data->lock);\n" "> >>> +\t\tif (ret < 0)\n" "> >>> +\t\t\tgoto done;\n" "> >>> +\tbreak;\n" "> >>> +\tcase BIT(0) | BIT(1):\n" - "> >>> +\t\tret =3D regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6);\n" + "> >>> +\t\tret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6);\n" "> >>> +\t\tmutex_unlock(&data->lock);\n" "> >>> +\t\tif (ret < 0)\n" "> >>> +\t\t\tgoto done;\n" "> >>> +\tbreak;\n" "> >>> +\tcase BIT(1) | BIT(2):\n" - "> >>> +\t\tret =3D regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6);\n" + "> >>> +\t\tret = regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6);\n" "> >>> +\t\tmutex_unlock(&data->lock);\n" "> >>> +\t\tif (ret < 0)\n" "> >>> +\t\t\tgoto done;\n" - "> >>> +\tbreak; =20\n" + "> >>> +\tbreak; \n" "> >> Hi Jonathan,\n" "> >>\n" - "> >> I just noticed that these three breaks are not proper aligned. =20\n" + "> >> I just noticed that these three breaks are not proper aligned. \n" "> > Please send the new version of a patch as a *new* thread and don't\n" "> > use `--in-reply-to` flag(if you're using) to chain into older versions\n" "> > as whole thread of older discussion comes up and is often not required.\n" "> >\n" "> > The changelog gives enough info of what's new in the revised series.\n" "> >\n" - "> > =20\n" + "> > \n" "> Hi Himanshu,\n" - ">=20\n" - ">=20\n" + "> \n" + "> \n" "> Thanks for your advise.\n" - ">=20\n" - "> I did it because the following instruction tells me to, and I think it's=\n" - "=20\n" + "> \n" + "> I did it because the following instruction tells me to, and I think it's \n" "> also a very quick way of gathering\n" - ">=20\n" - "> all scattered messages. Both ways have their own advantages and=20\n" + "> \n" + "> all scattered messages. Both ways have their own advantages and \n" "> disadvantages I think. :)\n" - ">=20\n" - "> <https://kernelnewbies.org/PatchPhilosophy> Section \"Updating and=20\n" + "> \n" + "> <https://kernelnewbies.org/PatchPhilosophy> Section \"Updating and \n" "> resending patches\".\n" "That's a curious bit of advice. There are certainly a lot of maintainers\n" "who would not want that. It never works with anything beyond trivial\n" @@ -102,11 +101,11 @@ "\n" "Jonathan\n" "\n" - ">=20\n" - ">=20\n" + "> \n" + "> \n" "> yours,\n" - ">=20\n" + "> \n" "> Song Qiang\n" - >=20 + > -a344b9d789f47aa4a0102026b2a00c5c9421dcdbabdd56abfde3afd6d22a1779 +f3383e8d8391ec61d42785759921163440bc976c853be7e75fce62c70a3dafbe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.