diff for duplicates of <20181021154503.5141163f@archlinux> diff --git a/a/1.txt b/N1/1.txt index f2e56ff..a00dece 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,34 +1,34 @@ On Tue, 16 Oct 2018 20:26:57 +0200 -Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: +Stefan Br=C3=BCns <stefan.bruens@rwth-aachen.de> wrote: > On Dienstag, 16. Oktober 2018 18:14:18 CEST Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> -> > +> >=20 > > Static analysis with CoverityScan is throwing warnings that specific > > case statements are missing breaks. Rather than adding breaks, add > > return -EINVAL to the specific case statements to clarify the > > error return paths. Fix also saves 50 bytes. -> > +> >=20 > > Before: > > text data bss dec hex filename > > 21418 4936 128 26482 6772 drivers/iio/adc/ina2xx-adc.o -> > +> >=20 > > After: > > dec hex filename > > 21370 4936 128 26434 6742 drivers/iio/adc/ina2xx-adc.o -> > +> >=20 > > (gcc 8.2, x86-64) -> > +> >=20 > > Detected by CoverityScan, CID#1462408 ("Missing break in switch") -> > +> >=20 > > --- -> > +> >=20 > > V2: use returns instead of break statements to keep with the > > current style used in the switch statement. -> > -> > Signed-off-by: Colin Ian King <colin.king@canonical.com> -> -> Reviewed-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> +> >=20 +> > Signed-off-by: Colin Ian King <colin.king@canonical.com> =20 +>=20 +> Reviewed-by: Stefan Br=C3=BCns <stefan.bruens@rwth-aachen.de> Thanks, and applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. @@ -43,30 +43,32 @@ Thanks, Jonathan -> +>=20 > > --- > > drivers/iio/adc/ina2xx-adc.c | 2 ++ > > 1 file changed, 2 insertions(+) -> > +> >=20 > > diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c > > index d1239624187d..bdd7cba6f6b0 100644 > > --- a/drivers/iio/adc/ina2xx-adc.c > > +++ b/drivers/iio/adc/ina2xx-adc.c -> > @@ -250,6 +250,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_dev, -> > *val2 = chip->shunt_resistor_uohm; +> > @@ -250,6 +250,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_de= +v, +> > *val2 =3D chip->shunt_resistor_uohm; > > return IIO_VAL_FRACTIONAL; > > } > > + return -EINVAL; -> > +> >=20 > > case IIO_CHAN_INFO_HARDWAREGAIN: > > switch (chan->address) { -> > @@ -262,6 +263,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_dev, -> > *val = chip->range_vbus == 32 ? 1 : 2; +> > @@ -262,6 +263,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_de= +v, +> > *val =3D chip->range_vbus =3D=3D 32 ? 1 : 2; > > return IIO_VAL_INT; > > } > > + return -EINVAL; > > } -> > -> > return -EINVAL; -> -> +> >=20 +> > return -EINVAL; =20 +>=20 +>=20 diff --git a/a/content_digest b/N1/content_digest index 52333e8..0f9b17d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,49 +2,49 @@ "ref\03078823.PklSZE2rHu@pebbles\0" "From\0Jonathan Cameron <jic23@kernel.org>\0" "Subject\0Re: [PATCH][V2] iio: adc: ina2xx: add in early -EINVAL returns in case statements\0" - "Date\0Sun, 21 Oct 2018 14:45:03 +0000\0" + "Date\0Sun, 21 Oct 2018 15:45:03 +0100\0" "To\0Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de>\0" "Cc\0Colin King <colin.king@canonical.com>" Hartmut Knaack <knaack.h@gmx.de> Lars-Peter Clausen <lars@metafoo.de> Peter Meerwald-Stadler <pmeerw@pmeerw.net> Greg Kroah-Hartman <gregkh@linuxfoundation.org> - linux-iio@vger.kernel.org - kernel-janitors@vger.kernel.org - " linux-kernel@vger.kernel.org\0" + <linux-iio@vger.kernel.org> + <kernel-janitors@vger.kernel.org> + " <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "On Tue, 16 Oct 2018 20:26:57 +0200\n" - "Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de> wrote:\n" + "Stefan Br=C3=BCns <stefan.bruens@rwth-aachen.de> wrote:\n" "\n" "> On Dienstag, 16. Oktober 2018 18:14:18 CEST Colin King wrote:\n" "> > From: Colin Ian King <colin.king@canonical.com>\n" - "> > \n" + "> >=20\n" "> > Static analysis with CoverityScan is throwing warnings that specific\n" "> > case statements are missing breaks. Rather than adding breaks, add\n" "> > return -EINVAL to the specific case statements to clarify the\n" "> > error return paths. Fix also saves 50 bytes.\n" - "> > \n" + "> >=20\n" "> > Before:\n" "> > text\t data\t bss\t dec\t hex\tfilename\n" "> > 21418\t 4936\t 128\t 26482\t 6772\tdrivers/iio/adc/ina2xx-adc.o\n" - "> > \n" + "> >=20\n" "> > After:\n" "> > dec\t hex\tfilename\n" "> > 21370\t 4936\t 128\t 26434\t 6742\tdrivers/iio/adc/ina2xx-adc.o\n" - "> > \n" + "> >=20\n" "> > (gcc 8.2, x86-64)\n" - "> > \n" + "> >=20\n" "> > Detected by CoverityScan, CID#1462408 (\"Missing break in switch\")\n" - "> > \n" + "> >=20\n" "> > ---\n" - "> > \n" + "> >=20\n" "> > V2: use returns instead of break statements to keep with the\n" "> > current style used in the switch statement.\n" - "> > \n" - "> > Signed-off-by: Colin Ian King <colin.king@canonical.com> \n" - "> \n" - "> Reviewed-by: Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de>\n" + "> >=20\n" + "> > Signed-off-by: Colin Ian King <colin.king@canonical.com> =20\n" + ">=20\n" + "> Reviewed-by: Stefan Br=C3=BCns <stefan.bruens@rwth-aachen.de>\n" "\n" "Thanks, and applied to the togreg branch of iio.git and pushed\n" "out as testing for the autobuilders to play with it.\n" @@ -59,32 +59,34 @@ "\n" "Jonathan\n" "\n" - "> \n" + ">=20\n" "> > ---\n" "> > drivers/iio/adc/ina2xx-adc.c | 2 ++\n" "> > 1 file changed, 2 insertions(+)\n" - "> > \n" + "> >=20\n" "> > diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c\n" "> > index d1239624187d..bdd7cba6f6b0 100644\n" "> > --- a/drivers/iio/adc/ina2xx-adc.c\n" "> > +++ b/drivers/iio/adc/ina2xx-adc.c\n" - "> > @@ -250,6 +250,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_dev,\n" - "> > \t\t\t*val2 = chip->shunt_resistor_uohm;\n" + "> > @@ -250,6 +250,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_de=\n" + "v,\n" + "> > \t\t\t*val2 =3D chip->shunt_resistor_uohm;\n" "> > \t\t\treturn IIO_VAL_FRACTIONAL;\n" "> > \t\t}\n" "> > +\t\treturn -EINVAL;\n" - "> > \n" + "> >=20\n" "> > \tcase IIO_CHAN_INFO_HARDWAREGAIN:\n" "> > \t\tswitch (chan->address) {\n" - "> > @@ -262,6 +263,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_dev,\n" - "> > \t\t\t*val = chip->range_vbus == 32 ? 1 : 2;\n" + "> > @@ -262,6 +263,7 @@ static int ina2xx_read_raw(struct iio_dev *indio_de=\n" + "v,\n" + "> > \t\t\t*val =3D chip->range_vbus =3D=3D 32 ? 1 : 2;\n" "> > \t\t\treturn IIO_VAL_INT;\n" "> > \t\t}\n" "> > +\t\treturn -EINVAL;\n" "> > \t}\n" - "> > \n" - "> > \treturn -EINVAL; \n" - "> \n" - > + "> >=20\n" + "> > \treturn -EINVAL; =20\n" + ">=20\n" + >=20 -6c63220396c9f88c2b31d38920a63a7bf86c2cc017d89d48227f121d680857bf +8e71e2fae80f6fb0a8db39c14c47c3c66232c470bdd9354dde3a9ff3f6cd89af
diff --git a/a/content_digest b/N2/content_digest index 52333e8..0b9c2a2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,16 +2,16 @@ "ref\03078823.PklSZE2rHu@pebbles\0" "From\0Jonathan Cameron <jic23@kernel.org>\0" "Subject\0Re: [PATCH][V2] iio: adc: ina2xx: add in early -EINVAL returns in case statements\0" - "Date\0Sun, 21 Oct 2018 14:45:03 +0000\0" + "Date\0Sun, 21 Oct 2018 15:45:03 +0100\0" "To\0Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de>\0" "Cc\0Colin King <colin.king@canonical.com>" Hartmut Knaack <knaack.h@gmx.de> Lars-Peter Clausen <lars@metafoo.de> Peter Meerwald-Stadler <pmeerw@pmeerw.net> Greg Kroah-Hartman <gregkh@linuxfoundation.org> - linux-iio@vger.kernel.org - kernel-janitors@vger.kernel.org - " linux-kernel@vger.kernel.org\0" + <linux-iio@vger.kernel.org> + <kernel-janitors@vger.kernel.org> + " <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "On Tue, 16 Oct 2018 20:26:57 +0200\n" @@ -87,4 +87,4 @@ "> \n" > -6c63220396c9f88c2b31d38920a63a7bf86c2cc017d89d48227f121d680857bf +3e423f79c0ecf3d0b32fa070199d6e9fb95375da021d88f65f09b082b75161c3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.