All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Jayashree Mohan <jayashree2912@gmail.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
	Theodore Ts'o <tytso@mit.edu>, Eryu Guan <guaneryu@gmail.com>,
	Vijaychidambaram Velayudhan Pillai <vijay@cs.utexas.edu>,
	fstests <fstests@vger.kernel.org>
Subject: Re: Submitting patches to xfstests based on OSDI '18 paper (CrashMonkey)
Date: Mon, 22 Oct 2018 15:15:33 +1100	[thread overview]
Message-ID: <20181022041533.GO18822@dastard> (raw)
In-Reply-To: <CA+EzBbDGcryv+eiChoYEhCGKS87DBFMxiUvZGy8-VD-80YCetQ@mail.gmail.com>

On Sun, Oct 21, 2018 at 10:09:01PM -0500, Jayashree Mohan wrote:
> On Sun, Oct 21, 2018 at 9:44 PM Amir Goldstein <amir73il@gmail.com> wrote:
> >
> > > >
> > > > > See the file xfstests-dev/tests/generic/group to see how groups get
> > > > > assigned to tests.  I suppose all of the crashmonkey tests should be
> > > > > assigned to a new group, say, "crashmonkey".
> >
> > Wait, let me get it straight. Did crashmonkey produce 300 test cases or
> > did it find 300 bugs? Are all those test cases passing on all filesystems?
> > Some test cases failing on some filesystems?
> 
> CrashMonkey generates 300 workloads, out of which 3 tests result in
> bugs in two file systems (btrfs and F2FS). Others passed clean for
> ext4, xfs, btrfs and F2FS. Given that xfstest is a regression test
> suite, we thought it would be beneficial to add all 300 workloads to
> the generic test -

Perhaps you should port a test or two so we can have a look at what
these tests are before we make any recomendations on the best way to
integrate them. 300 new tests is an awful lot to maintain if we ever
want to change anything....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2018-10-22 12:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 20:58 Submitting patches to xfstests based on OSDI '18 paper (CrashMonkey) Jayashree Mohan
2018-10-21 10:45 ` Eryu Guan
2018-10-21 15:53   ` Jayashree Mohan
     [not found]   ` <CA+EzBbCd2zZ9sNW-dgyPyR5FH-HK5LArG6y+bPOCJ3Wqyp5=Ug@mail.gmail.com>
2018-10-21 22:21     ` Theodore Y. Ts'o
2018-10-21 22:52       ` Jayashree Mohan
2018-10-22  2:05         ` Dave Chinner
2018-10-22  2:35           ` Jayashree Mohan
2018-10-22  2:49             ` Amir Goldstein
2018-10-22  3:23               ` Jayashree Mohan
2018-10-22  4:02                 ` Dave Chinner
2018-10-22  7:14                   ` Theodore Y. Ts'o
2018-10-22  4:23                 ` Amir Goldstein
2018-10-22  2:44           ` Amir Goldstein
2018-10-22  3:09             ` Jayashree Mohan
2018-10-22  3:47               ` Amir Goldstein
2018-10-22  4:15               ` Dave Chinner [this message]
2018-10-22 13:25                 ` Eric Sandeen
2018-10-22 23:18                 ` Jayashree Mohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181022041533.GO18822@dastard \
    --to=david@fromorbit.com \
    --cc=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=jayashree2912@gmail.com \
    --cc=tytso@mit.edu \
    --cc=vijay@cs.utexas.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.