From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandru-Cosmin Gheorghe Subject: Re: [PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0 Date: Mon, 22 Oct 2018 11:09:45 +0100 Message-ID: <20181022100945.GC17598@e114479-lin.cambridge.arm.com> References: <20181019105752.17741-1-alexandru-cosmin.gheorghe@arm.com> <20181019105752.17741-6-alexandru-cosmin.gheorghe@arm.com> <20181019132146.GD78@DESKTOP-E1NTVVP.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0086.outbound.protection.outlook.com [104.47.0.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id B56E08981D for ; Mon, 22 Oct 2018 10:09:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181019132146.GD78@DESKTOP-E1NTVVP.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey Cc: charles.xu@arm.com, nd@arm.com, matt.szczesiak@arm.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, maxime.ripard@bootlin.com, david.garbett@arm.com, seanpaul@chromium.org, lisa.wu@arm.com, daniel.vetter@ffwll.ch, malidp@foss.arm.com, ayan.halder@arm.com, james.qian.wang@arm.com List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMTksIDIwMTggYXQgMDI6MjE6NDZQTSArMDEwMCwgQnJpYW4gU3RhcmtleSB3 cm90ZToKPiBIaSBBbGV4LAo+IAo+IE9uIEZyaSwgT2N0IDE5LCAyMDE4IGF0IDExOjU3OjQ4QU0g KzAxMDAsIEFsZXhhbmRydSBHaGVvcmdoZSB3cm90ZToKPiA+Rm9yIGZvcm1hdHMgdGhhdCBhcmUg c3VwcG9ydGVkIG9ubHkgd2l0aCBub24tbGluZWFyIG1vZGlmaWVycyBpdAo+ID5kb2Vzbid0IG1h a2UgdG8gbXVjaCBzZW5zZSB0byBkZWZpbmUgY3BwIG9yIGNoYXJfcGVyX2Jsb2NrLCBzbyB0aGF0 Cj4gPndpbGwgYmUgc2V0IHRvIDAuCj4gPgo+ID5UaGlzIHBhdGNoIGFkZHMgYSByZXN0cmljdGlv biB0byBmb3JjZSBoYXZpbmcgYSBtb2RpZmllciBhdHRhY2hlZCB3aGVuCj4gPmNwcC9jaGFyX3Bl cl9ibG9jayBpcyAwLCBhbmQgdG8gYnlwYXNzIGNoZWNraW5nIHRoZSBwaXRjaCByZXN0cmljdGlv bi4KPiA+Cj4gPlRoaXMgaGFkIGJlZW4gZGlzY3Vzc2VkIGhlcmUuCj4gPlsxXSBodHRwczovL3Bl b3BsZS5mcmVlZGVza3RvcC5vcmcvfmNicmlsbC9kcmktbG9nLz9jaGFubmVsPWRyaS1kZXZlbCZo aWdobGlnaHRfbmFtZXM9JmRhdGU9MjAxOC0wOS0xMyZzaG93X2h0bWw9dHJ1ZQo+ID4KPiA+U2ln bmVkLW9mZi1ieTogQWxleGFuZHJ1IEdoZW9yZ2hlIDxhbGV4YW5kcnUtY29zbWluLmdoZW9yZ2hl QGFybS5jb20+Cj4gPi0tLQo+ID5kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgfCA3 ICsrKysrKy0KPiA+MSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQo+ID4KPiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+ID5pbmRleCA2YWNhOGExY2NkYjYu LmUzNDZkMGFkOTJlMCAxMDA2NDQKPiA+LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1 ZmZlci5jCj4gPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+ID5AQCAt MTk1LDggKzE5NSwxMyBAQCBzdGF0aWMgaW50IGZyYW1lYnVmZmVyX2NoZWNrKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gPglmb3IgKGkgPSAwOyBpIDwgaW5mby0+bnVtX3BsYW5lczsgaSsrKSB7 Cj4gPgkJdW5zaWduZWQgaW50IHdpZHRoID0gZmJfcGxhbmVfd2lkdGgoci0+d2lkdGgsIGluZm8s IGkpOwo+ID4JCXVuc2lnbmVkIGludCBoZWlnaHQgPSBmYl9wbGFuZV9oZWlnaHQoci0+aGVpZ2h0 LCBpbmZvLCBpKTsKPiA+KwkJdW5zaWduZWQgaW50IGJsb2NrX3NpemUgPSBpbmZvLT5jaGFyX3Bl cl9ibG9ja1tpXTsKPiA+CQl1NjQgbWluX3BpdGNoID0gZHJtX2Zvcm1hdF9pbmZvX21pbl9waXRj aChpbmZvLCBpLCB3aWR0aCk7Cj4gPgo+ID4rCQlpZiAoIWJsb2NrX3NpemUgJiYgKHItPm1vZGlm aWVyW2ldID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUikpIHsKPiA+KwkJCURSTV9ERUJVR19LTVMo IkZvcm1hdCByZXF1aXJlcyBub24tbGluZWFyIG1vZGlmaWVyIGZvciBwbGFuZSAlZFxuIiwgaSk7 Cj4gPisJCQlyZXR1cm4gLUVJTlZBTDsKPiA+KwkJfQo+IAo+IFlvdSBjb3VsZCBwcm9iYWJseSBt b3ZlIHRoYXQgYmxhbmsgbGlrZSBmcm9tIFBhdGNoIDIgdG8gaGVyZSA7LSkKPiBPdGhlcndpc2Ug TEdUTToKCkkgYmxhbWUgcmViYXNlIDopCgo+IAo+IFJldmlld2VkIEJ5OiBCcmlhbiBTdGFya2V5 IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cj4gCj4gPgkJaWYgKCFyLT5oYW5kbGVzW2ldKSB7Cj4g PgkJCURSTV9ERUJVR19LTVMoIm5vIGJ1ZmZlciBvYmplY3QgaGFuZGxlIGZvciBwbGFuZSAlZFxu IiwgaSk7Cj4gPgkJCXJldHVybiAtRUlOVkFMOwo+ID5AQCAtMjA4LDcgKzIxMyw3IEBAIHN0YXRp YyBpbnQgZnJhbWVidWZmZXJfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+CQlpZiAo KHVpbnQ2NF90KSBoZWlnaHQgKiByLT5waXRjaGVzW2ldICsgci0+b2Zmc2V0c1tpXSA+IFVJTlRf TUFYKQo+ID4JCQlyZXR1cm4gLUVSQU5HRTsKPiA+Cj4gPi0JCWlmIChyLT5waXRjaGVzW2ldIDwg bWluX3BpdGNoKSB7Cj4gPisJCWlmIChibG9ja19zaXplICYmIHItPnBpdGNoZXNbaV0gPCBtaW5f cGl0Y2gpIHsKPiA+CQkJRFJNX0RFQlVHX0tNUygiYmFkIHBpdGNoICV1IGZvciBwbGFuZSAlZFxu Iiwgci0+cGl0Y2hlc1tpXSwgaSk7Cj4gPgkJCXJldHVybiAtRUlOVkFMOwo+ID4JCX0KPiA+LS0g Cj4gPjIuMTguMAo+ID4KCi0tIApDaGVlcnMsCkFsZXggRwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK