From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Marc Orr <marcorr@google.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: kvm@vger.kernel.org, jmattson@google.com, rientjes@google.com
Subject: Re: [kvm PATCH 1/2] mm: export __vmalloc_node_range()
Date: Mon, 22 Oct 2018 16:06:17 -0400 [thread overview]
Message-ID: <20181022200617.GD14374@char.us.oracle.com> (raw)
In-Reply-To: <20181020211200.255171-2-marcorr@google.com>
On Sat, Oct 20, 2018 at 02:11:59PM -0700, Marc Orr wrote:
> The __vmalloc_node_range() is in the include/linux/vmalloc.h file, but
> it's not exported so it can't be used. This patch exports the API. The
> motivation to export it is so that we can do aligned vmalloc's of KVM
> vcpus.
Would it make more sense to change it to not have __ in front of it?
Also you forgot to CC the linux-mm folks. Doing that for you.
>
> Signed-off-by: Marc Orr <marcorr@google.com>
> ---
> mm/vmalloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index a728fc492557..9e7974ab1da4 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1763,6 +1763,7 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
> "vmalloc: allocation failure: %lu bytes", real_size);
> return NULL;
> }
> +EXPORT_SYMBOL_GPL(__vmalloc_node_range);
>
> /**
> * __vmalloc_node - allocate virtually contiguous memory
> --
> 2.19.1.568.g152ad8e336-goog
>
next parent reply other threads:[~2018-10-22 20:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181020211200.255171-1-marcorr@google.com>
[not found] ` <20181020211200.255171-2-marcorr@google.com>
2018-10-22 20:06 ` Konrad Rzeszutek Wilk [this message]
2018-10-23 12:33 ` [kvm PATCH 1/2] mm: export __vmalloc_node_range() Michal Hocko
2018-10-23 21:10 ` Marc Orr
2018-10-24 6:16 ` Michal Hocko
2018-10-24 8:12 ` Marc Orr
2018-10-24 8:22 ` Michal Hocko
2018-10-23 21:13 ` [kvm PATCH 0/2] kvm: vmalloc vmx vcpus Marc Orr
[not found] ` <20181020211200.255171-3-marcorr@google.com>
2018-10-23 21:13 ` [kvm PATCH 2/2] kvm: vmx: use vmalloc() to allocate vcpus Marc Orr
2018-10-24 11:41 ` Matthew Wilcox
2018-10-24 18:05 ` Marc Orr
2018-10-25 12:58 ` Michal Hocko
2018-10-24 22:31 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022200617.GD14374@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcorr@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.